aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAntti Palosaari <crope@iki.fi>2014-12-06 15:53:16 -0500
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2015-01-29 15:46:05 -0500
commitc32b281628bec1a02b7847e9e14e0b9556a17f74 (patch)
tree5d17e45f5c608071d0550fcae04c8c6eed0629e8
parent9b7839c3061cfc4f9087c2ad67d56e844d087c55 (diff)
[media] si2168: change firmware variable name and type
Rename firmware variable from fw_file to fw_name and change its type from u8 to const char as request_firmware() input defines. Signed-off-by: Antti Palosaari <crope@iki.fi> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
-rw-r--r--drivers/media/dvb-frontends/si2168.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index 25fe63a2fb1f..63341f485f9f 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -347,7 +347,7 @@ static int si2168_init(struct dvb_frontend *fe)
347 struct si2168_dev *dev = i2c_get_clientdata(client); 347 struct si2168_dev *dev = i2c_get_clientdata(client);
348 int ret, len, remaining; 348 int ret, len, remaining;
349 const struct firmware *fw; 349 const struct firmware *fw;
350 u8 *fw_file; 350 const char *fw_name;
351 struct si2168_cmd cmd; 351 struct si2168_cmd cmd;
352 unsigned int chip_id; 352 unsigned int chip_id;
353 353
@@ -405,13 +405,13 @@ static int si2168_init(struct dvb_frontend *fe)
405 405
406 switch (chip_id) { 406 switch (chip_id) {
407 case SI2168_A20: 407 case SI2168_A20:
408 fw_file = SI2168_A20_FIRMWARE; 408 fw_name = SI2168_A20_FIRMWARE;
409 break; 409 break;
410 case SI2168_A30: 410 case SI2168_A30:
411 fw_file = SI2168_A30_FIRMWARE; 411 fw_name = SI2168_A30_FIRMWARE;
412 break; 412 break;
413 case SI2168_B40: 413 case SI2168_B40:
414 fw_file = SI2168_B40_FIRMWARE; 414 fw_name = SI2168_B40_FIRMWARE;
415 break; 415 break;
416 default: 416 default:
417 dev_err(&client->dev, "unknown chip version Si21%d-%c%c%c\n", 417 dev_err(&client->dev, "unknown chip version Si21%d-%c%c%c\n",
@@ -425,12 +425,12 @@ static int si2168_init(struct dvb_frontend *fe)
425 cmd.args[2], cmd.args[1], cmd.args[3], cmd.args[4]); 425 cmd.args[2], cmd.args[1], cmd.args[3], cmd.args[4]);
426 426
427 /* request the firmware, this will block and timeout */ 427 /* request the firmware, this will block and timeout */
428 ret = request_firmware(&fw, fw_file, &client->dev); 428 ret = request_firmware(&fw, fw_name, &client->dev);
429 if (ret) { 429 if (ret) {
430 /* fallback mechanism to handle old name for Si2168 B40 fw */ 430 /* fallback mechanism to handle old name for Si2168 B40 fw */
431 if (chip_id == SI2168_B40) { 431 if (chip_id == SI2168_B40) {
432 fw_file = SI2168_B40_FIRMWARE_FALLBACK; 432 fw_name = SI2168_B40_FIRMWARE_FALLBACK;
433 ret = request_firmware(&fw, fw_file, &client->dev); 433 ret = request_firmware(&fw, fw_name, &client->dev);
434 } 434 }
435 435
436 if (ret == 0) { 436 if (ret == 0) {
@@ -440,13 +440,13 @@ static int si2168_init(struct dvb_frontend *fe)
440 } else { 440 } else {
441 dev_err(&client->dev, 441 dev_err(&client->dev,
442 "firmware file '%s' not found\n", 442 "firmware file '%s' not found\n",
443 fw_file); 443 fw_name);
444 goto err_release_firmware; 444 goto err_release_firmware;
445 } 445 }
446 } 446 }
447 447
448 dev_info(&client->dev, "downloading firmware from file '%s'\n", 448 dev_info(&client->dev, "downloading firmware from file '%s'\n",
449 fw_file); 449 fw_name);
450 450
451 if ((fw->size % 17 == 0) && (fw->data[0] > 5)) { 451 if ((fw->size % 17 == 0) && (fw->data[0] > 5)) {
452 /* firmware is in the new format */ 452 /* firmware is in the new format */