aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJisheng Zhang <jszhang@marvell.com>2015-01-05 02:59:19 -0500
committerUlf Hansson <ulf.hansson@linaro.org>2015-01-21 08:20:01 -0500
commitc25d9e1bda2316aa0d2bb61640ab4fbe01feb590 (patch)
tree4e21747a55dfa0597671e0a31af32308284475d9
parentbe186ad5826ab6a06b585802dd5052d9674699ac (diff)
mmc: sdhci-pxav3: Remove checks for optional core clock in error/remove path
Commit 63589e92c2d9 ("clk: Ignore error and NULL pointers passed to clk_{unprepare, disable}()") allows NULL or error pointer to be passed unconditionally. This patch is to simplify probe error and remove code paths. However, we reserve the core clock checks in runtime suspend/resume code because we want a little smaller latency. Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
-rw-r--r--drivers/mmc/host/sdhci-pxav3.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 4de39fb6dc2d..63967b85dc42 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -398,8 +398,7 @@ err_of_parse:
398err_cd_req: 398err_cd_req:
399err_mbus_win: 399err_mbus_win:
400 clk_disable_unprepare(pxa->clk_io); 400 clk_disable_unprepare(pxa->clk_io);
401 if (!IS_ERR(pxa->clk_core)) 401 clk_disable_unprepare(pxa->clk_core);
402 clk_disable_unprepare(pxa->clk_core);
403err_clk_get: 402err_clk_get:
404 sdhci_pltfm_free(pdev); 403 sdhci_pltfm_free(pdev);
405 return ret; 404 return ret;
@@ -418,8 +417,7 @@ static int sdhci_pxav3_remove(struct platform_device *pdev)
418 sdhci_remove_host(host, 1); 417 sdhci_remove_host(host, 1);
419 418
420 clk_disable_unprepare(pxa->clk_io); 419 clk_disable_unprepare(pxa->clk_io);
421 if (!IS_ERR(pxa->clk_core)) 420 clk_disable_unprepare(pxa->clk_core);
422 clk_disable_unprepare(pxa->clk_core);
423 421
424 sdhci_pltfm_free(pdev); 422 sdhci_pltfm_free(pdev);
425 423