aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLennert Buytenhek <buytenh@wantstofly.org>2008-03-18 14:37:19 -0400
committerJeff Garzik <jgarzik@redhat.com>2008-04-16 20:06:49 -0400
commitc1b35a28f20c2d6ff8c5a2a035002c06b9f498c9 (patch)
tree5f529d3a560669e99a598b7707dbb9c16e671cf0
parentafdb57a2499a630d82b234307b1fc928088b9174 (diff)
mv643xx_eth: report netdev name in all printks
In error and warning printks, always report the netdevice name instead of the port index (the latter has no meaning when there are multiple mv643xx_eth silicon blocks in the system.) Signed-off-by: Lennert Buytenhek <buytenh@marvell.com> Reviewed-by: Tzachi Perelstein <tzachi@marvell.com> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
-rw-r--r--drivers/net/mv643xx_eth.c17
1 files changed, 6 insertions, 11 deletions
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index b31844cb1ab4..5a4ae86e145f 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -1315,8 +1315,7 @@ static int mv643xx_eth_open(struct net_device *dev)
1315 err = request_irq(dev->irq, mv643xx_eth_int_handler, 1315 err = request_irq(dev->irq, mv643xx_eth_int_handler,
1316 IRQF_SHARED | IRQF_SAMPLE_RANDOM, dev->name, dev); 1316 IRQF_SHARED | IRQF_SAMPLE_RANDOM, dev->name, dev);
1317 if (err) { 1317 if (err) {
1318 printk(KERN_ERR "Can not assign IRQ number to MV643XX_eth%d\n", 1318 printk(KERN_ERR "%s: Can not assign IRQ\n", dev->name);
1319 port_num);
1320 return -EAGAIN; 1319 return -EAGAIN;
1321 } 1320 }
1322 1321
@@ -1916,9 +1915,8 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
1916 1915
1917 err = ethernet_phy_detect(mp); 1916 err = ethernet_phy_detect(mp);
1918 if (err) { 1917 if (err) {
1919 pr_debug("MV643xx ethernet port %d: " 1918 pr_debug("%s: No PHY detected at addr %d\n",
1920 "No PHY detected at addr %d\n", 1919 dev->name, ethernet_phy_get(mp));
1921 port_num, ethernet_phy_get(mp));
1922 goto out; 1920 goto out;
1923 } 1921 }
1924 1922
@@ -2909,8 +2907,7 @@ static void eth_port_read_smi_reg(struct mv643xx_private *mp,
2909 /* wait for the SMI register to become available */ 2907 /* wait for the SMI register to become available */
2910 for (i = 0; mv_read(SMI_REG) & ETH_SMI_BUSY; i++) { 2908 for (i = 0; mv_read(SMI_REG) & ETH_SMI_BUSY; i++) {
2911 if (i == PHY_WAIT_ITERATIONS) { 2909 if (i == PHY_WAIT_ITERATIONS) {
2912 printk("mv643xx PHY busy timeout, port %d\n", 2910 printk("%s: PHY busy timeout\n", mp->dev->name);
2913 mp->port_num);
2914 goto out; 2911 goto out;
2915 } 2912 }
2916 udelay(PHY_WAIT_MICRO_SECONDS); 2913 udelay(PHY_WAIT_MICRO_SECONDS);
@@ -2922,8 +2919,7 @@ static void eth_port_read_smi_reg(struct mv643xx_private *mp,
2922 /* now wait for the data to be valid */ 2919 /* now wait for the data to be valid */
2923 for (i = 0; !(mv_read(SMI_REG) & ETH_SMI_READ_VALID); i++) { 2920 for (i = 0; !(mv_read(SMI_REG) & ETH_SMI_READ_VALID); i++) {
2924 if (i == PHY_WAIT_ITERATIONS) { 2921 if (i == PHY_WAIT_ITERATIONS) {
2925 printk("mv643xx PHY read timeout, port %d\n", 2922 printk("%s: PHY read timeout\n", mp->dev->name);
2926 mp->port_num);
2927 goto out; 2923 goto out;
2928 } 2924 }
2929 udelay(PHY_WAIT_MICRO_SECONDS); 2925 udelay(PHY_WAIT_MICRO_SECONDS);
@@ -2969,8 +2965,7 @@ static void eth_port_write_smi_reg(struct mv643xx_private *mp,
2969 /* wait for the SMI register to become available */ 2965 /* wait for the SMI register to become available */
2970 for (i = 0; mv_read(SMI_REG) & ETH_SMI_BUSY; i++) { 2966 for (i = 0; mv_read(SMI_REG) & ETH_SMI_BUSY; i++) {
2971 if (i == PHY_WAIT_ITERATIONS) { 2967 if (i == PHY_WAIT_ITERATIONS) {
2972 printk("mv643xx PHY busy timeout, port %d\n", 2968 printk("%s: PHY busy timeout\n", mp->dev->name);
2973 mp->port_num);
2974 goto out; 2969 goto out;
2975 } 2970 }
2976 udelay(PHY_WAIT_MICRO_SECONDS); 2971 udelay(PHY_WAIT_MICRO_SECONDS);