diff options
author | Dave Hansen <dave.hansen@linux.intel.com> | 2014-10-31 17:58:20 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2014-11-17 18:58:52 -0500 |
commit | c04e051cccd2446d9ca373628d14b7e732462f5d (patch) | |
tree | fe900bd3094f0e6d8574cde4e238cefc86278191 | |
parent | 6ba48ff46f764414f979d2eacb23c4e6296bcc95 (diff) |
x86: mpx: Give bndX registers actual names
Consider the bndX MPX registers. There 4 registers each
containing a 64-bit lower and a 64-bit upper bound. That's 8*64
bits and we declare it thusly:
struct bndregs_struct {
u64 bndregs[8];
}
Let's say you want to read the upper bound from the MPX register
bnd2 out of the xsave buf. You do:
bndregno = 2;
upper_bound = xsave_buf->bndregs.bndregs[2*bndregno+1];
That kinda sucks. Every time you access it, you need to know:
1. Each bndX register is two entries wide in "bndregs"
2. The lower comes first followed by upper. We do the +1 to get
upper vs. lower.
This replaces the old definition. You can now access them
indexed by the register number directly, and with a meaningful
name for the lower and upper bound:
bndregno = 2;
xsave_buf->bndreg[bndregno].upper_bound;
It's now *VERY* clear that there are 4 registers. The programmer
now doesn't have to care what order the lower and upper bounds
are in, and it's harder to get it wrong.
[ tglx: Changed ub/lb to upper_bound/lower_bound and renamed struct
bndreg_struct to struct bndreg ]
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Qiaowei Ren <qiaowei.ren@intel.com>
Cc: "Yu, Fenghua" <fenghua.yu@intel.com>
Cc: Dave Hansen <dave@sr71.net>
Link: http://lkml.kernel.org/r/20141031215820.5EA5E0EC@viggo.jf.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r-- | arch/x86/include/asm/processor.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index eb71ec794732..0f2263a8ad31 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h | |||
@@ -374,8 +374,9 @@ struct lwp_struct { | |||
374 | u8 reserved[128]; | 374 | u8 reserved[128]; |
375 | }; | 375 | }; |
376 | 376 | ||
377 | struct bndregs_struct { | 377 | struct bndreg { |
378 | u64 bndregs[8]; | 378 | u64 lower_bound; |
379 | u64 upper_bound; | ||
379 | } __packed; | 380 | } __packed; |
380 | 381 | ||
381 | struct bndcsr_struct { | 382 | struct bndcsr_struct { |
@@ -394,7 +395,7 @@ struct xsave_struct { | |||
394 | struct xsave_hdr_struct xsave_hdr; | 395 | struct xsave_hdr_struct xsave_hdr; |
395 | struct ymmh_struct ymmh; | 396 | struct ymmh_struct ymmh; |
396 | struct lwp_struct lwp; | 397 | struct lwp_struct lwp; |
397 | struct bndregs_struct bndregs; | 398 | struct bndreg bndreg[4]; |
398 | struct bndcsr_struct bndcsr; | 399 | struct bndcsr_struct bndcsr; |
399 | /* new processor state extensions will go here */ | 400 | /* new processor state extensions will go here */ |
400 | } __attribute__ ((packed, aligned (64))); | 401 | } __attribute__ ((packed, aligned (64))); |