diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2015-04-03 13:12:58 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2015-04-10 09:25:30 -0400 |
commit | befd25a2bd61f1706508280f705e18be8b283e3e (patch) | |
tree | 8953d6cba0623cf0fac1524fd6975ab2042bc5cb | |
parent | 9a1a8f9953f3f101ce769878fc7bbbc43a4fd2dc (diff) |
[media] media: omap3isp: remove unused clkdev
No merged platform supplies xclks via platform data. As we want to
slightly change the clkdev interface, rather than fixing this unused
code, remove it instead.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
-rw-r--r-- | drivers/media/platform/omap3isp/isp.c | 24 | ||||
-rw-r--r-- | drivers/media/platform/omap3isp/isp.h | 1 | ||||
-rw-r--r-- | include/media/omap3isp.h | 6 |
3 files changed, 0 insertions, 31 deletions
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index ff51c4f9d35e..18d0a871747f 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c | |||
@@ -304,7 +304,6 @@ static struct clk *isp_xclk_src_get(struct of_phandle_args *clkspec, void *data) | |||
304 | 304 | ||
305 | static int isp_xclk_init(struct isp_device *isp) | 305 | static int isp_xclk_init(struct isp_device *isp) |
306 | { | 306 | { |
307 | struct isp_platform_data *pdata = isp->pdata; | ||
308 | struct device_node *np = isp->dev->of_node; | 307 | struct device_node *np = isp->dev->of_node; |
309 | struct clk_init_data init; | 308 | struct clk_init_data init; |
310 | unsigned int i; | 309 | unsigned int i; |
@@ -335,26 +334,6 @@ static int isp_xclk_init(struct isp_device *isp) | |||
335 | xclk->clk = clk_register(NULL, &xclk->hw); | 334 | xclk->clk = clk_register(NULL, &xclk->hw); |
336 | if (IS_ERR(xclk->clk)) | 335 | if (IS_ERR(xclk->clk)) |
337 | return PTR_ERR(xclk->clk); | 336 | return PTR_ERR(xclk->clk); |
338 | |||
339 | /* When instantiated from DT we don't need to register clock | ||
340 | * aliases. | ||
341 | */ | ||
342 | if (np) | ||
343 | continue; | ||
344 | |||
345 | if (!pdata || (pdata->xclks[i].con_id == NULL && | ||
346 | pdata->xclks[i].dev_id == NULL)) | ||
347 | continue; | ||
348 | |||
349 | xclk->lookup = kzalloc(sizeof(*xclk->lookup), GFP_KERNEL); | ||
350 | if (xclk->lookup == NULL) | ||
351 | return -ENOMEM; | ||
352 | |||
353 | xclk->lookup->con_id = pdata->xclks[i].con_id; | ||
354 | xclk->lookup->dev_id = pdata->xclks[i].dev_id; | ||
355 | xclk->lookup->clk = xclk->clk; | ||
356 | |||
357 | clkdev_add(xclk->lookup); | ||
358 | } | 337 | } |
359 | 338 | ||
360 | if (np) | 339 | if (np) |
@@ -376,9 +355,6 @@ static void isp_xclk_cleanup(struct isp_device *isp) | |||
376 | 355 | ||
377 | if (!IS_ERR(xclk->clk)) | 356 | if (!IS_ERR(xclk->clk)) |
378 | clk_unregister(xclk->clk); | 357 | clk_unregister(xclk->clk); |
379 | |||
380 | if (xclk->lookup) | ||
381 | clkdev_drop(xclk->lookup); | ||
382 | } | 358 | } |
383 | } | 359 | } |
384 | 360 | ||
diff --git a/drivers/media/platform/omap3isp/isp.h b/drivers/media/platform/omap3isp/isp.h index 431224ec09ed..e579943175c4 100644 --- a/drivers/media/platform/omap3isp/isp.h +++ b/drivers/media/platform/omap3isp/isp.h | |||
@@ -132,7 +132,6 @@ enum isp_xclk_id { | |||
132 | struct isp_xclk { | 132 | struct isp_xclk { |
133 | struct isp_device *isp; | 133 | struct isp_device *isp; |
134 | struct clk_hw hw; | 134 | struct clk_hw hw; |
135 | struct clk_lookup *lookup; | ||
136 | struct clk *clk; | 135 | struct clk *clk; |
137 | enum isp_xclk_id id; | 136 | enum isp_xclk_id id; |
138 | 137 | ||
diff --git a/include/media/omap3isp.h b/include/media/omap3isp.h index 0f0c08b48829..048f8f9117ef 100644 --- a/include/media/omap3isp.h +++ b/include/media/omap3isp.h | |||
@@ -150,13 +150,7 @@ struct isp_platform_subdev { | |||
150 | struct isp_bus_cfg *bus; | 150 | struct isp_bus_cfg *bus; |
151 | }; | 151 | }; |
152 | 152 | ||
153 | struct isp_platform_xclk { | ||
154 | const char *dev_id; | ||
155 | const char *con_id; | ||
156 | }; | ||
157 | |||
158 | struct isp_platform_data { | 153 | struct isp_platform_data { |
159 | struct isp_platform_xclk xclks[2]; | ||
160 | struct isp_platform_subdev *subdevs; | 154 | struct isp_platform_subdev *subdevs; |
161 | void (*set_constraints)(struct isp_device *isp, bool enable); | 155 | void (*set_constraints)(struct isp_device *isp, bool enable); |
162 | }; | 156 | }; |