aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSantiago Leon <santil@linux.vnet.ibm.com>2010-09-03 14:29:36 -0400
committerDavid S. Miller <davem@davemloft.net>2010-09-06 21:21:54 -0400
commitbe35ae9e08dbbc70f1cd50de8639627fa501692d (patch)
tree49be406d5b1b06104a4fcfd787755b81223f57f0
parentf148f61d89995660e8aa20a2784ecd9c7f25e2a6 (diff)
ibmveth: Return -EINVAL on all ->probe errors
We had a few cases where we returned success on error. Signed-off-by: Anton Blanchard <anton@samba.org> Signed-off-by: Santiago Leon <santil@linux.vnet.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ibmveth.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index 8adfff55792d..11086dbe76e8 100644
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -1392,7 +1392,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
1392 NULL); 1392 NULL);
1393 if (!mac_addr_p) { 1393 if (!mac_addr_p) {
1394 dev_err(&dev->dev, "Can't find VETH_MAC_ADDR attribute\n"); 1394 dev_err(&dev->dev, "Can't find VETH_MAC_ADDR attribute\n");
1395 return 0; 1395 return -EINVAL;
1396 } 1396 }
1397 1397
1398 mcastFilterSize_p = (unsigned int *)vio_get_attribute(dev, 1398 mcastFilterSize_p = (unsigned int *)vio_get_attribute(dev,
@@ -1400,7 +1400,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
1400 if (!mcastFilterSize_p) { 1400 if (!mcastFilterSize_p) {
1401 dev_err(&dev->dev, "Can't find VETH_MCAST_FILTER_SIZE " 1401 dev_err(&dev->dev, "Can't find VETH_MCAST_FILTER_SIZE "
1402 "attribute\n"); 1402 "attribute\n");
1403 return 0; 1403 return -EINVAL;
1404 } 1404 }
1405 1405
1406 netdev = alloc_etherdev(sizeof(struct ibmveth_adapter)); 1406 netdev = alloc_etherdev(sizeof(struct ibmveth_adapter));