aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Lendacky <thomas.lendacky@amd.com>2015-02-03 14:07:23 -0500
committerHerbert Xu <herbert@gondor.apana.org.au>2015-02-27 04:48:48 -0500
commitbe03a3a0961eba0bc695fa91ac87efe5f4b8f40c (patch)
tree7596612d757a27c640c15d12c881ec8a0001c1cb
parent261bf074899a1a4624d8a0c6bfae3e92d12ef19f (diff)
crypto: ccp - Convert calls to their devm_ counterparts
Where applicable, convert calls to their devm_ counterparts, e.g. kzalloc to devm_kzalloc. Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--drivers/crypto/ccp/ccp-dev.c2
-rw-r--r--drivers/crypto/ccp/ccp-pci.c19
-rw-r--r--drivers/crypto/ccp/ccp-platform.c11
3 files changed, 9 insertions, 23 deletions
diff --git a/drivers/crypto/ccp/ccp-dev.c b/drivers/crypto/ccp/ccp-dev.c
index 68c637af2c42..861bacc1bb94 100644
--- a/drivers/crypto/ccp/ccp-dev.c
+++ b/drivers/crypto/ccp/ccp-dev.c
@@ -295,7 +295,7 @@ struct ccp_device *ccp_alloc_struct(struct device *dev)
295{ 295{
296 struct ccp_device *ccp; 296 struct ccp_device *ccp;
297 297
298 ccp = kzalloc(sizeof(*ccp), GFP_KERNEL); 298 ccp = devm_kzalloc(dev, sizeof(*ccp), GFP_KERNEL);
299 if (!ccp) 299 if (!ccp)
300 return NULL; 300 return NULL;
301 ccp->dev = dev; 301 ccp->dev = dev;
diff --git a/drivers/crypto/ccp/ccp-pci.c b/drivers/crypto/ccp/ccp-pci.c
index 1980f77c29ef..af190d4795a8 100644
--- a/drivers/crypto/ccp/ccp-pci.c
+++ b/drivers/crypto/ccp/ccp-pci.c
@@ -174,11 +174,10 @@ static int ccp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
174 if (!ccp) 174 if (!ccp)
175 goto e_err; 175 goto e_err;
176 176
177 ccp_pci = kzalloc(sizeof(*ccp_pci), GFP_KERNEL); 177 ccp_pci = devm_kzalloc(dev, sizeof(*ccp_pci), GFP_KERNEL);
178 if (!ccp_pci) { 178 if (!ccp_pci)
179 ret = -ENOMEM; 179 goto e_err;
180 goto e_free1; 180
181 }
182 ccp->dev_specific = ccp_pci; 181 ccp->dev_specific = ccp_pci;
183 ccp->get_irq = ccp_get_irqs; 182 ccp->get_irq = ccp_get_irqs;
184 ccp->free_irq = ccp_free_irqs; 183 ccp->free_irq = ccp_free_irqs;
@@ -186,7 +185,7 @@ static int ccp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
186 ret = pci_request_regions(pdev, "ccp"); 185 ret = pci_request_regions(pdev, "ccp");
187 if (ret) { 186 if (ret) {
188 dev_err(dev, "pci_request_regions failed (%d)\n", ret); 187 dev_err(dev, "pci_request_regions failed (%d)\n", ret);
189 goto e_free2; 188 goto e_err;
190 } 189 }
191 190
192 ret = pci_enable_device(pdev); 191 ret = pci_enable_device(pdev);
@@ -239,12 +238,6 @@ e_device:
239e_regions: 238e_regions:
240 pci_release_regions(pdev); 239 pci_release_regions(pdev);
241 240
242e_free2:
243 kfree(ccp_pci);
244
245e_free1:
246 kfree(ccp);
247
248e_err: 241e_err:
249 dev_notice(dev, "initialization failed\n"); 242 dev_notice(dev, "initialization failed\n");
250 return ret; 243 return ret;
@@ -266,8 +259,6 @@ static void ccp_pci_remove(struct pci_dev *pdev)
266 259
267 pci_release_regions(pdev); 260 pci_release_regions(pdev);
268 261
269 kfree(ccp);
270
271 dev_notice(dev, "disabled\n"); 262 dev_notice(dev, "disabled\n");
272} 263}
273 264
diff --git a/drivers/crypto/ccp/ccp-platform.c b/drivers/crypto/ccp/ccp-platform.c
index 04265a3c3608..20661f099198 100644
--- a/drivers/crypto/ccp/ccp-platform.c
+++ b/drivers/crypto/ccp/ccp-platform.c
@@ -103,7 +103,7 @@ static int ccp_platform_probe(struct platform_device *pdev)
103 ccp->io_map = devm_ioremap_resource(dev, ior); 103 ccp->io_map = devm_ioremap_resource(dev, ior);
104 if (IS_ERR(ccp->io_map)) { 104 if (IS_ERR(ccp->io_map)) {
105 ret = PTR_ERR(ccp->io_map); 105 ret = PTR_ERR(ccp->io_map);
106 goto e_free; 106 goto e_err;
107 } 107 }
108 ccp->io_regs = ccp->io_map; 108 ccp->io_regs = ccp->io_map;
109 109
@@ -112,7 +112,7 @@ static int ccp_platform_probe(struct platform_device *pdev)
112 ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48)); 112 ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(48));
113 if (ret) { 113 if (ret) {
114 dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n", ret); 114 dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n", ret);
115 goto e_free; 115 goto e_err;
116 } 116 }
117 117
118 if (of_property_read_bool(dev->of_node, "dma-coherent")) 118 if (of_property_read_bool(dev->of_node, "dma-coherent"))
@@ -124,15 +124,12 @@ static int ccp_platform_probe(struct platform_device *pdev)
124 124
125 ret = ccp_init(ccp); 125 ret = ccp_init(ccp);
126 if (ret) 126 if (ret)
127 goto e_free; 127 goto e_err;
128 128
129 dev_notice(dev, "enabled\n"); 129 dev_notice(dev, "enabled\n");
130 130
131 return 0; 131 return 0;
132 132
133e_free:
134 kfree(ccp);
135
136e_err: 133e_err:
137 dev_notice(dev, "initialization failed\n"); 134 dev_notice(dev, "initialization failed\n");
138 return ret; 135 return ret;
@@ -145,8 +142,6 @@ static int ccp_platform_remove(struct platform_device *pdev)
145 142
146 ccp_destroy(ccp); 143 ccp_destroy(ccp);
147 144
148 kfree(ccp);
149
150 dev_notice(dev, "disabled\n"); 145 dev_notice(dev, "disabled\n");
151 146
152 return 0; 147 return 0;