net: sched: cls_basic: fix error path in basic_change()

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Reviewed-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 2 insertions, 3 deletions

diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
index 7cf0a62fc4c9..5aed341406c2 100644
--- a/net/sched/cls_basic.c
+++ b/net/sched/cls_basic.c
@@ -178,10 +178,9 @@ static int basic_change(struct net *net, struct sk_buff *in_skb,
                         return -EINVAL;
         }
 
-        err = -ENOBUFS;
         fnew = kzalloc(sizeof(*fnew), GFP_KERNEL);
-        if (fnew == NULL)
-                goto errout;
+        if (!fnew)
+                return -ENOBUFS;
 
         tcf_exts_init(&fnew->exts, TCA_BASIC_ACT, TCA_BASIC_POLICE);
         err = -EINVAL;