diff options
author | Jack Morgenstein <jackm@dev.mellanox.co.il> | 2014-05-29 09:31:00 -0400 |
---|---|---|
committer | Roland Dreier <roland@purestorage.com> | 2014-05-30 00:12:58 -0400 |
commit | bc82878baa10c2a6a4a6affaf52c152935112142 (patch) | |
tree | bee25d3a8e9182f2e340cb5366af1df530998f70 | |
parent | b38f2879b7d2d51747de2ea9062c698a6ac64cb1 (diff) |
mlx4_core: Fix incorrect FLAGS1 bitmap test in mlx4_QUERY_FUNC_CAP
Commit eb17711bc1d6 ("net/mlx4_core: Introduce nic_info new flag in
QUERY_FUNC_CAP") did:
if (func_cap->flags1 & QUERY_FUNC_CAP_FLAGS1_OFFSET) {
which should be:
if (func_cap->flags1 & QUERY_FUNC_CAP_FLAGS1_FORCE_VLAN) {
Fix that.
Fixes: eb17711bc1d6 ("net/mlx4_core: Introduce nic_info new flag in QUERY_FUNC_CAP")
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
-rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/fw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c index d16a4d118903..ef242e19766f 100644 --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c | |||
@@ -414,7 +414,7 @@ int mlx4_QUERY_FUNC_CAP(struct mlx4_dev *dev, u32 gen_or_port, | |||
414 | 414 | ||
415 | MLX4_GET(func_cap->flags1, outbox, QUERY_FUNC_CAP_FLAGS1_OFFSET); | 415 | MLX4_GET(func_cap->flags1, outbox, QUERY_FUNC_CAP_FLAGS1_OFFSET); |
416 | if (dev->caps.port_type[gen_or_port] == MLX4_PORT_TYPE_ETH) { | 416 | if (dev->caps.port_type[gen_or_port] == MLX4_PORT_TYPE_ETH) { |
417 | if (func_cap->flags1 & QUERY_FUNC_CAP_FLAGS1_OFFSET) { | 417 | if (func_cap->flags1 & QUERY_FUNC_CAP_FLAGS1_FORCE_VLAN) { |
418 | mlx4_err(dev, "VLAN is enforced on this port\n"); | 418 | mlx4_err(dev, "VLAN is enforced on this port\n"); |
419 | err = -EPROTONOSUPPORT; | 419 | err = -EPROTONOSUPPORT; |
420 | goto out; | 420 | goto out; |