aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2012-11-21 10:55:38 -0500
committerOleg Nesterov <oleg@redhat.com>2013-02-08 11:46:59 -0500
commitbbc33d05930f870ea049eae5ed980f8b827d0813 (patch)
treed954de9e4f6319bb3774721698144f3639e95dbf
parent661e591525ffbb0439270bf2a4d165c04f87543d (diff)
uprobes: Move __set_bit(UPROBE_SKIP_SSTEP) into alloc_uprobe()
Cosmetic. __set_bit(UPROBE_SKIP_SSTEP) is the part of initialization, it is not clear why it is set in insert_uprobe(). Signed-off-by: Oleg Nesterov <oleg@redhat.com> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
-rw-r--r--kernel/events/uprobes.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 30ea9a4f4ab4..afbab2cb2742 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -430,9 +430,6 @@ static struct uprobe *insert_uprobe(struct uprobe *uprobe)
430 u = __insert_uprobe(uprobe); 430 u = __insert_uprobe(uprobe);
431 spin_unlock(&uprobes_treelock); 431 spin_unlock(&uprobes_treelock);
432 432
433 /* For now assume that the instruction need not be single-stepped */
434 __set_bit(UPROBE_SKIP_SSTEP, &uprobe->flags);
435
436 return u; 433 return u;
437} 434}
438 435
@@ -454,6 +451,8 @@ static struct uprobe *alloc_uprobe(struct inode *inode, loff_t offset)
454 uprobe->offset = offset; 451 uprobe->offset = offset;
455 init_rwsem(&uprobe->consumer_rwsem); 452 init_rwsem(&uprobe->consumer_rwsem);
456 mutex_init(&uprobe->copy_mutex); 453 mutex_init(&uprobe->copy_mutex);
454 /* For now assume that the instruction need not be single-stepped */
455 __set_bit(UPROBE_SKIP_SSTEP, &uprobe->flags);
457 456
458 /* add to uprobes_tree, sorted on inode:offset */ 457 /* add to uprobes_tree, sorted on inode:offset */
459 cur_uprobe = insert_uprobe(uprobe); 458 cur_uprobe = insert_uprobe(uprobe);