netfilter: nft_redir: fix sparse warnings

>> net/netfilter/nft_redir.c:39:26: sparse: incorrect type in assignment (different base types)
   net/netfilter/nft_redir.c:39:26:    expected unsigned int [unsigned] [usertype] nla_be32
   net/netfilter/nft_redir.c:39:26:    got restricted __be32
>> net/netfilter/nft_redir.c:40:40: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:40:40: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:40:40: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:40:40: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:40:40: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:40:40: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:46:34: sparse: incorrect type in assignment (different base types)
   net/netfilter/nft_redir.c:46:34:    expected unsigned int [unsigned] [usertype] nla_be32
   net/netfilter/nft_redir.c:46:34:    got restricted __be32
>> net/netfilter/nft_redir.c:47:48: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:47:48: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:47:48: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:47:48: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:47:48: sparse: cast to restricted __be32
>> net/netfilter/nft_redir.c:47:48: sparse: cast to restricted __be32

Fixes: e9105f1 ("netfilter: nf_tables: add new expression nft_redir")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

1 files changed, 6 insertions, 5 deletions

diff --git a/net/netfilter/nft_redir.c b/net/netfilter/nft_redir.c
index e27b4e35718a..9e8093f28311 100644
--- a/net/netfilter/nft_redir.c
+++ b/net/netfilter/nft_redir.c
@@ -28,7 +28,6 @@ int nft_redir_init(const struct nft_ctx *ctx,
                    const struct nlattr * const tb[])
 {
         struct nft_redir *priv = nft_expr_priv(expr);
-        u32 nla_be32;
         int err;
 
         err = nft_chain_validate_dependency(ctx->chain, NFT_CHAIN_T_NAT);
@@ -36,15 +35,17 @@ int nft_redir_init(const struct nft_ctx *ctx,
                 return err;
 
         if (tb[NFTA_REDIR_REG_PROTO_MIN]) {
-                nla_be32 = nla_get_be32(tb[NFTA_REDIR_REG_PROTO_MIN]);
-                priv->sreg_proto_min = ntohl(nla_be32);
+                priv->sreg_proto_min =
+                        ntohl(nla_get_be32(tb[NFTA_REDIR_REG_PROTO_MIN]));
+
                 err = nft_validate_input_register(priv->sreg_proto_min);
                 if (err < 0)
                         return err;
 
                 if (tb[NFTA_REDIR_REG_PROTO_MAX]) {
-                        nla_be32 = nla_get_be32(tb[NFTA_REDIR_REG_PROTO_MAX]);
-                        priv->sreg_proto_max = ntohl(nla_be32);
+                        priv->sreg_proto_max =
+                                ntohl(nla_get_be32(tb[NFTA_REDIR_REG_PROTO_MAX]));
+
                         err = nft_validate_input_register(priv->sreg_proto_max);
                         if (err < 0)
                                 return err;