diff options
author | Johannes Berg <johannes.berg@intel.com> | 2012-03-07 12:52:39 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2012-03-08 14:00:01 -0500 |
commit | bada991b4590122c847520ed2b651b679c16afd3 (patch) | |
tree | a9a6a494034f64bf6367b7eb39f722c73ff6f7da | |
parent | 83626404a70da74c67f32f119e53c0ba032ba2d8 (diff) |
iwlwifi: remove messages from queue wake/stop
The only reason we ever stop/wake queues at
the transport level is now that they become
full (or non-full), so the messages aren't
useful any more -- remove them.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h | 36 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-trans-pcie.c | 4 |
2 files changed, 20 insertions, 20 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h index dd64e69b1569..c0e68097fcb5 100644 --- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h +++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-int.h | |||
@@ -409,7 +409,7 @@ static inline u8 iwl_get_queue_ac(struct iwl_tx_queue *txq) | |||
409 | } | 409 | } |
410 | 410 | ||
411 | static inline void iwl_wake_queue(struct iwl_trans *trans, | 411 | static inline void iwl_wake_queue(struct iwl_trans *trans, |
412 | struct iwl_tx_queue *txq, const char *msg) | 412 | struct iwl_tx_queue *txq) |
413 | { | 413 | { |
414 | u8 queue = txq->swq_id; | 414 | u8 queue = txq->swq_id; |
415 | u8 ac = queue & 3; | 415 | u8 ac = queue & 3; |
@@ -420,19 +420,19 @@ static inline void iwl_wake_queue(struct iwl_trans *trans, | |||
420 | if (test_and_clear_bit(hwq, trans_pcie->queue_stopped)) { | 420 | if (test_and_clear_bit(hwq, trans_pcie->queue_stopped)) { |
421 | if (atomic_dec_return(&trans_pcie->queue_stop_count[ac]) <= 0) { | 421 | if (atomic_dec_return(&trans_pcie->queue_stop_count[ac]) <= 0) { |
422 | iwl_op_mode_queue_not_full(trans->op_mode, ac); | 422 | iwl_op_mode_queue_not_full(trans->op_mode, ac); |
423 | IWL_DEBUG_TX_QUEUES(trans, "Wake hwq %d ac %d. %s", | 423 | IWL_DEBUG_TX_QUEUES(trans, "Wake hwq %d ac %d", |
424 | hwq, ac, msg); | 424 | hwq, ac); |
425 | } else { | 425 | } else { |
426 | IWL_DEBUG_TX_QUEUES(trans, "Don't wake hwq %d ac %d" | 426 | IWL_DEBUG_TX_QUEUES(trans, |
427 | " stop count %d. %s", | 427 | "Don't wake hwq %d ac %d stop count %d", |
428 | hwq, ac, atomic_read(&trans_pcie-> | 428 | hwq, ac, |
429 | queue_stop_count[ac]), msg); | 429 | atomic_read(&trans_pcie->queue_stop_count[ac])); |
430 | } | 430 | } |
431 | } | 431 | } |
432 | } | 432 | } |
433 | 433 | ||
434 | static inline void iwl_stop_queue(struct iwl_trans *trans, | 434 | static inline void iwl_stop_queue(struct iwl_trans *trans, |
435 | struct iwl_tx_queue *txq, const char *msg) | 435 | struct iwl_tx_queue *txq) |
436 | { | 436 | { |
437 | u8 queue = txq->swq_id; | 437 | u8 queue = txq->swq_id; |
438 | u8 ac = queue & 3; | 438 | u8 ac = queue & 3; |
@@ -443,19 +443,19 @@ static inline void iwl_stop_queue(struct iwl_trans *trans, | |||
443 | if (!test_and_set_bit(hwq, trans_pcie->queue_stopped)) { | 443 | if (!test_and_set_bit(hwq, trans_pcie->queue_stopped)) { |
444 | if (atomic_inc_return(&trans_pcie->queue_stop_count[ac]) > 0) { | 444 | if (atomic_inc_return(&trans_pcie->queue_stop_count[ac]) > 0) { |
445 | iwl_op_mode_queue_full(trans->op_mode, ac); | 445 | iwl_op_mode_queue_full(trans->op_mode, ac); |
446 | IWL_DEBUG_TX_QUEUES(trans, "Stop hwq %d ac %d" | 446 | IWL_DEBUG_TX_QUEUES(trans, |
447 | " stop count %d. %s", | 447 | "Stop hwq %d ac %d stop count %d", |
448 | hwq, ac, atomic_read(&trans_pcie-> | 448 | hwq, ac, |
449 | queue_stop_count[ac]), msg); | 449 | atomic_read(&trans_pcie->queue_stop_count[ac])); |
450 | } else { | 450 | } else { |
451 | IWL_DEBUG_TX_QUEUES(trans, "Don't stop hwq %d ac %d" | 451 | IWL_DEBUG_TX_QUEUES(trans, |
452 | " stop count %d. %s", | 452 | "Don't stop hwq %d ac %d stop count %d", |
453 | hwq, ac, atomic_read(&trans_pcie-> | 453 | hwq, ac, |
454 | queue_stop_count[ac]), msg); | 454 | atomic_read(&trans_pcie->queue_stop_count[ac])); |
455 | } | 455 | } |
456 | } else { | 456 | } else { |
457 | IWL_DEBUG_TX_QUEUES(trans, "stop hwq %d, but it is stopped/ %s", | 457 | IWL_DEBUG_TX_QUEUES(trans, "stop hwq %d, but it is stopped", |
458 | hwq, msg); | 458 | hwq); |
459 | } | 459 | } |
460 | } | 460 | } |
461 | 461 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c index 3b8a5fb771f6..6172651d7e25 100644 --- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c +++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie.c | |||
@@ -1487,7 +1487,7 @@ static int iwl_trans_pcie_tx(struct iwl_trans *trans, struct sk_buff *skb, | |||
1487 | txq->need_update = 1; | 1487 | txq->need_update = 1; |
1488 | iwl_txq_update_write_ptr(trans, txq); | 1488 | iwl_txq_update_write_ptr(trans, txq); |
1489 | } else { | 1489 | } else { |
1490 | iwl_stop_queue(trans, txq, "Queue is full"); | 1490 | iwl_stop_queue(trans, txq); |
1491 | } | 1491 | } |
1492 | } | 1492 | } |
1493 | spin_unlock(&txq->lock); | 1493 | spin_unlock(&txq->lock); |
@@ -1591,7 +1591,7 @@ static int iwl_trans_pcie_reclaim(struct iwl_trans *trans, int sta_id, int tid, | |||
1591 | tfd_num, ssn); | 1591 | tfd_num, ssn); |
1592 | freed = iwl_tx_queue_reclaim(trans, txq_id, tfd_num, skbs); | 1592 | freed = iwl_tx_queue_reclaim(trans, txq_id, tfd_num, skbs); |
1593 | if (iwl_queue_space(&txq->q) > txq->q.low_mark) | 1593 | if (iwl_queue_space(&txq->q) > txq->q.low_mark) |
1594 | iwl_wake_queue(trans, txq, "Packets reclaimed"); | 1594 | iwl_wake_queue(trans, txq); |
1595 | } | 1595 | } |
1596 | 1596 | ||
1597 | spin_unlock(&txq->lock); | 1597 | spin_unlock(&txq->lock); |