diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2010-11-24 12:37:17 -0500 |
---|---|---|
committer | Chris Wilson <chris@chris-wilson.co.uk> | 2010-11-24 12:37:17 -0500 |
commit | ba84cd1f2b5dd49bda9300c5a11373f7e14c3c66 (patch) | |
tree | 45b7fe1c0c146ad1b995dd95399c0d5614e920c4 | |
parent | cc840f77036fa0a141951967cd010014f088b5e0 (diff) |
drm/i915/sdvo: Always add a 30ms delay to make SDVO TV detection reliable
Commit d09c23de intended to add a 30ms delay to give the ADD time to
detect any TVs connected. However, it used the sdvo->is_tv flag to do so
which is dependent upon the previous detection result and not whether the
output supports TVs.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: stable@kernel.org
-rw-r--r-- | drivers/gpu/drm/i915/intel_sdvo.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index bf643100dec8..d97e6cb52d34 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/drm/i915/intel_sdvo.c | |||
@@ -1377,10 +1377,12 @@ intel_sdvo_detect(struct drm_connector *connector, bool force) | |||
1377 | if (!intel_sdvo_write_cmd(intel_sdvo, | 1377 | if (!intel_sdvo_write_cmd(intel_sdvo, |
1378 | SDVO_CMD_GET_ATTACHED_DISPLAYS, NULL, 0)) | 1378 | SDVO_CMD_GET_ATTACHED_DISPLAYS, NULL, 0)) |
1379 | return connector_status_unknown; | 1379 | return connector_status_unknown; |
1380 | if (intel_sdvo->is_tv) { | 1380 | |
1381 | /* add 30ms delay when the output type is SDVO-TV */ | 1381 | /* add 30ms delay when the output type might be TV */ |
1382 | if (intel_sdvo->caps.output_flags & | ||
1383 | (SDVO_OUTPUT_SVID0 | SDVO_OUTPUT_CVBS0)) | ||
1382 | mdelay(30); | 1384 | mdelay(30); |
1383 | } | 1385 | |
1384 | if (!intel_sdvo_read_response(intel_sdvo, &response, 2)) | 1386 | if (!intel_sdvo_read_response(intel_sdvo, &response, 2)) |
1385 | return connector_status_unknown; | 1387 | return connector_status_unknown; |
1386 | 1388 | ||