diff options
| author | Pavel Emelyanov <xemul@openvz.org> | 2007-10-19 02:40:40 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-19 14:53:43 -0400 |
| commit | ba25f9dcc4ea6e30839fcab5a5516f2176d5bfed (patch) | |
| tree | 3123c03b25dd5c0cd24b6ab4fc16731217838157 | |
| parent | 9a2e70572e94e21e7ec4186702d045415422bda0 (diff) | |
Use helpers to obtain task pid in printks
The task_struct->pid member is going to be deprecated, so start
using the helpers (task_pid_nr/task_pid_vnr/task_pid_nr_ns) in
the kernel.
The first thing to start with is the pid, printed to dmesg - in
this case we may safely use task_pid_nr(). Besides, printks produce
more (much more) than a half of all the explicit pid usage.
[akpm@linux-foundation.org: git-drm went and changed lots of stuff]
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Dave Airlie <airlied@linux.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
47 files changed, 97 insertions, 90 deletions
diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c index 501edfa807a0..8025d646ab30 100644 --- a/block/ll_rw_blk.c +++ b/block/ll_rw_blk.c | |||
| @@ -3367,7 +3367,7 @@ void submit_bio(int rw, struct bio *bio) | |||
| 3367 | if (unlikely(block_dump)) { | 3367 | if (unlikely(block_dump)) { |
| 3368 | char b[BDEVNAME_SIZE]; | 3368 | char b[BDEVNAME_SIZE]; |
| 3369 | printk(KERN_DEBUG "%s(%d): %s block %Lu on %s\n", | 3369 | printk(KERN_DEBUG "%s(%d): %s block %Lu on %s\n", |
| 3370 | current->comm, current->pid, | 3370 | current->comm, task_pid_nr(current), |
| 3371 | (rw & WRITE) ? "WRITE" : "READ", | 3371 | (rw & WRITE) ? "WRITE" : "READ", |
| 3372 | (unsigned long long)bio->bi_sector, | 3372 | (unsigned long long)bio->bi_sector, |
| 3373 | bdevname(bio->bi_bdev,b)); | 3373 | bdevname(bio->bi_bdev,b)); |
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index cb136a919f2a..ac4a0cb217ab 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c | |||
| @@ -188,7 +188,7 @@ static int sock_xmit(struct nbd_device *lo, int send, void *buf, int size, | |||
| 188 | if (signal_pending(current)) { | 188 | if (signal_pending(current)) { |
| 189 | siginfo_t info; | 189 | siginfo_t info; |
| 190 | printk(KERN_WARNING "nbd (pid %d: %s) got signal %d\n", | 190 | printk(KERN_WARNING "nbd (pid %d: %s) got signal %d\n", |
| 191 | current->pid, current->comm, | 191 | task_pid_nr(current), current->comm, |
| 192 | dequeue_signal_lock(current, ¤t->blocked, &info)); | 192 | dequeue_signal_lock(current, ¤t->blocked, &info)); |
| 193 | result = -EINTR; | 193 | result = -EINTR; |
| 194 | sock_shutdown(lo, !send); | 194 | sock_shutdown(lo, !send); |
diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index d70745c84250..af0561053167 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c | |||
| @@ -1107,7 +1107,7 @@ int open_for_data(struct cdrom_device_info * cdi) | |||
| 1107 | is the default case! */ | 1107 | is the default case! */ |
| 1108 | cdinfo(CD_OPEN, "bummer. wrong media type.\n"); | 1108 | cdinfo(CD_OPEN, "bummer. wrong media type.\n"); |
| 1109 | cdinfo(CD_WARNING, "pid %d must open device O_NONBLOCK!\n", | 1109 | cdinfo(CD_WARNING, "pid %d must open device O_NONBLOCK!\n", |
| 1110 | (unsigned int)current->pid); | 1110 | (unsigned int)task_pid_nr(current)); |
| 1111 | ret=-EMEDIUMTYPE; | 1111 | ret=-EMEDIUMTYPE; |
| 1112 | goto clean_up_and_return; | 1112 | goto clean_up_and_return; |
| 1113 | } | 1113 | } |
diff --git a/drivers/char/drm/drm_bufs.c b/drivers/char/drm/drm_bufs.c index 856774fbe025..d24a6c2c2c24 100644 --- a/drivers/char/drm/drm_bufs.c +++ b/drivers/char/drm/drm_bufs.c | |||
| @@ -1456,7 +1456,7 @@ int drm_freebufs(struct drm_device *dev, void *data, | |||
| 1456 | buf = dma->buflist[idx]; | 1456 | buf = dma->buflist[idx]; |
| 1457 | if (buf->file_priv != file_priv) { | 1457 | if (buf->file_priv != file_priv) { |
| 1458 | DRM_ERROR("Process %d freeing buffer not owned\n", | 1458 | DRM_ERROR("Process %d freeing buffer not owned\n", |
| 1459 | current->pid); | 1459 | task_pid_nr(current)); |
| 1460 | return -EINVAL; | 1460 | return -EINVAL; |
| 1461 | } | 1461 | } |
| 1462 | drm_free_buffer(dev, buf); | 1462 | drm_free_buffer(dev, buf); |
diff --git a/drivers/char/drm/drm_drv.c b/drivers/char/drm/drm_drv.c index 72668b15e5ce..44a46268b02b 100644 --- a/drivers/char/drm/drm_drv.c +++ b/drivers/char/drm/drm_drv.c | |||
| @@ -463,7 +463,7 @@ int drm_ioctl(struct inode *inode, struct file *filp, | |||
| 463 | ++file_priv->ioctl_count; | 463 | ++file_priv->ioctl_count; |
| 464 | 464 | ||
| 465 | DRM_DEBUG("pid=%d, cmd=0x%02x, nr=0x%02x, dev 0x%lx, auth=%d\n", | 465 | DRM_DEBUG("pid=%d, cmd=0x%02x, nr=0x%02x, dev 0x%lx, auth=%d\n", |
| 466 | current->pid, cmd, nr, | 466 | task_pid_nr(current), cmd, nr, |
| 467 | (long)old_encode_dev(file_priv->head->device), | 467 | (long)old_encode_dev(file_priv->head->device), |
| 468 | file_priv->authenticated); | 468 | file_priv->authenticated); |
| 469 | 469 | ||
diff --git a/drivers/char/drm/drm_fops.c b/drivers/char/drm/drm_fops.c index f383fc37190c..3992f73299cc 100644 --- a/drivers/char/drm/drm_fops.c +++ b/drivers/char/drm/drm_fops.c | |||
| @@ -234,7 +234,7 @@ static int drm_open_helper(struct inode *inode, struct file *filp, | |||
| 234 | if (!drm_cpu_valid()) | 234 | if (!drm_cpu_valid()) |
| 235 | return -EINVAL; | 235 | return -EINVAL; |
| 236 | 236 | ||
| 237 | DRM_DEBUG("pid = %d, minor = %d\n", current->pid, minor); | 237 | DRM_DEBUG("pid = %d, minor = %d\n", task_pid_nr(current), minor); |
| 238 | 238 | ||
| 239 | priv = drm_alloc(sizeof(*priv), DRM_MEM_FILES); | 239 | priv = drm_alloc(sizeof(*priv), DRM_MEM_FILES); |
| 240 | if (!priv) | 240 | if (!priv) |
| @@ -244,7 +244,7 @@ static int drm_open_helper(struct inode *inode, struct file *filp, | |||
| 244 | filp->private_data = priv; | 244 | filp->private_data = priv; |
| 245 | priv->filp = filp; | 245 | priv->filp = filp; |
| 246 | priv->uid = current->euid; | 246 | priv->uid = current->euid; |
| 247 | priv->pid = current->pid; | 247 | priv->pid = task_pid_nr(current); |
| 248 | priv->minor = minor; | 248 | priv->minor = minor; |
| 249 | priv->head = drm_heads[minor]; | 249 | priv->head = drm_heads[minor]; |
| 250 | priv->ioctl_count = 0; | 250 | priv->ioctl_count = 0; |
| @@ -339,7 +339,8 @@ int drm_release(struct inode *inode, struct file *filp) | |||
| 339 | */ | 339 | */ |
| 340 | 340 | ||
| 341 | DRM_DEBUG("pid = %d, device = 0x%lx, open_count = %d\n", | 341 | DRM_DEBUG("pid = %d, device = 0x%lx, open_count = %d\n", |
| 342 | current->pid, (long)old_encode_dev(file_priv->head->device), | 342 | task_pid_nr(current), |
| 343 | (long)old_encode_dev(file_priv->head->device), | ||
| 343 | dev->open_count); | 344 | dev->open_count); |
| 344 | 345 | ||
| 345 | if (dev->driver->reclaim_buffers_locked && dev->lock.hw_lock) { | 346 | if (dev->driver->reclaim_buffers_locked && dev->lock.hw_lock) { |
diff --git a/drivers/char/drm/drm_lock.c b/drivers/char/drm/drm_lock.c index c6b73e744d67..bea2a7d5b2b2 100644 --- a/drivers/char/drm/drm_lock.c +++ b/drivers/char/drm/drm_lock.c | |||
| @@ -58,12 +58,12 @@ int drm_lock(struct drm_device *dev, void *data, struct drm_file *file_priv) | |||
| 58 | 58 | ||
| 59 | if (lock->context == DRM_KERNEL_CONTEXT) { | 59 | if (lock->context == DRM_KERNEL_CONTEXT) { |
| 60 | DRM_ERROR("Process %d using kernel context %d\n", | 60 | DRM_ERROR("Process %d using kernel context %d\n", |
| 61 | current->pid, lock->context); | 61 | task_pid_nr(current), lock->context); |
| 62 | return -EINVAL; | 62 | return -EINVAL; |
| 63 | } | ||
