diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-04-10 07:51:20 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-04-10 07:51:20 -0400 |
commit | b9cd825d066c911cd6076a539986bcf22f1cbcd7 (patch) | |
tree | 09de044718479284e00ee89affb8b24aabeec1b9 | |
parent | 2aebe3f3b20724e09ec76b196e16404d1ea573d9 (diff) | |
parent | 0c4d6af42d8375e003f0e4626f2f661862b5df4b (diff) |
Merge tag 'usb-ci-v4.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb into usb-next
Peter writes:
Two Chipidea updates
- Forbid dumpping registers when the controller in low power mode
- dp pullup needs to be controlled by fsm when working at otg
fsm mode
-rw-r--r-- | drivers/usb/chipidea/debug.c | 4 | ||||
-rw-r--r-- | drivers/usb/chipidea/udc.c | 4 |
2 files changed, 6 insertions, 2 deletions
diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c index 268e4236e84c..dfb05edcdb96 100644 --- a/drivers/usb/chipidea/debug.c +++ b/drivers/usb/chipidea/debug.c | |||
@@ -336,8 +336,8 @@ static int ci_registers_show(struct seq_file *s, void *unused) | |||
336 | struct ci_hdrc *ci = s->private; | 336 | struct ci_hdrc *ci = s->private; |
337 | u32 tmp_reg; | 337 | u32 tmp_reg; |
338 | 338 | ||
339 | if (!ci) | 339 | if (!ci || ci->in_lpm) |
340 | return 0; | 340 | return -EPERM; |
341 | 341 | ||
342 | /* ------ Registers ----- */ | 342 | /* ------ Registers ----- */ |
343 | tmp_reg = hw_read_intr_enable(ci); | 343 | tmp_reg = hw_read_intr_enable(ci); |
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 41914a55055d..764f668d45a9 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c | |||
@@ -1574,6 +1574,10 @@ static int ci_udc_pullup(struct usb_gadget *_gadget, int is_on) | |||
1574 | { | 1574 | { |
1575 | struct ci_hdrc *ci = container_of(_gadget, struct ci_hdrc, gadget); | 1575 | struct ci_hdrc *ci = container_of(_gadget, struct ci_hdrc, gadget); |
1576 | 1576 | ||
1577 | /* Data+ pullup controlled by OTG state machine in OTG fsm mode */ | ||
1578 | if (ci_otg_is_fsm_mode(ci)) | ||
1579 | return 0; | ||
1580 | |||
1577 | pm_runtime_get_sync(&ci->gadget.dev); | 1581 | pm_runtime_get_sync(&ci->gadget.dev); |
1578 | if (is_on) | 1582 | if (is_on) |
1579 | hw_write(ci, OP_USBCMD, USBCMD_RS, USBCMD_RS); | 1583 | hw_write(ci, OP_USBCMD, USBCMD_RS, USBCMD_RS); |