diff options
author | Lad, Prabhakar <prabhakar.csengg@gmail.com> | 2014-05-16 09:33:47 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-05-23 18:30:24 -0400 |
commit | b952662f272ae43c1583fac4dcda71ef36c33528 (patch) | |
tree | c3f2cf88256dac1d537819f9aa5d842cb6ca70f0 | |
parent | e75ea0c15dc5dc37d95d385bfd0102aa3042dca4 (diff) |
[media] media: davinci: vpif_capture: drop unneeded module params
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
-rw-r--r-- | drivers/media/platform/davinci/vpif_capture.c | 54 | ||||
-rw-r--r-- | drivers/media/platform/davinci/vpif_capture.h | 11 |
2 files changed, 1 insertions, 64 deletions
diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index d452eaf59b91..e967cf7c8882 100644 --- a/drivers/media/platform/davinci/vpif_capture.c +++ b/drivers/media/platform/davinci/vpif_capture.c | |||
@@ -38,32 +38,10 @@ MODULE_VERSION(VPIF_CAPTURE_VERSION); | |||
38 | v4l2_dbg(level, debug, &vpif_obj.v4l2_dev, fmt, ## arg) | 38 | v4l2_dbg(level, debug, &vpif_obj.v4l2_dev, fmt, ## arg) |
39 | 39 | ||
40 | static int debug = 1; | 40 | static int debug = 1; |
41 | static u32 ch0_numbuffers = 3; | ||
42 | static u32 ch1_numbuffers = 3; | ||
43 | static u32 ch0_bufsize = 1920 * 1080 * 2; | ||
44 | static u32 ch1_bufsize = 720 * 576 * 2; | ||
45 | 41 | ||
46 | module_param(debug, int, 0644); | 42 | module_param(debug, int, 0644); |
47 | module_param(ch0_numbuffers, uint, S_IRUGO); | ||
48 | module_param(ch1_numbuffers, uint, S_IRUGO); | ||
49 | module_param(ch0_bufsize, uint, S_IRUGO); | ||
50 | module_param(ch1_bufsize, uint, S_IRUGO); | ||
51 | 43 | ||
52 | MODULE_PARM_DESC(debug, "Debug level 0-1"); | 44 | MODULE_PARM_DESC(debug, "Debug level 0-1"); |
53 | MODULE_PARM_DESC(ch2_numbuffers, "Channel0 buffer count (default:3)"); | ||
54 | MODULE_PARM_DESC(ch3_numbuffers, "Channel1 buffer count (default:3)"); | ||
55 | MODULE_PARM_DESC(ch2_bufsize, "Channel0 buffer size (default:1920 x 1080 x 2)"); | ||
56 | MODULE_PARM_DESC(ch3_bufsize, "Channel1 buffer size (default:720 x 576 x 2)"); | ||
57 | |||
58 | static struct vpif_config_params config_params = { | ||
59 | .min_numbuffers = 3, | ||
60 | .numbuffers[0] = 3, | ||
61 | .numbuffers[1] = 3, | ||
62 | .min_bufsize[0] = 720 * 480 * 2, | ||
63 | .min_bufsize[1] = 720 * 480 * 2, | ||
64 | .channel_bufsize[0] = 1920 * 1080 * 2, | ||
65 | .channel_bufsize[1] = 720 * 576 * 2, | ||
66 | }; | ||
67 | 45 | ||
68 | #define VPIF_DRIVER_NAME "vpif_capture" | 46 | #define VPIF_DRIVER_NAME "vpif_capture" |
69 | 47 | ||
@@ -609,9 +587,6 @@ static void vpif_config_format(struct channel_obj *ch) | |||
609 | vpif_dbg(2, debug, "vpif_config_format\n"); | 587 | vpif_dbg(2, debug, "vpif_config_format\n"); |
610 | 588 | ||
611 | common->fmt.fmt.pix.field = V4L2_FIELD_ANY; | 589 | common->fmt.fmt.pix.field = V4L2_FIELD_ANY; |
612 | common->fmt.fmt.pix.sizeimage | ||
613 | = config_params.channel_bufsize[ch->channel_id]; | ||
614 | |||
615 | if (ch->vpifparams.iface.if_type == VPIF_IF_RAW_BAYER) | 590 | if (ch->vpifparams.iface.if_type == VPIF_IF_RAW_BAYER) |
616 | common->fmt.fmt.pix.pixelformat = V4L2_PIX_FMT_SBGGR8; | 591 | common->fmt.fmt.pix.pixelformat = V4L2_PIX_FMT_SBGGR8; |
617 | else | 592 | else |
@@ -1358,36 +1333,9 @@ static struct v4l2_file_operations vpif_fops = { | |||
1358 | */ | 1333 | */ |
1359 | static int initialize_vpif(void) | 1334 | static int initialize_vpif(void) |
1360 | { | 1335 | { |
1361 | int err = 0, i, j; | 1336 | int err, i, j; |
1362 | int free_channel_objects_index; | 1337 | int free_channel_objects_index; |
1363 | 1338 | ||
1364 | /* Default number of buffers should be 3 */ | ||
1365 | if ((ch0_numbuffers > 0) && | ||
1366 | (ch0_numbuffers < config_params.min_numbuffers)) | ||
1367 | ch0_numbuffers = config_params.min_numbuffers; | ||
1368 | if ((ch1_numbuffers > 0) && | ||
1369 | (ch1_numbuffers < config_params.min_numbuffers)) | ||
1370 | ch1_numbuffers = config_params.min_numbuffers; | ||
1371 | |||
1372 | /* Set buffer size to min buffers size if it is invalid */ | ||
1373 | if (ch0_bufsize < config_params.min_bufsize[VPIF_CHANNEL0_VIDEO]) | ||
1374 | ch0_bufsize = | ||
1375 | config_params.min_bufsize[VPIF_CHANNEL0_VIDEO]; | ||
1376 | if (ch1_bufsize < config_params.min_bufsize[VPIF_CHANNEL1_VIDEO]) | ||
1377 | ch1_bufsize = | ||
1378 | config_params.min_bufsize[VPIF_CHANNEL1_VIDEO]; | ||
1379 | |||
1380 | config_params.numbuffers[VPIF_CHANNEL0_VIDEO] = ch0_numbuffers; | ||
1381 | config_params.numbuffers[VPIF_CHANNEL1_VIDEO] = ch1_numbuffers; | ||
1382 | if (ch0_numbuffers) { | ||
1383 | config_params.channel_bufsize[VPIF_CHANNEL0_VIDEO] | ||
1384 | = ch0_bufsize; | ||
1385 | } | ||
1386 | if (ch1_numbuffers) { | ||
1387 | config_params.channel_bufsize[VPIF_CHANNEL1_VIDEO] | ||
1388 | = ch1_bufsize; | ||
1389 | } | ||
1390 | |||
1391 | /* Allocate memory for six channel objects */ | 1339 | /* Allocate memory for six channel objects */ |
1392 | for (i = 0; i < VPIF_CAPTURE_MAX_DEVICES; i++) { | 1340 | for (i = 0; i < VPIF_CAPTURE_MAX_DEVICES; i++) { |
1393 | vpif_obj.dev[i] = | 1341 | vpif_obj.dev[i] = |
diff --git a/drivers/media/platform/davinci/vpif_capture.h b/drivers/media/platform/davinci/vpif_capture.h index 4960504a5108..537076a6bf7b 100644 --- a/drivers/media/platform/davinci/vpif_capture.h +++ b/drivers/media/platform/davinci/vpif_capture.h | |||
@@ -125,16 +125,5 @@ struct vpif_device { | |||
125 | struct vpif_capture_config *config; | 125 | struct vpif_capture_config *config; |
126 | }; | 126 | }; |
127 | 127 | ||
128 | struct vpif_config_params { | ||
129 | u8 min_numbuffers; | ||
130 | u8 numbuffers[VPIF_CAPTURE_NUM_CHANNELS]; | ||
131 | s8 device_type; | ||
132 | u32 min_bufsize[VPIF_CAPTURE_NUM_CHANNELS]; | ||
133 | u32 channel_bufsize[VPIF_CAPTURE_NUM_CHANNELS]; | ||
134 | u8 default_device[VPIF_CAPTURE_NUM_CHANNELS]; | ||
135 | u32 video_limit[VPIF_CAPTURE_NUM_CHANNELS]; | ||
136 | u8 max_device_type; | ||
137 | }; | ||
138 | |||
139 | #endif /* End of __KERNEL__ */ | 128 | #endif /* End of __KERNEL__ */ |
140 | #endif /* VPIF_CAPTURE_H */ | 129 | #endif /* VPIF_CAPTURE_H */ |