diff options
author | Rene Herman <rene.herman@gmail.com> | 2007-03-28 09:23:53 -0400 |
---|---|---|
committer | Jaroslav Kysela <perex@suse.cz> | 2007-05-11 10:55:54 -0400 |
commit | b942cf815b5775288550f99f3790e29815bb70cb (patch) | |
tree | 1b7ec7d36b3504139d7b9dd32eb25c56e4d877b3 | |
parent | d3091fad4a4902185c3ce0b77a847ecafcb3f006 (diff) |
[ALSA] es1968 - Fix stuttering capture
Looks like the buffer size for the stereo capture has to be a
power of two. Now added a constraint to buffer bytes.
Also removed unnecessary #if 0 lines.
Signed-off-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
-rw-r--r-- | sound/pci/es1968.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c index dc84c189b05f..2faf009076bb 100644 --- a/sound/pci/es1968.c +++ b/sound/pci/es1968.c | |||
@@ -1554,10 +1554,7 @@ static int snd_es1968_playback_open(struct snd_pcm_substream *substream) | |||
1554 | runtime->hw = snd_es1968_playback; | 1554 | runtime->hw = snd_es1968_playback; |
1555 | runtime->hw.buffer_bytes_max = runtime->hw.period_bytes_max = | 1555 | runtime->hw.buffer_bytes_max = runtime->hw.period_bytes_max = |
1556 | calc_available_memory_size(chip); | 1556 | calc_available_memory_size(chip); |
1557 | #if 0 | 1557 | |
1558 | snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES, | ||
1559 | 1024); | ||
1560 | #endif | ||
1561 | spin_lock_irq(&chip->substream_lock); | 1558 | spin_lock_irq(&chip->substream_lock); |
1562 | list_add(&es->list, &chip->substream_list); | 1559 | list_add(&es->list, &chip->substream_list); |
1563 | spin_unlock_irq(&chip->substream_lock); | 1560 | spin_unlock_irq(&chip->substream_lock); |
@@ -1613,10 +1610,8 @@ static int snd_es1968_capture_open(struct snd_pcm_substream *substream) | |||
1613 | runtime->hw = snd_es1968_capture; | 1610 | runtime->hw = snd_es1968_capture; |
1614 | runtime->hw.buffer_bytes_max = runtime->hw.period_bytes_max = | 1611 | runtime->hw.buffer_bytes_max = runtime->hw.period_bytes_max = |
1615 | calc_available_memory_size(chip) - 1024; /* keep MIXBUF size */ | 1612 | calc_available_memory_size(chip) - 1024; /* keep MIXBUF size */ |
1616 | #if 0 | 1613 | snd_pcm_hw_constraint_pow2(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES); |
1617 | snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES, | 1614 | |
1618 | 1024); | ||
1619 | #endif | ||
1620 | spin_lock_irq(&chip->substream_lock); | 1615 | spin_lock_irq(&chip->substream_lock); |
1621 | list_add(&es->list, &chip->substream_list); | 1616 | list_add(&es->list, &chip->substream_list); |
1622 | spin_unlock_irq(&chip->substream_lock); | 1617 | spin_unlock_irq(&chip->substream_lock); |