diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-10-26 06:02:55 -0400 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2011-10-26 11:12:01 -0400 |
| commit | b8631e6ebb3aa033e21d68dd75029aceb96b79cd (patch) | |
| tree | 08dc191dab34721847e1212ac32c00bcffc1d6bd | |
| parent | ae55795ef2d9ba71d46e4111b87a4d0cde93abea (diff) | |
perf ui: Rename ui__warning_paranoid to ui__error_paranoid
As it will exit the tool after the user is notified.
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-vy06m8xzlvkhr8tk7nylhbng@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
| -rw-r--r-- | tools/perf/builtin-record.c | 2 | ||||
| -rw-r--r-- | tools/perf/builtin-top.c | 2 | ||||
| -rw-r--r-- | tools/perf/util/debug.c | 4 | ||||
| -rw-r--r-- | tools/perf/util/debug.h | 6 |
4 files changed, 8 insertions, 6 deletions
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 40088a5848d6..6ab58cc99d53 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c | |||
| @@ -298,7 +298,7 @@ try_again: | |||
| 298 | int err = errno; | 298 | int err = errno; |
| 299 | 299 | ||
| 300 | if (err == EPERM || err == EACCES) { | 300 | if (err == EPERM || err == EACCES) { |
| 301 | ui__warning_paranoid(); | 301 | ui__error_paranoid(); |
| 302 | exit(EXIT_FAILURE); | 302 | exit(EXIT_FAILURE); |
| 303 | } else if (err == ENODEV && cpu_list) { | 303 | } else if (err == ENODEV && cpu_list) { |
| 304 | die("No such device - did you specify" | 304 | die("No such device - did you specify" |
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index d2fc7542e826..31aa82c39e2a 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c | |||
| @@ -871,7 +871,7 @@ try_again: | |||
| 871 | int err = errno; | 871 | int err = errno; |
| 872 | 872 | ||
| 873 | if (err == EPERM || err == EACCES) { | 873 | if (err == EPERM || err == EACCES) { |
| 874 | ui__warning_paranoid(); | 874 | ui__error_paranoid(); |
| 875 | goto out_err; | 875 | goto out_err; |
| 876 | } | 876 | } |
| 877 | /* | 877 | /* |
diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c index 155749d74350..55634038af6b 100644 --- a/tools/perf/util/debug.c +++ b/tools/perf/util/debug.c | |||
| @@ -57,9 +57,9 @@ void ui__warning(const char *format, ...) | |||
| 57 | } | 57 | } |
| 58 | #endif | 58 | #endif |
| 59 | 59 | ||
| 60 | void ui__warning_paranoid(void) | 60 | void ui__error_paranoid(void) |
| 61 | { | 61 | { |
| 62 | ui__warning("Permission error - are you root?\n" | 62 | ui__error("Permission error - are you root?\n" |
| 63 | "Consider tweaking /proc/sys/kernel/perf_event_paranoid:\n" | 63 | "Consider tweaking /proc/sys/kernel/perf_event_paranoid:\n" |
| 64 | " -1 - Not paranoid at all\n" | 64 | " -1 - Not paranoid at all\n" |
| 65 | " 0 - Disallow raw tracepoint access for unpriv\n" | 65 | " 0 - Disallow raw tracepoint access for unpriv\n" |
diff --git a/tools/perf/util/debug.h b/tools/perf/util/debug.h index 9c59b9551ada..16cc75227d2b 100644 --- a/tools/perf/util/debug.h +++ b/tools/perf/util/debug.h | |||
| @@ -21,14 +21,16 @@ static inline int ui_helpline__show_help(const char *format __used, va_list ap _ | |||
| 21 | 21 | ||
| 22 | static inline void ui_progress__update(u64 curr __used, u64 total __used, | 22 | static inline void ui_progress__update(u64 curr __used, u64 total __used, |
| 23 | const char *title __used) {} | 23 | const char *title __used) {} |
| 24 | |||
| 25 | #define ui__error(format, arg...) ui__warning(format, ##arg) | ||
| 24 | #else | 26 | #else |
| 25 | extern char ui_helpline__last_msg[]; | 27 | extern char ui_helpline__last_msg[]; |
| 26 | int ui_helpline__show_help(const char *format, va_list ap); | 28 | int ui_helpline__show_help(const char *format, va_list ap); |
| 27 | #include "ui/progress.h" | 29 | #include "ui/progress.h" |
| 30 | void ui__error(const char *format, ...) __attribute__((format(printf, 1, 2))); | ||
| 28 | #endif | 31 | #endif |
| 29 | 32 | ||
| 30 | void ui__warning(const char *format, ...) __attribute__((format(printf, 1, 2))); | 33 | void ui__warning(const char *format, ...) __attribute__((format(printf, 1, 2))); |
| 31 | void ui__warning_paranoid(void); | 34 | void ui__error_paranoid(void); |
| 32 | void ui__error(const char *format, ...) __attribute__((format(printf, 1, 2))); | ||
| 33 | 35 | ||
| 34 | #endif /* __PERF_DEBUG_H */ | 36 | #endif /* __PERF_DEBUG_H */ |
