aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuennadi Liakhovetski <g.liakhovetski@gmx.de>2012-05-21 07:25:13 -0400
committerGrant Likely <grant.likely@secretlab.ca>2012-11-14 10:38:15 -0500
commitb82b576bc7ffb9785ad3248825ab20496b018e0c (patch)
treedc9ec25933ce901ed28ff29e309bc2aa5674b4f4
parent77b67063bb6bce6d475e910d3b886a606d0d91f7 (diff)
spi/bitbang: avoid needless loop flow manipulations
This patch makes a loop look cleaner by replacing a "break" and a "continue" in its body by a single "if". Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
-rw-r--r--drivers/spi/spi-bitbang.c19
1 files changed, 8 insertions, 11 deletions
diff --git a/drivers/spi/spi-bitbang.c b/drivers/spi/spi-bitbang.c
index aef59b1a15f7..f5ae6e960c7e 100644
--- a/drivers/spi/spi-bitbang.c
+++ b/drivers/spi/spi-bitbang.c
@@ -346,17 +346,14 @@ static void bitbang_work(struct work_struct *work)
346 if (t->delay_usecs) 346 if (t->delay_usecs)
347 udelay(t->delay_usecs); 347 udelay(t->delay_usecs);
348 348
349 if (!cs_change) 349 if (cs_change && !list_is_last(&t->transfer_list, &m->transfers)) {
350 continue; 350 /* sometimes a short mid-message deselect of the chip
351 if (t->transfer_list.next == &m->transfers) 351 * may be needed to terminate a mode or command
352 break; 352 */
353 353 ndelay(nsecs);
354 /* sometimes a short mid-message deselect of the chip 354 bitbang->chipselect(spi, BITBANG_CS_INACTIVE);
355 * may be needed to terminate a mode or command 355 ndelay(nsecs);
356 */ 356 }
357 ndelay(nsecs);
358 bitbang->chipselect(spi, BITBANG_CS_INACTIVE);
359 ndelay(nsecs);
360 } 357 }
361 358
362 m->status = status; 359 m->status = status;