aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabio Baltieri <fabio.baltieri@linaro.org>2013-05-24 06:39:17 -0400
committerMark Brown <broonie@opensource.wolfsonmicro.com>2013-05-25 15:58:33 -0400
commitb7230d7e4c1f6a87ddb96dbc106435e0dfee0f37 (patch)
treeb68c29cefc52545e82ac8611a6310c394a3cb4cc
parent7f92581b21707bfe09e14410283692b658b9ef10 (diff)
ASoC: ux500: Drop dangling struct i2s_controller
Drop struct i2s_controller from the ux500 ASoC driver as right now it is instantiated but not used anywhere. Also drop a mismatched device_unregister in the process. Signed-off-by: Fabio Baltieri <fabio.baltieri@linaro.org> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
-rw-r--r--sound/soc/ux500/ux500_msp_i2s.c19
-rw-r--r--sound/soc/ux500/ux500_msp_i2s.h12
2 files changed, 0 insertions, 31 deletions
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index b029b2d673d7..cba0e86833e9 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -649,7 +649,6 @@ int ux500_msp_i2s_init_msp(struct platform_device *pdev,
649 struct msp_i2s_platform_data *platform_data) 649 struct msp_i2s_platform_data *platform_data)
650{ 650{
651 struct resource *res = NULL; 651 struct resource *res = NULL;
652 struct i2s_controller *i2s_cont;
653 struct device_node *np = pdev->dev.of_node; 652 struct device_node *np = pdev->dev.of_node;
654 struct ux500_msp *msp; 653 struct ux500_msp *msp;
655 654
@@ -694,22 +693,6 @@ int ux500_msp_i2s_init_msp(struct platform_device *pdev,
694 msp->msp_state = MSP_STATE_IDLE; 693 msp->msp_state = MSP_STATE_IDLE;
695 msp->loopback_enable = 0; 694 msp->loopback_enable = 0;
696 695
697 /* I2S-controller is allocated and added in I2S controller class. */
698 i2s_cont = devm_kzalloc(&pdev->dev, sizeof(*i2s_cont), GFP_KERNEL);
699 if (!i2s_cont) {
700 dev_err(&pdev->dev,
701 "%s: ERROR: Failed to allocate I2S-controller!\n",
702 __func__);
703 return -ENOMEM;
704 }
705 i2s_cont->dev.parent = &pdev->dev;
706 i2s_cont->data = (void *)msp;
707 i2s_cont->id = (s16)msp->id;
708 snprintf(i2s_cont->name, sizeof(i2s_cont->name), "ux500-msp-i2s.%04x",
709 msp->id);
710 dev_dbg(&pdev->dev, "I2S device-name: '%s'\n", i2s_cont->name);
711 msp->i2s_cont = i2s_cont;
712
713 return 0; 696 return 0;
714} 697}
715 698
@@ -717,8 +700,6 @@ void ux500_msp_i2s_cleanup_msp(struct platform_device *pdev,
717 struct ux500_msp *msp) 700 struct ux500_msp *msp)
718{ 701{
719 dev_dbg(msp->dev, "%s: Enter (id = %d).\n", __func__, msp->id); 702 dev_dbg(msp->dev, "%s: Enter (id = %d).\n", __func__, msp->id);
720
721 device_unregister(&msp->i2s_cont->dev);
722} 703}
723 704
724MODULE_LICENSE("GPL v2"); 705MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/ux500/ux500_msp_i2s.h b/sound/soc/ux500/ux500_msp_i2s.h
index 8ce014eb37e8..ccfcc32b1c2b 100644
--- a/sound/soc/ux500/ux500_msp_i2s.h
+++ b/sound/soc/ux500/ux500_msp_i2s.h
@@ -469,17 +469,6 @@ struct i2s_message {
469 size_t period_len; 469 size_t period_len;
470}; 470};
471 471
472struct i2s_controller {
473 struct module *owner;
474 unsigned int id;
475 unsigned int class;
476 const struct i2s_algorithm *algo; /* the algorithm to access the bus */
477 void *data;
478 struct mutex bus_lock;
479 struct device dev; /* the controller device */
480 char name[48];
481};
482
483struct ux500_msp_config { 472struct ux500_msp_config {
484 unsigned int f_inputclk; 473 unsigned int f_inputclk;
485 unsigned int rx_clk_sel; 474 unsigned int rx_clk_sel;
@@ -515,7 +504,6 @@ struct ux500_msp {
515 enum enum_i2s_controller id; 504 enum enum_i2s_controller id;
516 void __iomem *registers; 505 void __iomem *registers;
517 struct device *dev; 506 struct device *dev;
518 struct i2s_controller *i2s_cont;
519 struct stedma40_chan_cfg *dma_cfg_rx; 507 struct stedma40_chan_cfg *dma_cfg_rx;
520 struct stedma40_chan_cfg *dma_cfg_tx; 508 struct stedma40_chan_cfg *dma_cfg_tx;
521 struct dma_chan *tx_pipeid; 509 struct dma_chan *tx_pipeid;