aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2013-04-23 21:42:42 -0400
committerNeilBrown <neilb@suse.de>2013-04-23 21:42:42 -0400
commitb6d428c669159b8cfa5a83bb11abaaf4bdc170b0 (patch)
tree1a26706aa57cc2bf4493951d564add73d2631335
parent7ceb17e87bde79d285a8b988cfed9eaeebe60b86 (diff)
md: don't update metadata when stopping a read-only array.
read-only arrays should stay that way as much as possible. Updating the metadata - which could be triggered by a re-add while assembling the array metadata - should be avoided. Signed-off-by: NeilBrown <neilb@suse.de>
-rw-r--r--drivers/md/md.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 491afda21fd9..30132280d07b 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5293,7 +5293,8 @@ static void __md_stop_writes(struct mddev *mddev)
5293 bitmap_flush(mddev); 5293 bitmap_flush(mddev);
5294 md_super_wait(mddev); 5294 md_super_wait(mddev);
5295 5295
5296 if (!mddev->in_sync || mddev->flags) { 5296 if (mddev->ro == 0 &&
5297 (!mddev->in_sync || mddev->flags)) {
5297 /* mark array as shutdown cleanly */ 5298 /* mark array as shutdown cleanly */
5298 mddev->in_sync = 1; 5299 mddev->in_sync = 1;
5299 md_update_sb(mddev, 1); 5300 md_update_sb(mddev, 1);