diff options
author | Luis R. Rodriguez <lrodriguez@atheros.com> | 2009-10-19 02:33:36 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-10-30 16:50:37 -0400 |
commit | b67b4397cfbfca8f5c4fff2a36e00d81ef6a28c2 (patch) | |
tree | 69db2dc7f95be152557178511278a702291f1c10 | |
parent | 131d1d036ac7e7c8ad063581b57ba3bb5f7c881d (diff) |
ath9k_hw: bail out early on ath9k_hw_init_rf()
We a huge branch for old hardware and nothing for newer
hardware. Instead of doing this just bail out early for
newer hardware.
This patch has no functional changes.
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/ath/ath9k/phy.c | 109 |
1 files changed, 55 insertions, 54 deletions
diff --git a/drivers/net/wireless/ath/ath9k/phy.c b/drivers/net/wireless/ath/ath9k/phy.c index 9e515033b878..bd4fb076cb08 100644 --- a/drivers/net/wireless/ath/ath9k/phy.c +++ b/drivers/net/wireless/ath/ath9k/phy.c | |||
@@ -419,62 +419,63 @@ bool ath9k_hw_init_rf(struct ath_hw *ah, int *status) | |||
419 | { | 419 | { |
420 | struct ath_common *common = ath9k_hw_common(ah); | 420 | struct ath_common *common = ath9k_hw_common(ah); |
421 | 421 | ||
422 | if (!AR_SREV_9280_10_OR_LATER(ah)) { | 422 | if (AR_SREV_9280_10_OR_LATER(ah)) |
423 | ah->analogBank0Data = | 423 | return true; |
424 | kzalloc((sizeof(u32) * | ||
425 | ah->iniBank0.ia_rows), GFP_KERNEL); | ||
426 | ah->analogBank1Data = | ||
427 | kzalloc((sizeof(u32) * | ||
428 | ah->iniBank1.ia_rows), GFP_KERNEL); | ||
429 | ah->analogBank2Data = | ||
430 | kzalloc((sizeof(u32) * | ||
431 | ah->iniBank2.ia_rows), GFP_KERNEL); | ||
432 | ah->analogBank3Data = | ||
433 | kzalloc((sizeof(u32) * | ||
434 | ah->iniBank3.ia_rows), GFP_KERNEL); | ||
435 | ah->analogBank6Data = | ||
436 | kzalloc((sizeof(u32) * | ||
437 | ah->iniBank6.ia_rows), GFP_KERNEL); | ||
438 | ah->analogBank6TPCData = | ||
439 | kzalloc((sizeof(u32) * | ||
440 | ah->iniBank6TPC.ia_rows), GFP_KERNEL); | ||
441 | ah->analogBank7Data = | ||
442 | kzalloc((sizeof(u32) * | ||
443 | ah->iniBank7.ia_rows), GFP_KERNEL); | ||
444 | |||
445 | if (ah->analogBank0Data == NULL | ||
446 | || ah->analogBank1Data == NULL | ||
447 | || ah->analogBank2Data == NULL | ||
448 | || ah->analogBank3Data == NULL | ||
449 | || ah->analogBank6Data == NULL | ||
450 | || ah->analogBank6TPCData == NULL | ||
451 | || ah->analogBank7Data == NULL) { | ||
452 | ath_print(common, ATH_DBG_FATAL, | ||
453 | "Cannot allocate RF banks\n"); | ||
454 | *status = -ENOMEM; | ||
455 | return false; | ||
456 | } | ||
457 | 424 | ||
458 | ah->addac5416_21 = | 425 | ah->analogBank0Data = |
459 | kzalloc((sizeof(u32) * | 426 | kzalloc((sizeof(u32) * |
460 | ah->iniAddac.ia_rows * | 427 | ah->iniBank0.ia_rows), GFP_KERNEL); |
461 | ah->iniAddac.ia_columns), GFP_KERNEL); | 428 | ah->analogBank1Data = |
462 | if (ah->addac5416_21 == NULL) { | 429 | kzalloc((sizeof(u32) * |
463 | ath_print(common, ATH_DBG_FATAL, | 430 | ah->iniBank1.ia_rows), GFP_KERNEL); |
464 | "Cannot allocate addac5416_21\n"); | 431 | ah->analogBank2Data = |
465 | *status = -ENOMEM; | 432 | kzalloc((sizeof(u32) * |
466 | return false; | 433 | ah->iniBank2.ia_rows), GFP_KERNEL); |
467 | } | 434 | ah->analogBank3Data = |
435 | kzalloc((sizeof(u32) * | ||
436 | ah->iniBank3.ia_rows), GFP_KERNEL); | ||
437 | ah->analogBank6Data = | ||
438 | kzalloc((sizeof(u32) * | ||
439 | ah->iniBank6.ia_rows), GFP_KERNEL); | ||
440 | ah->analogBank6TPCData = | ||
441 | kzalloc((sizeof(u32) * | ||
442 | ah->iniBank6TPC.ia_rows), GFP_KERNEL); | ||
443 | ah->analogBank7Data = | ||
444 | kzalloc((sizeof(u32) * | ||
445 | ah->iniBank7.ia_rows), GFP_KERNEL); | ||
446 | |||
447 | if (ah->analogBank0Data == NULL | ||
448 | || ah->analogBank1Data == NULL | ||
449 | || ah->analogBank2Data == NULL | ||
450 | || ah->analogBank3Data == NULL | ||
451 | || ah->analogBank6Data == NULL | ||
452 | || ah->analogBank6TPCData == NULL | ||
453 | || ah->analogBank7Data == NULL) { | ||
454 | ath_print(common, ATH_DBG_FATAL, | ||
455 | "Cannot allocate RF banks\n"); | ||
456 | *status = -ENOMEM; | ||
457 | return false; | ||
458 | } | ||
468 | 459 | ||
469 | ah->bank6Temp = | 460 | ah->addac5416_21 = |
470 | kzalloc((sizeof(u32) * | 461 | kzalloc((sizeof(u32) * |
471 | ah->iniBank6.ia_rows), GFP_KERNEL); | 462 | ah->iniAddac.ia_rows * |
472 | if (ah->bank6Temp == NULL) { | 463 | ah->iniAddac.ia_columns), GFP_KERNEL); |
473 | ath_print(common, ATH_DBG_FATAL, | 464 | if (ah->addac5416_21 == NULL) { |
474 | "Cannot allocate bank6Temp\n"); | 465 | ath_print(common, ATH_DBG_FATAL, |
475 | *status = -ENOMEM; | 466 | "Cannot allocate addac5416_21\n"); |
476 | return false; | 467 | *status = -ENOMEM; |
477 | } | 468 | return false; |
469 | } | ||
470 | |||
471 | ah->bank6Temp = | ||
472 | kzalloc((sizeof(u32) * | ||
473 | ah->iniBank6.ia_rows), GFP_KERNEL); | ||
474 | if (ah->bank6Temp == NULL) { | ||
475 | ath_print(common, ATH_DBG_FATAL, | ||
476 | "Cannot allocate bank6Temp\n"); | ||
477 | *status = -ENOMEM; | ||
478 | return false; | ||
478 | } | 479 | } |
479 | 480 | ||
480 | return true; | 481 | return true; |