diff options
| author | Ingo Molnar <mingo@kernel.org> | 2013-11-11 13:53:42 -0500 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2013-11-11 13:53:42 -0500 |
| commit | b5dfcb09debc38582c3cb72a3c1a88b919b07f2d (patch) | |
| tree | e74d7000baeab5c3800701c275971dd925cbfa08 | |
| parent | e379ea82dd53a5cc8e3ac0b7899a8012006c712c (diff) | |
Revert "x86/UV: Add uvtrace support"
This reverts commit 8eba18428ac926f436064ac281e76d36d51bd631.
uv_trace() is not used by anything, nor is uv_trace_nmi_func, nor
uv_trace_func.
That's not how we do instrumentation code in the kernel: we add
tracepoints, printk()s, etc. so that everyone not just those with
magic kernel modules can debug a system.
So remove this unused (and misguied) piece of code.
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Mike Travis <travis@sgi.com>
Cc: Dimitri Sivanich <sivanich@sgi.com>
Cc: Hedi Berriche <hedi@sgi.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Jason Wessel <jason.wessel@windriver.com>
Link: http://lkml.kernel.org/n/tip-tumfBffmr4jmnt8Gyxanoblg@git.kernel.org
| -rw-r--r-- | arch/x86/include/asm/uv/uv.h | 8 | ||||
| -rw-r--r-- | arch/x86/platform/uv/uv_nmi.c | 13 |
2 files changed, 1 insertions, 20 deletions
diff --git a/arch/x86/include/asm/uv/uv.h b/arch/x86/include/asm/uv/uv.h index 8b1283daa332..6b964a0b86d1 100644 --- a/arch/x86/include/asm/uv/uv.h +++ b/arch/x86/include/asm/uv/uv.h | |||
| @@ -14,13 +14,6 @@ extern void uv_cpu_init(void); | |||
| 14 | extern void uv_nmi_init(void); | 14 | extern void uv_nmi_init(void); |
| 15 | extern void uv_register_nmi_notifier(void); | 15 | extern void uv_register_nmi_notifier(void); |
| 16 | extern void uv_system_init(void); | 16 | extern void uv_system_init(void); |
| 17 | extern void (*uv_trace_nmi_func)(unsigned int reason, struct pt_regs *regs); | ||
| 18 | extern void (*uv_trace_func)(const char *f, const int l, const char *fmt, ...); | ||
| 19 | #define uv_trace(fmt, ...) \ | ||
| 20 | do { \ | ||
| 21 | if (unlikely(uv_trace_func)) \ | ||
| 22 | (uv_trace_func)(__func__, __LINE__, fmt, ##__VA_ARGS__);\ | ||
| 23 | } while (0) | ||
| 24 | extern const struct cpumask *uv_flush_tlb_others(const struct cpumask *cpumask, | 17 | extern const struct cpumask *uv_flush_tlb_others(const struct cpumask *cpumask, |
| 25 | struct mm_struct *mm, | 18 | struct mm_struct *mm, |
| 26 | unsigned long start, | 19 | unsigned long start, |
| @@ -33,7 +26,6 @@ static inline enum uv_system_type get_uv_system_type(void) { return UV_NONE; } | |||
| 33 | static inline int is_uv_system(void) { return 0; } | 26 | static inline int is_uv_system(void) { return 0; } |
| 34 | static inline void uv_cpu_init(void) { } | 27 | static inline void uv_cpu_init(void) { } |
| 35 | static inline void uv_system_init(void) { } | 28 | static inline void uv_system_init(void) { } |
| 36 | static inline void uv_trace(void *fmt, ...) { } | ||
| 37 | static inline void uv_register_nmi_notifier(void) { } | 29 | static inline void uv_register_nmi_notifier(void) { } |
| 38 | static inline const struct cpumask * | 30 | static inline const struct cpumask * |
| 39 | uv_flush_tlb_others(const struct cpumask *cpumask, struct mm_struct *mm, | 31 | uv_flush_tlb_others(const struct cpumask *cpumask, struct mm_struct *mm, |
diff --git a/arch/x86/platform/uv/uv_nmi.c b/arch/x86/platform/uv/uv_nmi.c index 9b8ac60ad8db..2e863ad4a772 100644 --- a/arch/x86/platform/uv/uv_nmi.c +++ b/arch/x86/platform/uv/uv_nmi.c | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | /* | 1 | /* |
| 2 | * SGI NMI/TRACE support routines | 2 | * SGI NMI support routines |
| 3 | * | 3 | * |
| 4 | * This program is free software; you can redistribute it and/or modify | 4 | * This program is free software; you can redistribute it and/or modify |
| 5 | * it under the terms of the GNU General Public License as published by | 5 | * it under the terms of the GNU General Public License as published by |
| @@ -39,13 +39,6 @@ | |||
| 39 | #include <asm/uv/uv_hub.h> | 39 | #include <asm/uv/uv_hub.h> |
| 40 | #include <asm/uv/uv_mmrs.h> | 40 | #include <asm/uv/uv_mmrs.h> |
| 41 | 41 | ||
| 42 | void (*uv_trace_func)(const char *f, const int l, const char *fmt, ...); | ||
| 43 | EXPORT_SYMBOL(uv_trace_func); | ||
| 44 | |||
| 45 | void (*uv_trace_nmi_func)(unsigned int reason, struct pt_regs *regs); | ||
| 46 | EXPORT_SYMBOL(uv_trace_nmi_func); | ||
| 47 | |||
| 48 | |||
| 49 | /* | 42 | /* |
| 50 | * UV handler for NMI | 43 | * UV handler for NMI |
| 51 | * | 44 | * |
| @@ -599,10 +592,6 @@ int uv_handle_nmi(unsigned int reason, struct pt_regs *regs) | |||
| 599 | return NMI_DONE; | 592 | return NMI_DONE; |
| 600 | } | 593 | } |
| 601 | 594 | ||
| 602 | /* Call possible NMI trace function */ | ||
| 603 | if (unlikely(uv_trace_nmi_func)) | ||
| 604 | (uv_trace_nmi_func)(reason, regs); | ||
| 605 | |||
| 606 | /* Indicate we are the first CPU into the NMI handler */ | 595 | /* Indicate we are the first CPU into the NMI handler */ |
| 607 | master = (atomic_read(&uv_nmi_cpu) == cpu); | 596 | master = (atomic_read(&uv_nmi_cpu) == cpu); |
| 608 | 597 | ||
