aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>2014-07-02 13:13:24 -0400
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2014-07-07 18:13:44 -0400
commitb58cc46c5f6b57f1c814e374dbc47176e6b4938e (patch)
treeda592215d7ebbd15cdb0773770cd45ed91c538d2
parentfbce7497ee5af800a1c350c73f3c3f103cb27a15 (diff)
rcu: Don't offload callbacks unless specifically requested
Enabling NO_HZ_FULL currently has the side effect of enabling callback offloading on all CPUs. This results in lots of additional rcuo kthreads, and can also increase context switching and wakeups, even in cases where callback offloading is neither needed nor particularly desirable. This commit therefore enables callback offloading on a given CPU only if specifically requested at build time or boot time, or if that CPU has been specifically designated (again, either at build time or boot time) as a nohz_full CPU. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
-rw-r--r--init/Kconfig4
-rw-r--r--kernel/rcu/tree_plugin.h3
2 files changed, 5 insertions, 2 deletions
diff --git a/init/Kconfig b/init/Kconfig
index 9d76b99af1b9..9332d33346ac 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -737,7 +737,7 @@ choice
737 737
738config RCU_NOCB_CPU_NONE 738config RCU_NOCB_CPU_NONE
739 bool "No build_forced no-CBs CPUs" 739 bool "No build_forced no-CBs CPUs"
740 depends on RCU_NOCB_CPU && !NO_HZ_FULL 740 depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL
741 help 741 help
742 This option does not force any of the CPUs to be no-CBs CPUs. 742 This option does not force any of the CPUs to be no-CBs CPUs.
743 Only CPUs designated by the rcu_nocbs= boot parameter will be 743 Only CPUs designated by the rcu_nocbs= boot parameter will be
@@ -751,7 +751,7 @@ config RCU_NOCB_CPU_NONE
751 751
752config RCU_NOCB_CPU_ZERO 752config RCU_NOCB_CPU_ZERO
753 bool "CPU 0 is a build_forced no-CBs CPU" 753 bool "CPU 0 is a build_forced no-CBs CPU"
754 depends on RCU_NOCB_CPU && !NO_HZ_FULL 754 depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL
755 help 755 help
756 This option forces CPU 0 to be a no-CBs CPU, so that its RCU 756 This option forces CPU 0 to be a no-CBs CPU, so that its RCU
757 callbacks are invoked by a per-CPU kthread whose name begins 757 callbacks are invoked by a per-CPU kthread whose name begins
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index b27b86c7bbfa..17eed0856b03 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -2473,6 +2473,9 @@ static void __init rcu_spawn_nocb_kthreads(struct rcu_state *rsp)
2473 2473
2474 if (rcu_nocb_mask == NULL) 2474 if (rcu_nocb_mask == NULL)
2475 return; 2475 return;
2476#ifdef CONFIG_NO_HZ_FULL
2477 cpumask_or(rcu_nocb_mask, rcu_nocb_mask, tick_nohz_full_mask);
2478#endif /* #ifdef CONFIG_NO_HZ_FULL */
2476 if (ls == -1) { 2479 if (ls == -1) {
2477 ls = int_sqrt(nr_cpu_ids); 2480 ls = int_sqrt(nr_cpu_ids);
2478 rcu_nocb_leader_stride = ls; 2481 rcu_nocb_leader_stride = ls;