aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJames Morris <james.l.morris@oracle.com>2014-12-04 16:49:14 -0500
committerJames Morris <james.l.morris@oracle.com>2014-12-04 16:49:14 -0500
commitb2d1965dcea148100ffc4e7199470bf5fad13871 (patch)
treef7ccbc1b4c36c0ceb446122f17958a23ff0b2bbf
parentac14ae25b676d721b6bfcfb046dc53a9f7760d83 (diff)
parent00fec2a10b51a071ec92da256ccd30f6b13fc55b (diff)
Merge branch 'next' of git://git.infradead.org/users/pcmoore/selinux into next
-rw-r--r--security/selinux/hooks.c11
1 files changed, 5 insertions, 6 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 29e64d4ca099..49fc8338bcc7 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -95,8 +95,6 @@
95#include "audit.h" 95#include "audit.h"
96#include "avc_ss.h" 96#include "avc_ss.h"
97 97
98extern struct security_operations *security_ops;
99
100/* SECMARK reference count */ 98/* SECMARK reference count */
101static atomic_t selinux_secmark_refcount = ATOMIC_INIT(0); 99static atomic_t selinux_secmark_refcount = ATOMIC_INIT(0);
102 100
@@ -481,6 +479,7 @@ next_inode:
481 list_entry(sbsec->isec_head.next, 479 list_entry(sbsec->isec_head.next,
482 struct inode_security_struct, list); 480 struct inode_security_struct, list);
483 struct inode *inode = isec->inode; 481 struct inode *inode = isec->inode;
482 list_del_init(&isec->list);
484 spin_unlock(&sbsec->isec_lock); 483 spin_unlock(&sbsec->isec_lock);
485 inode = igrab(inode); 484 inode = igrab(inode);
486 if (inode) { 485 if (inode) {
@@ -489,7 +488,6 @@ next_inode:
489 iput(inode); 488 iput(inode);
490 } 489 }
491 spin_lock(&sbsec->isec_lock); 490 spin_lock(&sbsec->isec_lock);
492 list_del_init(&isec->list);
493 goto next_inode; 491 goto next_inode;
494 } 492 }
495 spin_unlock(&sbsec->isec_lock); 493 spin_unlock(&sbsec->isec_lock);
@@ -4727,9 +4725,10 @@ static int selinux_nlmsg_perm(struct sock *sk, struct sk_buff *skb)
4727 err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm); 4725 err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm);
4728 if (err) { 4726 if (err) {
4729 if (err == -EINVAL) { 4727 if (err == -EINVAL) {
4730 WARN_ONCE(1, "selinux_nlmsg_perm: unrecognized netlink message:" 4728 printk(KERN_WARNING
4731 " protocol=%hu nlmsg_type=%hu sclass=%hu\n", 4729 "SELinux: unrecognized netlink message:"
4732 sk->sk_protocol, nlh->nlmsg_type, sksec->sclass); 4730 " protocol=%hu nlmsg_type=%hu sclass=%hu\n",
4731 sk->sk_protocol, nlh->nlmsg_type, sksec->sclass);
4733 if (!selinux_enforcing || security_get_allow_unknown()) 4732 if (!selinux_enforcing || security_get_allow_unknown())
4734 err = 0; 4733 err = 0;
4735 } 4734 }