diff options
author | Jean Delvare <jdelvare@suse.de> | 2014-05-20 05:15:25 -0400 |
---|---|---|
committer | Inki Dae <daeinki@gmail.com> | 2014-06-01 13:07:10 -0400 |
commit | b26c04f47c260b7ae75f9fc55a3e613df0d1414f (patch) | |
tree | 73426586a5c251094eea42fe08707223cb3be1f6 | |
parent | 66367461e573321f0fbb0be0391165b5a54d5fe4 (diff) |
drm/exynos: Fix PTN3460 dependency
The following configuration options combination:
CONFIG_DRM_EXYNOS_DP=y
CONFIG_DRM_PTN3460=m
currently leads to the following linker failure:
drivers/built-in.o: In function `exynos_drm_attach_lcd_bridge':
.../drivers/gpu/drm/exynos/exynos_dp_core.c:1004:
undefined reference to `ptn3460_init'
This is because ptn3460_init can't be implemented in a module while
its caller is built into the kernel. So add the proper dependency in
Kconfig so that the above can't happen.
I moved DRM_PTN3460 earlier in Kconfig, next to the I2C helper module
section, so that the user has a chance to select it before moving to
the Exynos-specific section.
IMHO the proper way to solve the problem would be to turn ptn3460 into
a clean I2C driver, similar to the other I2C helper chip drivers. It's
the only way to not sink into impossible-to-guess dependencies. Then
ptn3460 could even be moved together with the other I2C helper chip
drivers.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
-rw-r--r-- | drivers/gpu/drm/Kconfig | 4 | ||||
-rw-r--r-- | drivers/gpu/drm/exynos/Kconfig | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index d1cc2f613a78..f5120046ff80 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig | |||
@@ -83,6 +83,8 @@ config DRM_KMS_CMA_HELPER | |||
83 | 83 | ||
84 | source "drivers/gpu/drm/i2c/Kconfig" | 84 | source "drivers/gpu/drm/i2c/Kconfig" |
85 | 85 | ||
86 | source "drivers/gpu/drm/bridge/Kconfig" | ||
87 | |||
86 | config DRM_TDFX | 88 | config DRM_TDFX |
87 | tristate "3dfx Banshee/Voodoo3+" | 89 | tristate "3dfx Banshee/Voodoo3+" |
88 | depends on DRM && PCI | 90 | depends on DRM && PCI |
@@ -199,5 +201,3 @@ source "drivers/gpu/drm/msm/Kconfig" | |||
199 | source "drivers/gpu/drm/tegra/Kconfig" | 201 | source "drivers/gpu/drm/tegra/Kconfig" |
200 | 202 | ||
201 | source "drivers/gpu/drm/panel/Kconfig" | 203 | source "drivers/gpu/drm/panel/Kconfig" |
202 | |||
203 | source "drivers/gpu/drm/bridge/Kconfig" | ||
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 5bf5bca94f56..c8c95108652c 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig | |||
@@ -50,7 +50,7 @@ config DRM_EXYNOS_DSI | |||
50 | 50 | ||
51 | config DRM_EXYNOS_DP | 51 | config DRM_EXYNOS_DP |
52 | bool "EXYNOS DRM DP driver support" | 52 | bool "EXYNOS DRM DP driver support" |
53 | depends on DRM_EXYNOS && ARCH_EXYNOS | 53 | depends on DRM_EXYNOS && ARCH_EXYNOS && (DRM_PTN3460=n || DRM_PTN3460=y || DRM_PTN3460=DRM_EXYNOS) |
54 | default DRM_EXYNOS | 54 | default DRM_EXYNOS |
55 | help | 55 | help |
56 | This enables support for DP device. | 56 | This enables support for DP device. |