diff options
author | Christian Borntraeger <borntraeger@de.ibm.com> | 2013-01-07 09:51:52 -0500 |
---|---|---|
committer | Marcelo Tosatti <mtosatti@redhat.com> | 2013-01-09 15:40:19 -0500 |
commit | b26ba22bb4f12289f9d5eb878c490e674934a197 (patch) | |
tree | 0782745449e21009e95e74ff6efbfbf7b14cf1d5 | |
parent | 73fa21ea4fc662a2e8e85f84c4ca3fcb55fa4da2 (diff) |
KVM: s390: Gracefully handle busy conditions on ccw_device_start
In rare cases a virtio command might try to issue a ccw before a former
ccw was answered with a tsch. This will cause CC=2 (busy). Lets just
retry in that case.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
-rw-r--r-- | drivers/s390/kvm/virtio_ccw.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c index 70419a75d0e0..2edd94af131c 100644 --- a/drivers/s390/kvm/virtio_ccw.c +++ b/drivers/s390/kvm/virtio_ccw.c | |||
@@ -132,11 +132,14 @@ static int ccw_io_helper(struct virtio_ccw_device *vcdev, | |||
132 | unsigned long flags; | 132 | unsigned long flags; |
133 | int flag = intparm & VIRTIO_CCW_INTPARM_MASK; | 133 | int flag = intparm & VIRTIO_CCW_INTPARM_MASK; |
134 | 134 | ||
135 | spin_lock_irqsave(get_ccwdev_lock(vcdev->cdev), flags); | 135 | do { |
136 | ret = ccw_device_start(vcdev->cdev, ccw, intparm, 0, 0); | 136 | spin_lock_irqsave(get_ccwdev_lock(vcdev->cdev), flags); |
137 | if (!ret) | 137 | ret = ccw_device_start(vcdev->cdev, ccw, intparm, 0, 0); |
138 | vcdev->curr_io |= flag; | 138 | if (!ret) |
139 | spin_unlock_irqrestore(get_ccwdev_lock(vcdev->cdev), flags); | 139 | vcdev->curr_io |= flag; |
140 | spin_unlock_irqrestore(get_ccwdev_lock(vcdev->cdev), flags); | ||
141 | cpu_relax(); | ||
142 | } while (ret == -EBUSY); | ||
140 | wait_event(vcdev->wait_q, doing_io(vcdev, flag) == 0); | 143 | wait_event(vcdev->wait_q, doing_io(vcdev, flag) == 0); |
141 | return ret ? ret : vcdev->err; | 144 | return ret ? ret : vcdev->err; |
142 | } | 145 | } |