diff options
| author | Brian Norris <computersforpeace@gmail.com> | 2015-02-28 05:02:27 -0500 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2015-03-11 18:21:48 -0400 |
| commit | b1a2348a1ac1380adf429035dbf3fdad0d5367bc (patch) | |
| tree | 4c572468b5ea194554e4eebeb9cd3ebd674d1dd6 | |
| parent | b9da8bae416efda5ad61c7c92edbb30de15ff7ee (diff) | |
mtd: nand: fixup bounds checks for nand_{lock,unlock}()
Coverity noticed that these 'ret' assignments weren't being used. Let's
use them.
Note that nand_lock() and nand_unlock() are still not officially used by
any drivers.
Coverity CIDs #1227054 and #1227037
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
| -rw-r--r-- | drivers/mtd/nand/nand_base.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index df7eb4ff07d1..5488a7ad63e7 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c | |||
| @@ -968,7 +968,7 @@ int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len) | |||
| 968 | __func__, (unsigned long long)ofs, len); | 968 | __func__, (unsigned long long)ofs, len); |
| 969 | 969 | ||
| 970 | if (check_offs_len(mtd, ofs, len)) | 970 | if (check_offs_len(mtd, ofs, len)) |
| 971 | ret = -EINVAL; | 971 | return -EINVAL; |
| 972 | 972 | ||
| 973 | /* Align to last block address if size addresses end of the device */ | 973 | /* Align to last block address if size addresses end of the device */ |
| 974 | if (ofs + len == mtd->size) | 974 | if (ofs + len == mtd->size) |
| @@ -1031,7 +1031,7 @@ int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len) | |||
| 1031 | __func__, (unsigned long long)ofs, len); | 1031 | __func__, (unsigned long long)ofs, len); |
| 1032 | 1032 | ||
| 1033 | if (check_offs_len(mtd, ofs, len)) | 1033 | if (check_offs_len(mtd, ofs, len)) |
| 1034 | ret = -EINVAL; | 1034 | return -EINVAL; |
| 1035 | 1035 | ||
| 1036 | nand_get_device(mtd, FL_LOCKING); | 1036 | nand_get_device(mtd, FL_LOCKING); |
| 1037 | 1037 | ||
