diff options
author | Geert Uytterhoeven <geert+renesas@glider.be> | 2015-01-06 08:39:10 -0500 |
---|---|---|
committer | Simon Horman <horms+renesas@verge.net.au> | 2015-01-07 19:15:16 -0500 |
commit | b0ddb319db3d7a1943445f0de0a45c07a7f3457a (patch) | |
tree | ddb9e6f65fd820f96507a2002d34da34cd5eb465 | |
parent | d034f53cc6c5c09a4e10cb9716986f3844c58514 (diff) |
ARM: shmobile: sh73a0 legacy: Set .control_parent for all irqpin instances
The sh73a0 INTC can't mask interrupts properly most likely due to a
hardware bug. Set the .control_parent flag to delegate masking to the
parent interrupt controller, like was already done for irqpin1.
Without this, accessing the three-axis digital accelerometer ADXL345
on kzm9g through /dev/input/event1 causes an interrupt storm, which
requires a power-cycle to recover from.
This was inspired by a patch for arch/arm/boot/dts/sh73a0.dtsi from
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: 341eb5465f67437a ("ARM: shmobile: INTC External IRQ pin driver on sh73a0")
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
-rw-r--r-- | arch/arm/mach-shmobile/setup-sh73a0.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c index fa7cab820ab9..b5d0cf579c61 100644 --- a/arch/arm/mach-shmobile/setup-sh73a0.c +++ b/arch/arm/mach-shmobile/setup-sh73a0.c | |||
@@ -579,6 +579,7 @@ static struct platform_device ipmmu_device = { | |||
579 | 579 | ||
580 | static struct renesas_intc_irqpin_config irqpin0_platform_data = { | 580 | static struct renesas_intc_irqpin_config irqpin0_platform_data = { |
581 | .irq_base = irq_pin(0), /* IRQ0 -> IRQ7 */ | 581 | .irq_base = irq_pin(0), /* IRQ0 -> IRQ7 */ |
582 | .control_parent = true, | ||
582 | }; | 583 | }; |
583 | 584 | ||
584 | static struct resource irqpin0_resources[] = { | 585 | static struct resource irqpin0_resources[] = { |
@@ -640,6 +641,7 @@ static struct platform_device irqpin1_device = { | |||
640 | 641 | ||
641 | static struct renesas_intc_irqpin_config irqpin2_platform_data = { | 642 | static struct renesas_intc_irqpin_config irqpin2_platform_data = { |
642 | .irq_base = irq_pin(16), /* IRQ16 -> IRQ23 */ | 643 | .irq_base = irq_pin(16), /* IRQ16 -> IRQ23 */ |
644 | .control_parent = true, | ||
643 | }; | 645 | }; |
644 | 646 | ||
645 | static struct resource irqpin2_resources[] = { | 647 | static struct resource irqpin2_resources[] = { |
@@ -670,6 +672,7 @@ static struct platform_device irqpin2_device = { | |||
670 | 672 | ||
671 | static struct renesas_intc_irqpin_config irqpin3_platform_data = { | 673 | static struct renesas_intc_irqpin_config irqpin3_platform_data = { |
672 | .irq_base = irq_pin(24), /* IRQ24 -> IRQ31 */ | 674 | .irq_base = irq_pin(24), /* IRQ24 -> IRQ31 */ |
675 | .control_parent = true, | ||
673 | }; | 676 | }; |
674 | 677 | ||
675 | static struct resource irqpin3_resources[] = { | 678 | static struct resource irqpin3_resources[] = { |