aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorShannon Nelson <shannon.nelson@intel.com>2013-11-20 05:03:06 -0500
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2013-12-10 04:27:29 -0500
commitb03aaa9c733e15d0d13f4f80987f6b93fc6a9e03 (patch)
treecee6bc729e59a6d5a1cc5954e4e89da92562060e
parent5824d2d16d39a9c57aa3bacf955fbd0c2134061f (diff)
i40e: restrict diag test messages
Use the netif_info() macro to restrict messaging to when the HW bit is enabled in the msglvl netdev message mask. Change-Id: I83030d4402991cfb7da100da00f05ce502ada4ae Signed-off-by: Shannon Nelson <shannon.nelson@intel.com> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-rw-r--r--drivers/net/ethernet/intel/i40e/i40e_ethtool.c21
1 files changed, 12 insertions, 9 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index f0bab1704dd1..b04e4337df47 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -711,7 +711,7 @@ static int i40e_link_test(struct net_device *netdev, u64 *data)
711 struct i40e_netdev_priv *np = netdev_priv(netdev); 711 struct i40e_netdev_priv *np = netdev_priv(netdev);
712 struct i40e_pf *pf = np->vsi->back; 712 struct i40e_pf *pf = np->vsi->back;
713 713
714 netdev_info(netdev, "link test\n"); 714 netif_info(pf, hw, netdev, "link test\n");
715 if (i40e_get_link_status(&pf->hw)) 715 if (i40e_get_link_status(&pf->hw))
716 *data = 0; 716 *data = 0;
717 else 717 else
@@ -725,7 +725,7 @@ static int i40e_reg_test(struct net_device *netdev, u64 *data)
725 struct i40e_netdev_priv *np = netdev_priv(netdev); 725 struct i40e_netdev_priv *np = netdev_priv(netdev);
726 struct i40e_pf *pf = np->vsi->back; 726 struct i40e_pf *pf = np->vsi->back;
727 727
728 netdev_info(netdev, "register test\n"); 728 netif_info(pf, hw, netdev, "register test\n");
729 *data = i40e_diag_reg_test(&pf->hw); 729 *data = i40e_diag_reg_test(&pf->hw);
730 730
731 i40e_do_reset(pf, (1 << __I40E_PF_RESET_REQUESTED)); 731 i40e_do_reset(pf, (1 << __I40E_PF_RESET_REQUESTED));
@@ -737,7 +737,7 @@ static int i40e_eeprom_test(struct net_device *netdev, u64 *data)
737 struct i40e_netdev_priv *np = netdev_priv(netdev); 737 struct i40e_netdev_priv *np = netdev_priv(netdev);
738 struct i40e_pf *pf = np->vsi->back; 738 struct i40e_pf *pf = np->vsi->back;
739 739
740 netdev_info(netdev, "eeprom test\n"); 740 netif_info(pf, hw, netdev, "eeprom test\n");
741 *data = i40e_diag_eeprom_test(&pf->hw); 741 *data = i40e_diag_eeprom_test(&pf->hw);
742 742
743 return *data; 743 return *data;
@@ -749,7 +749,7 @@ static int i40e_intr_test(struct net_device *netdev, u64 *data)
749 struct i40e_pf *pf = np->vsi->back; 749 struct i40e_pf *pf = np->vsi->back;
750 u16 swc_old = pf->sw_int_count; 750 u16 swc_old = pf->sw_int_count;
751 751
752 netdev_info(netdev, "interrupt test\n"); 752 netif_info(pf, hw, netdev, "interrupt test\n");
753 wr32(&pf->hw, I40E_PFINT_DYN_CTL0, 753 wr32(&pf->hw, I40E_PFINT_DYN_CTL0,
754 (I40E_PFINT_DYN_CTL0_INTENA_MASK | 754 (I40E_PFINT_DYN_CTL0_INTENA_MASK |
755 I40E_PFINT_DYN_CTL0_SWINT_TRIG_MASK)); 755 I40E_PFINT_DYN_CTL0_SWINT_TRIG_MASK));
@@ -761,7 +761,10 @@ static int i40e_intr_test(struct net_device *netdev, u64 *data)
761 761
762static int i40e_loopback_test(struct net_device *netdev, u64 *data) 762static int i40e_loopback_test(struct net_device *netdev, u64 *data)
763{ 763{
764 netdev_info(netdev, "loopback test not implemented\n"); 764 struct i40e_netdev_priv *np = netdev_priv(netdev);
765 struct i40e_pf *pf = np->vsi->back;
766
767 netif_info(pf, hw, netdev, "loopback test not implemented\n");
765 *data = 0; 768 *data = 0;
766 769
767 return *data; 770 return *data;
@@ -776,8 +779,7 @@ static void i40e_diag_test(struct net_device *netdev,
776 set_bit(__I40E_TESTING, &pf->state); 779 set_bit(__I40E_TESTING, &pf->state);
777 if (eth_test->flags == ETH_TEST_FL_OFFLINE) { 780 if (eth_test->flags == ETH_TEST_FL_OFFLINE) {
778 /* Offline tests */ 781 /* Offline tests */
779 782 netif_info(pf, drv, netdev, "offline testing starting\n");
780 netdev_info(netdev, "offline testing starting\n");
781 783
782 /* Link test performed before hardware reset 784 /* Link test performed before hardware reset
783 * so autoneg doesn't interfere with test result 785 * so autoneg doesn't interfere with test result
@@ -798,8 +800,9 @@ static void i40e_diag_test(struct net_device *netdev,
798 eth_test->flags |= ETH_TEST_FL_FAILED; 800 eth_test->flags |= ETH_TEST_FL_FAILED;
799 801
800 } else { 802 } else {
801 netdev_info(netdev, "online test starting\n");
802 /* Online tests */ 803 /* Online tests */
804 netif_info(pf, drv, netdev, "online testing starting\n");
805
803 if (i40e_link_test(netdev, &data[I40E_ETH_TEST_LINK])) 806 if (i40e_link_test(netdev, &data[I40E_ETH_TEST_LINK]))
804 eth_test->flags |= ETH_TEST_FL_FAILED; 807 eth_test->flags |= ETH_TEST_FL_FAILED;
805 808
@@ -811,7 +814,7 @@ static void i40e_diag_test(struct net_device *netdev,
811 } 814 }
812 clear_bit(__I40E_TESTING, &pf->state); 815 clear_bit(__I40E_TESTING, &pf->state);
813 816
814 netdev_info(netdev, "testing finished\n"); 817 netif_info(pf, drv, netdev, "testing finished\n");
815} 818}
816 819
817static void i40e_get_wol(struct net_device *netdev, 820static void i40e_get_wol(struct net_device *netdev,