diff options
| author | Julia Lawall <julia@diku.dk> | 2011-12-27 09:01:26 -0500 |
|---|---|---|
| committer | Grant Likely <grant.likely@secretlab.ca> | 2012-01-02 03:43:50 -0500 |
| commit | aedd4fdf69293fc5379129294239b09da2a7c3ec (patch) | |
| tree | 682342377523e1466e1fcf0671b646d4682fd786 | |
| parent | d0ad5e89256c351ddd40167152c24a88efcb0f6d (diff) | |
drivers/gpio/gpio-tegra.c: use devm_request_and_ioremap
Reimplement a call to devm_request_mem_region followed by a call to ioremap
or ioremap_nocache by a call to devm_request_and_ioremap.
The semantic patch that makes this transformation is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@nm@
expression myname;
identifier i;
@@
struct platform_driver i = { .driver = { .name = myname } };
@@
expression dev,res,size;
expression nm.myname;
@@
-if (!devm_request_mem_region(dev, res->start, size,
- \(res->name\|dev_name(dev)\|myname\))) {
- ...
- return ...;
-}
... when != res->start
(
-devm_ioremap(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
|
-devm_ioremap_nocache(dev,res->start,size)
+devm_request_and_ioremap(dev,res)
)
... when any
when != res->start
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
| -rw-r--r-- | drivers/gpio/gpio-tegra.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 61044c889f7f..bdc293791590 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c | |||
| @@ -361,14 +361,7 @@ static int __devinit tegra_gpio_probe(struct platform_device *pdev) | |||
| 361 | return -ENODEV; | 361 | return -ENODEV; |
| 362 | } | 362 | } |
| 363 | 363 | ||
| 364 | if (!devm_request_mem_region(&pdev->dev, res->start, | 364 | regs = devm_request_and_ioremap(&pdev->dev, res); |
| 365 | resource_size(res), | ||
| 366 | dev_name(&pdev->dev))) { | ||
| 367 | dev_err(&pdev->dev, "Couldn't request MEM resource\n"); | ||
| 368 | return -ENODEV; | ||
| 369 | } | ||
| 370 | |||
| 371 | regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); | ||
| 372 | if (!regs) { | 365 | if (!regs) { |
| 373 | dev_err(&pdev->dev, "Couldn't ioremap regs\n"); | 366 | dev_err(&pdev->dev, "Couldn't ioremap regs\n"); |
| 374 | return -ENODEV; | 367 | return -ENODEV; |
