diff options
author | David Teigland <teigland@redhat.com> | 2008-01-08 16:37:47 -0500 |
---|---|---|
committer | David Teigland <teigland@redhat.com> | 2008-01-30 12:04:42 -0500 |
commit | aec64e1be2225c6fc64499594d23257c6adf6168 (patch) | |
tree | d4aa437666e7b8a04e926d27f5e6f29e0f037715 | |
parent | 601342ce022b964f756b67f2eb99b605c1afa3ed (diff) |
dlm: another call to confirm_master in receive_request_reply
When a failed request (EBADR or ENOTBLK) is unlocked/canceled instead of
retried, there may be other lkb's waiting on the rsb_lookup list for it
to complete. A call to confirm_master() is needed to move on to the next
waiting lkb since the current one won't be retried.
Signed-off-by: David Teigland <teigland@redhat.com>
-rw-r--r-- | fs/dlm/lock.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index a758f1b80e3b..d5e8ea1b4f75 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c | |||
@@ -1940,8 +1940,11 @@ static void confirm_master(struct dlm_rsb *r, int error) | |||
1940 | break; | 1940 | break; |
1941 | 1941 | ||
1942 | case -EAGAIN: | 1942 | case -EAGAIN: |
1943 | /* the remote master didn't queue our NOQUEUE request; | 1943 | case -EBADR: |
1944 | make a waiting lkb the first_lkid */ | 1944 | case -ENOTBLK: |
1945 | /* the remote request failed and won't be retried (it was | ||
1946 | a NOQUEUE, or has been canceled/unlocked); make a waiting | ||
1947 | lkb the first_lkid */ | ||
1945 | 1948 | ||
1946 | r->res_first_lkid = 0; | 1949 | r->res_first_lkid = 0; |
1947 | 1950 | ||
@@ -3382,6 +3385,7 @@ static void receive_request_reply(struct dlm_ls *ls, struct dlm_message *ms) | |||
3382 | if (is_overlap(lkb)) { | 3385 | if (is_overlap(lkb)) { |
3383 | /* we'll ignore error in cancel/unlock reply */ | 3386 | /* we'll ignore error in cancel/unlock reply */ |
3384 | queue_cast_overlap(r, lkb); | 3387 | queue_cast_overlap(r, lkb); |
3388 | confirm_master(r, result); | ||
3385 | unhold_lkb(lkb); /* undoes create_lkb() */ | 3389 | unhold_lkb(lkb); /* undoes create_lkb() */ |
3386 | } else | 3390 | } else |
3387 | _request_lock(r, lkb); | 3391 | _request_lock(r, lkb); |