diff options
author | Tony Prisk <linux@prisktech.co.nz> | 2012-12-18 02:28:39 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2013-01-06 06:34:50 -0500 |
commit | aeae3db1c267759661609c76d6c7791231ae438a (patch) | |
tree | 35b9ca83c5457ac2e0854faa5ded4deaa377055b | |
parent | cf48f56c27ecfe94fbea363db6e8e0bacbd525ed (diff) |
[media] s5p-tv: Fix incorrect usage of IS_ERR_OR_NULL
Replace IS_ERR_OR_NULL with IS_ERR on clk_get results.
Signed-off-by: Tony Prisk <linux@prisktech.co.nz>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/platform/s5p-tv/hdmi_drv.c | 10 | ||||
-rw-r--r-- | drivers/media/platform/s5p-tv/mixer_drv.c | 10 |
2 files changed, 10 insertions, 10 deletions
diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c index 8a9cf43018f6..1c48ca5e419f 100644 --- a/drivers/media/platform/s5p-tv/hdmi_drv.c +++ b/drivers/media/platform/s5p-tv/hdmi_drv.c | |||
@@ -781,27 +781,27 @@ static int hdmi_resources_init(struct hdmi_device *hdev) | |||
781 | /* get clocks, power */ | 781 | /* get clocks, power */ |
782 | 782 | ||
783 | res->hdmi = clk_get(dev, "hdmi"); | 783 | res->hdmi = clk_get(dev, "hdmi"); |
784 | if (IS_ERR_OR_NULL(res->hdmi)) { | 784 | if (IS_ERR(res->hdmi)) { |
785 | dev_err(dev, "failed to get clock 'hdmi'\n"); | 785 | dev_err(dev, "failed to get clock 'hdmi'\n"); |
786 | goto fail; | 786 | goto fail; |
787 | } | 787 | } |
788 | res->sclk_hdmi = clk_get(dev, "sclk_hdmi"); | 788 | res->sclk_hdmi = clk_get(dev, "sclk_hdmi"); |
789 | if (IS_ERR_OR_NULL(res->sclk_hdmi)) { | 789 | if (IS_ERR(res->sclk_hdmi)) { |
790 | dev_err(dev, "failed to get clock 'sclk_hdmi'\n"); | 790 | dev_err(dev, "failed to get clock 'sclk_hdmi'\n"); |
791 | goto fail; | 791 | goto fail; |
792 | } | 792 | } |
793 | res->sclk_pixel = clk_get(dev, "sclk_pixel"); | 793 | res->sclk_pixel = clk_get(dev, "sclk_pixel"); |
794 | if (IS_ERR_OR_NULL(res->sclk_pixel)) { | 794 | if (IS_ERR(res->sclk_pixel)) { |
795 | dev_err(dev, "failed to get clock 'sclk_pixel'\n"); | 795 | dev_err(dev, "failed to get clock 'sclk_pixel'\n"); |
796 | goto fail; | 796 | goto fail; |
797 | } | 797 | } |
798 | res->sclk_hdmiphy = clk_get(dev, "sclk_hdmiphy"); | 798 | res->sclk_hdmiphy = clk_get(dev, "sclk_hdmiphy"); |
799 | if (IS_ERR_OR_NULL(res->sclk_hdmiphy)) { | 799 | if (IS_ERR(res->sclk_hdmiphy)) { |
800 | dev_err(dev, "failed to get clock 'sclk_hdmiphy'\n"); | 800 | dev_err(dev, "failed to get clock 'sclk_hdmiphy'\n"); |
801 | goto fail; | 801 | goto fail; |
802 | } | 802 | } |
803 | res->hdmiphy = clk_get(dev, "hdmiphy"); | 803 | res->hdmiphy = clk_get(dev, "hdmiphy"); |
804 | if (IS_ERR_OR_NULL(res->hdmiphy)) { | 804 | if (IS_ERR(res->hdmiphy)) { |
805 | dev_err(dev, "failed to get clock 'hdmiphy'\n"); | 805 | dev_err(dev, "failed to get clock 'hdmiphy'\n"); |
806 | goto fail; | 806 | goto fail; |
807 | } | 807 | } |
diff --git a/drivers/media/platform/s5p-tv/mixer_drv.c b/drivers/media/platform/s5p-tv/mixer_drv.c index ca0f29717448..c1b2e0ed20d2 100644 --- a/drivers/media/platform/s5p-tv/mixer_drv.c +++ b/drivers/media/platform/s5p-tv/mixer_drv.c | |||
@@ -240,27 +240,27 @@ static int mxr_acquire_clocks(struct mxr_device *mdev) | |||
240 | struct device *dev = mdev->dev; | 240 | struct device *dev = mdev->dev; |
241 | 241 | ||
242 | res->mixer = clk_get(dev, "mixer"); | 242 | res->mixer = clk_get(dev, "mixer"); |
243 | if (IS_ERR_OR_NULL(res->mixer)) { | 243 | if (IS_ERR(res->mixer)) { |
244 | mxr_err(mdev, "failed to get clock 'mixer'\n"); | 244 | mxr_err(mdev, "failed to get clock 'mixer'\n"); |
245 | goto fail; | 245 | goto fail; |
246 | } | 246 | } |
247 | res->vp = clk_get(dev, "vp"); | 247 | res->vp = clk_get(dev, "vp"); |
248 | if (IS_ERR_OR_NULL(res->vp)) { | 248 | if (IS_ERR(res->vp)) { |
249 | mxr_err(mdev, "failed to get clock 'vp'\n"); | 249 | mxr_err(mdev, "failed to get clock 'vp'\n"); |
250 | goto fail; | 250 | goto fail; |
251 | } | 251 | } |
252 | res->sclk_mixer = clk_get(dev, "sclk_mixer"); | 252 | res->sclk_mixer = clk_get(dev, "sclk_mixer"); |
253 | if (IS_ERR_OR_NULL(res->sclk_mixer)) { | 253 | if (IS_ERR(res->sclk_mixer)) { |
254 | mxr_err(mdev, "failed to get clock 'sclk_mixer'\n"); | 254 | mxr_err(mdev, "failed to get clock 'sclk_mixer'\n"); |
255 | goto fail; | 255 | goto fail; |
256 | } | 256 | } |
257 | res->sclk_hdmi = clk_get(dev, "sclk_hdmi"); | 257 | res->sclk_hdmi = clk_get(dev, "sclk_hdmi"); |
258 | if (IS_ERR_OR_NULL(res->sclk_hdmi)) { | 258 | if (IS_ERR(res->sclk_hdmi)) { |
259 | mxr_err(mdev, "failed to get clock 'sclk_hdmi'\n"); | 259 | mxr_err(mdev, "failed to get clock 'sclk_hdmi'\n"); |
260 | goto fail; | 260 | goto fail; |
261 | } | 261 | } |
262 | res->sclk_dac = clk_get(dev, "sclk_dac"); | 262 | res->sclk_dac = clk_get(dev, "sclk_dac"); |
263 | if (IS_ERR_OR_NULL(res->sclk_dac)) { | 263 | if (IS_ERR(res->sclk_dac)) { |
264 | mxr_err(mdev, "failed to get clock 'sclk_dac'\n"); | 264 | mxr_err(mdev, "failed to get clock 'sclk_dac'\n"); |
265 | goto fail; | 265 | goto fail; |
266 | } | 266 | } |