diff options
author | Paul Gortmaker <paul.gortmaker@windriver.com> | 2013-06-17 10:54:47 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-06-17 18:53:01 -0400 |
commit | ae8509c420122866344bde1241e31858d0aa2fbc (patch) | |
tree | 5a026fe1729da4d5291951376683582cef9bf760 | |
parent | c0fee8aca7206264d5e3dcc4e60aaf86501f4ea1 (diff) |
tipc: cosmetic realignment of function arguments
No runtime code changes here. Just a realign of the function
arguments to start where the 1st one was, and fit as many args
as can be put in an 80 char line.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/tipc/bcast.c | 3 | ||||
-rw-r--r-- | net/tipc/bcast.h | 3 | ||||
-rw-r--r-- | net/tipc/discover.c | 7 | ||||
-rw-r--r-- | net/tipc/eth_media.c | 2 | ||||
-rw-r--r-- | net/tipc/link.c | 18 | ||||
-rw-r--r-- | net/tipc/msg.c | 4 | ||||
-rw-r--r-- | net/tipc/msg.h | 4 | ||||
-rw-r--r-- | net/tipc/name_table.c | 10 | ||||
-rw-r--r-- | net/tipc/name_table.h | 11 | ||||
-rw-r--r-- | net/tipc/node_subscr.c | 2 | ||||
-rw-r--r-- | net/tipc/port.c | 7 | ||||
-rw-r--r-- | net/tipc/port.h | 10 | ||||
-rw-r--r-- | net/tipc/socket.c | 12 | ||||
-rw-r--r-- | net/tipc/subscr.c | 14 | ||||
-rw-r--r-- | net/tipc/subscr.h | 13 |
15 files changed, 54 insertions, 66 deletions
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index e5f3da507823..716de1ac6cb5 100644 --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c | |||
@@ -578,8 +578,7 @@ u32 tipc_bclink_acks_missing(struct tipc_node *n_ptr) | |||
578 | * Returns 0 (packet sent successfully) under all circumstances, | 578 | * Returns 0 (packet sent successfully) under all circumstances, |
579 | * since the broadcast link's pseudo-bearer never blocks | 579 | * since the broadcast link's pseudo-bearer never blocks |
580 | */ | 580 | */ |
581 | static int tipc_bcbearer_send(struct sk_buff *buf, | 581 | static int tipc_bcbearer_send(struct sk_buff *buf, struct tipc_bearer *unused1, |
582 | struct tipc_bearer *unused1, | ||
583 | struct tipc_media_addr *unused2) | 582 | struct tipc_media_addr *unused2) |
584 | { | 583 | { |
585 | int bp_index; | 584 | int bp_index; |
diff --git a/net/tipc/bcast.h b/net/tipc/bcast.h index a93306557e00..6ee587b469fd 100644 --- a/net/tipc/bcast.h +++ b/net/tipc/bcast.h | |||
@@ -75,7 +75,8 @@ void tipc_nmap_remove(struct tipc_node_map *nm_ptr, u32 node); | |||
75 | /** | 75 | /** |
76 | * tipc_nmap_equal - test for equality of node maps | 76 | * tipc_nmap_equal - test for equality of node maps |
77 | */ | 77 | */ |
78 | static inline int tipc_nmap_equal(struct tipc_node_map *nm_a, struct tipc_node_map *nm_b) | 78 | static inline int tipc_nmap_equal(struct tipc_node_map *nm_a, |
79 | struct tipc_node_map *nm_b) | ||
79 | { | 80 | { |
80 | return !memcmp(nm_a, nm_b, sizeof(*nm_a)); | 81 | return !memcmp(nm_a, nm_b, sizeof(*nm_a)); |
81 | } | 82 | } |
diff --git a/net/tipc/discover.c b/net/tipc/discover.c index eedff58d0387..ecc758c6eacf 100644 --- a/net/tipc/discover.c +++ b/net/tipc/discover.c | |||
@@ -70,8 +70,7 @@ struct tipc_link_req { | |||
70 | * @dest_domain: network domain of node(s) which should respond to message | 70 | * @dest_domain: network domain of node(s) which should respond to message |
71 | * @b_ptr: ptr to bearer issuing message | 71 | * @b_ptr: ptr to bearer issuing message |
72 | */ | 72 | */ |
73 | static struct sk_buff *tipc_disc_init_msg(u32 type, | 73 | static struct sk_buff *tipc_disc_init_msg(u32 type, u32 dest_domain, |
74 | u32 dest_domain, | ||
75 | struct tipc_bearer *b_ptr) | 74 | struct tipc_bearer *b_ptr) |
76 | { | 75 | { |
77 | struct sk_buff *buf = tipc_buf_acquire(INT_H_SIZE); | 76 | struct sk_buff *buf = tipc_buf_acquire(INT_H_SIZE); |
@@ -346,8 +345,8 @@ exit: | |||
346 | * | 345 | * |
347 | * Returns 0 if successful, otherwise -errno. | 346 | * Returns 0 if successful, otherwise -errno. |
348 | */ | 347 | */ |
349 | int tipc_disc_create(struct tipc_bearer *b_ptr, | 348 | int tipc_disc_create(struct tipc_bearer *b_ptr, struct tipc_media_addr *dest, |
350 | struct tipc_media_addr *dest, u32 dest_domain) | 349 | u32 dest_domain) |
351 | { | 350 | { |
352 | struct tipc_link_req *req; | 351 | struct tipc_link_req *req; |
353 | 352 | ||
diff --git a/net/tipc/eth_media.c b/net/tipc/eth_media.c index fc60bea63169..c1aa37fdca2f 100644 --- a/net/tipc/eth_media.c +++ b/net/tipc/eth_media.c | |||
@@ -62,7 +62,7 @@ static struct eth_bearer eth_bearers[MAX_ETH_BEARERS]; | |||
62 | static int eth_started; | 62 | static int eth_started; |
63 | 63 | ||
64 | static int recv_notification(struct notifier_block *nb, unsigned long evt, | 64 | static int recv_notification(struct notifier_block *nb, unsigned long evt, |
65 | void *dv); | 65 | void *dv); |
66 | /* | 66 | /* |
67 | * Network device notifier info | 67 | * Network device notifier info |
68 | */ | 68 | */ |
diff --git a/net/tipc/link.c b/net/tipc/link.c index d34429d03c16..b852c94a784e 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c | |||
@@ -771,8 +771,7 @@ static void link_state_event(struct tipc_link *l_ptr, unsigned int event) | |||
771 | * link_bundle_buf(): Append contents of a buffer to | 771 | * link_bundle_buf(): Append contents of a buffer to |
772 | * the tail of an existing one. | 772 | * the tail of an existing one. |
773 | */ | 773 | */ |
774 | static int link_bundle_buf(struct tipc_link *l_ptr, | 774 | static int link_bundle_buf(struct tipc_link *l_ptr, struct sk_buff *bundler, |
775 | struct sk_buff *bundler, | ||
776 | struct sk_buff *buf) | 775 | struct sk_buff *buf) |
777 | { | 776 | { |
778 | struct tipc_msg *bundler_msg = buf_msg(bundler); | 777 | struct tipc_msg *bundler_msg = buf_msg(bundler); |
@@ -1064,8 +1063,7 @@ static int link_send_buf_fast(struct tipc_link *l_ptr, struct sk_buff *buf, | |||
1064 | */ | 1063 | */ |
1065 | int tipc_link_send_sections_fast(struct tipc_port *sender, | 1064 | int tipc_link_send_sections_fast(struct tipc_port *sender, |
1066 | struct iovec const *msg_sect, | 1065 | struct iovec const *msg_sect, |
1067 | const u32 num_sect, | 1066 | const u32 num_sect, unsigned int total_len, |
1068 | unsigned int total_len, | ||
1069 | u32 destaddr) | 1067 | u32 destaddr) |
1070 | { | 1068 | { |
1071 | struct tipc_msg *hdr = &sender->phdr; | 1069 | struct tipc_msg *hdr = &sender->phdr; |
@@ -1155,8 +1153,7 @@ exit: | |||
1155 | */ | 1153 | */ |
1156 | static int link_send_sections_long(struct tipc_port *sender, | 1154 | static int link_send_sections_long(struct tipc_port *sender, |
1157 | struct iovec const *msg_sect, | 1155 | struct iovec const *msg_sect, |
1158 | u32 num_sect, | 1156 | u32 num_sect, unsigned int total_len, |
1159 | unsigned int total_len, | ||
1160 | u32 destaddr) | 1157 | u32 destaddr) |
1161 | { | 1158 | { |
1162 | struct tipc_link *l_ptr; | 1159 | struct tipc_link *l_ptr; |
@@ -1408,7 +1405,7 @@ static void link_reset_all(unsigned long addr) | |||
1408 | } | 1405 | } |
1409 | 1406 | ||
1410 | static void link_retransmit_failure(struct tipc_link *l_ptr, | 1407 | static void link_retransmit_failure(struct tipc_link *l_ptr, |
1411 | struct sk_buff *buf) | 1408 | struct sk_buff *buf) |
1412 | { | 1409 | { |
1413 | struct tipc_msg *msg = buf_msg(buf); | 1410 | struct tipc_msg *msg = buf_msg(buf); |
1414 | 1411 | ||
@@ -1863,8 +1860,8 @@ static void link_handle_out_of_seq_msg(struct tipc_link *l_ptr, | |||
1863 | * Send protocol message to the other endpoint. | 1860 | * Send protocol message to the other endpoint. |
1864 | */ | 1861 | */ |
1865 | void tipc_link_send_proto_msg(struct tipc_link *l_ptr, u32 msg_typ, | 1862 | void tipc_link_send_proto_msg(struct tipc_link *l_ptr, u32 msg_typ, |
1866 | int probe_msg, u32 gap, u32 tolerance, | 1863 | int probe_msg, u32 gap, u32 tolerance, |
1867 | u32 priority, u32 ack_mtu) | 1864 | u32 priority, u32 ack_mtu) |
1868 | { | 1865 | { |
1869 | struct sk_buff *buf = NULL; | 1866 | struct sk_buff *buf = NULL; |
1870 | struct tipc_msg *msg = l_ptr->pmsg; | 1867 | struct tipc_msg *msg = l_ptr->pmsg; |
@@ -2107,8 +2104,7 @@ exit: | |||
2107 | * another bearer. Owner node is locked. | 2104 | * another bearer. Owner node is locked. |
2108 | */ | 2105 | */ |
2109 | static void tipc_link_tunnel(struct tipc_link *l_ptr, | 2106 | static void tipc_link_tunnel(struct tipc_link *l_ptr, |
2110 | struct tipc_msg *tunnel_hdr, | 2107 | struct tipc_msg *tunnel_hdr, struct tipc_msg *msg, |
2111 | struct tipc_msg *msg, | ||
2112 | u32 selector) | 2108 | u32 selector) |
2113 | { | 2109 | { |
2114 | struct tipc_link *tunnel; | 2110 | struct tipc_link *tunnel; |
diff --git a/net/tipc/msg.c b/net/tipc/msg.c index c2a261322515..ced60e2fc4f7 100644 --- a/net/tipc/msg.c +++ b/net/tipc/msg.c | |||
@@ -51,8 +51,8 @@ u32 tipc_msg_tot_importance(struct tipc_msg *m) | |||
51 | } | 51 | } |
52 | 52 | ||
53 | 53 | ||
54 | void tipc_msg_init(struct tipc_msg *m, u32 user, u32 type, | 54 | void tipc_msg_init(struct tipc_msg *m, u32 user, u32 type, u32 hsize, |
55 | u32 hsize, u32 destnode) | 55 | u32 destnode) |
56 | { | 56 | { |
57 | memset(m, 0, hsize); | 57 | memset(m, 0, hsize); |
58 | msg_set_version(m); | 58 | msg_set_version(m); |
diff --git a/net/tipc/msg.h b/net/tipc/msg.h index 511019a77c9c..5e4ccf5c27df 100644 --- a/net/tipc/msg.h +++ b/net/tipc/msg.h | |||
@@ -719,8 +719,8 @@ static inline void msg_set_link_tolerance(struct tipc_msg *m, u32 n) | |||
719 | } | 719 | } |
720 | 720 | ||
721 | u32 tipc_msg_tot_importance(struct tipc_msg *m); | 721 | u32 tipc_msg_tot_importance(struct tipc_msg *m); |
722 | void tipc_msg_init(struct tipc_msg *m, u32 user, u32 type, | 722 | void tipc_msg_init(struct tipc_msg *m, u32 user, u32 type, u32 hsize, |
723 | u32 hsize, u32 destnode); | 723 | u32 destnode); |
724 | int tipc_msg_build(struct tipc_msg *hdr, struct iovec const *msg_sect, | 724 | int tipc_msg_build(struct tipc_msg *hdr, struct iovec const *msg_sect, |
725 | u32 num_sect, unsigned int total_len, int max_size, | 725 | u32 num_sect, unsigned int total_len, int max_size, |
726 | struct sk_buff **buf); | 726 | struct sk_buff **buf); |
diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c index 24b167914311..09dcd54b04e1 100644 --- a/net/tipc/name_table.c +++ b/net/tipc/name_table.c | |||
@@ -440,7 +440,7 @@ found: | |||
440 | * sequence overlapping with the requested sequence | 440 | * sequence overlapping with the requested sequence |
441 | */ | 441 | */ |
442 | static void tipc_nameseq_subscribe(struct name_seq *nseq, | 442 | static void tipc_nameseq_subscribe(struct name_seq *nseq, |
443 | struct tipc_subscription *s) | 443 | struct tipc_subscription *s) |
444 | { | 444 | { |
445 | struct sub_seq *sseq = nseq->sseqs; | 445 | struct sub_seq *sseq = nseq->sseqs; |
446 | 446 | ||
@@ -662,7 +662,7 @@ exit: | |||
662 | * tipc_nametbl_publish - add name publication to network name tables | 662 | * tipc_nametbl_publish - add name publication to network name tables |
663 | */ | 663 | */ |
664 | struct publication *tipc_nametbl_publish(u32 type, u32 lower, u32 upper, | 664 | struct publication *tipc_nametbl_publish(u32 type, u32 lower, u32 upper, |
665 | u32 scope, u32 port_ref, u32 key) | 665 | u32 scope, u32 port_ref, u32 key) |
666 | { | 666 | { |
667 | struct publication *publ; | 667 | struct publication *publ; |
668 | 668 | ||
@@ -753,7 +753,7 @@ void tipc_nametbl_unsubscribe(struct tipc_subscription *s) | |||
753 | * subseq_list - print specified sub-sequence contents into the given buffer | 753 | * subseq_list - print specified sub-sequence contents into the given buffer |
754 | */ | 754 | */ |
755 | static int subseq_list(struct sub_seq *sseq, char *buf, int len, u32 depth, | 755 | static int subseq_list(struct sub_seq *sseq, char *buf, int len, u32 depth, |
756 | u32 index) | 756 | u32 index) |
757 | { | 757 | { |
758 | char portIdStr[27]; | 758 | char portIdStr[27]; |
759 | const char *scope_str[] = {"", " zone", " cluster", " node"}; | 759 | const char *scope_str[] = {"", " zone", " cluster", " node"}; |
@@ -792,7 +792,7 @@ static int subseq_list(struct sub_seq *sseq, char *buf, int len, u32 depth, | |||
792 | * nameseq_list - print specified name sequence contents into the given buffer | 792 | * nameseq_list - print specified name sequence contents into the given buffer |
793 | */ | 793 | */ |
794 | static int nameseq_list(struct name_seq *seq, char *buf, int len, u32 depth, | 794 | static int nameseq_list(struct name_seq *seq, char *buf, int len, u32 depth, |
795 | u32 type, u32 lowbound, u32 upbound, u32 index) | 795 | u32 type, u32 lowbound, u32 upbound, u32 index) |
796 | { | 796 | { |
797 | struct sub_seq *sseq; | 797 | struct sub_seq *sseq; |
798 | char typearea[11]; | 798 | char typearea[11]; |
@@ -849,7 +849,7 @@ static int nametbl_header(char *buf, int len, u32 depth) | |||
849 | * nametbl_list - print specified name table contents into the given buffer | 849 | * nametbl_list - print specified name table contents into the given buffer |
850 | */ | 850 | */ |
851 | static int nametbl_list(char *buf, int len, u32 depth_info, | 851 | static int nametbl_list(char *buf, int len, u32 depth_info, |
852 | u32 type, u32 lowbound, u32 upbound) | 852 | u32 type, u32 lowbound, u32 upbound) |
853 | { | 853 | { |
854 | struct hlist_head *seq_head; | 854 | struct hlist_head *seq_head; |
855 | struct name_seq *seq; | 855 | struct name_seq *seq; |
diff --git a/net/tipc/name_table.h b/net/tipc/name_table.h index 71cb4dc712df..f02f48b9a216 100644 --- a/net/tipc/name_table.h +++ b/net/tipc/name_table.h | |||
@@ -87,14 +87,15 @@ extern rwlock_t tipc_nametbl_lock; | |||
87 | struct sk_buff *tipc_nametbl_get(const void *req_tlv_area, int req_tlv_space); | 87 | struct sk_buff *tipc_nametbl_get(const void *req_tlv_area, int req_tlv_space); |
88 | u32 tipc_nametbl_translate(u32 type, u32 instance, u32 *node); | 88 | u32 tipc_nametbl_translate(u32 type, u32 instance, u32 *node); |
89 | int tipc_nametbl_mc_translate(u32 type, u32 lower, u32 upper, u32 limit, | 89 | int tipc_nametbl_mc_translate(u32 type, u32 lower, u32 upper, u32 limit, |
90 | struct tipc_port_list *dports); | 90 | struct tipc_port_list *dports); |
91 | struct publication *tipc_nametbl_publish(u32 type, u32 lower, u32 upper, | 91 | struct publication *tipc_nametbl_publish(u32 type, u32 lower, u32 upper, |
92 | u32 scope, u32 port_ref, u32 key); | 92 | u32 scope, u32 port_ref, u32 key); |
93 | int tipc_nametbl_withdraw(u32 type, u32 lower, u32 ref, u32 key); | 93 | int tipc_nametbl_withdraw(u32 type, u32 lower, u32 ref, u32 key); |
94 | struct publication *tipc_nametbl_insert_publ(u32 type, u32 lower, u32 upper, | 94 | struct publication *tipc_nametbl_insert_publ(u32 type, u32 lower, u32 upper, |
95 | u32 scope, u32 node, u32 ref, u32 key); | 95 | u32 scope, u32 node, u32 ref, |
96 | struct publication *tipc_nametbl_remove_publ(u32 type, u32 lower, | 96 | u32 key); |
97 | u32 node, u32 ref, u32 key); | 97 | struct publication *tipc_nametbl_remove_publ(u32 type, u32 lower, u32 node, |
98 | u32 ref, u32 key); | ||
98 | void tipc_nametbl_subscribe(struct tipc_subscription *s); | 99 | void tipc_nametbl_subscribe(struct tipc_subscription *s); |
99 | void tipc_nametbl_unsubscribe(struct tipc_subscription *s); | 100 | void tipc_nametbl_unsubscribe(struct tipc_subscription *s); |
100 | int tipc_nametbl_init(void); | 101 | int tipc_nametbl_init(void); |
diff --git a/net/tipc/node_subscr.c b/net/tipc/node_subscr.c index 5e34b015da45..8a7384c04add 100644 --- a/net/tipc/node_subscr.c +++ b/net/tipc/node_subscr.c | |||
@@ -42,7 +42,7 @@ | |||
42 | * tipc_nodesub_subscribe - create "node down" subscription for specified node | 42 | * tipc_nodesub_subscribe - create "node down" subscription for specified node |
43 | */ | 43 | */ |
44 | void tipc_nodesub_subscribe(struct tipc_node_subscr *node_sub, u32 addr, | 44 | void tipc_nodesub_subscribe(struct tipc_node_subscr *node_sub, u32 addr, |
45 | void *usr_handle, net_ev_handler handle_down) | 45 | void *usr_handle, net_ev_handler handle_down) |
46 | { | 46 | { |
47 | if (in_own_node(addr)) { | 47 | if (in_own_node(addr)) { |
48 | node_sub->node = NULL; | 48 | node_sub->node = NULL; |
diff --git a/net/tipc/port.c b/net/tipc/port.c index 0bb185a3ed4a..b3ed2fcab4fb 100644 --- a/net/tipc/port.c +++ b/net/tipc/port.c | |||
@@ -207,9 +207,10 @@ exit: | |||
207 | * Returns pointer to (locked) TIPC port, or NULL if unable to create it | 207 | * Returns pointer to (locked) TIPC port, or NULL if unable to create it |
208 | */ | 208 | */ |
209 | struct tipc_port *tipc_createport(struct sock *sk, | 209 | struct tipc_port *tipc_createport(struct sock *sk, |
210 | u32 (*dispatcher)(struct tipc_port *, struct sk_buff *), | 210 | u32 (*dispatcher)(struct tipc_port *, |
211 | void (*wakeup)(struct tipc_port *), | 211 | struct sk_buff *), |
212 | const u32 importance) | 212 | void (*wakeup)(struct tipc_port *), |
213 | const u32 importance) | ||
213 | { | 214 | { |
214 | struct tipc_port *p_ptr; | 215 | struct tipc_port *p_ptr; |
215 | struct tipc_msg *msg; | 216 | struct tipc_msg *msg; |
diff --git a/net/tipc/port.h b/net/tipc/port.h index 241f529db942..5a7026b9c345 100644 --- a/net/tipc/port.h +++ b/net/tipc/port.h | |||
@@ -107,8 +107,10 @@ struct tipc_port_list; | |||
107 | * TIPC port manipulation routines | 107 | * TIPC port manipulation routines |
108 | */ | 108 | */ |
109 | struct tipc_port *tipc_createport(struct sock *sk, | 109 | struct tipc_port *tipc_createport(struct sock *sk, |
110 | u32 (*dispatcher)(struct tipc_port *, struct sk_buff *), | 110 | u32 (*dispatcher)(struct tipc_port *, |
111 | void (*wakeup)(struct tipc_port *), const u32 importance); | 111 | struct sk_buff *), |
112 | void (*wakeup)(struct tipc_port *), | ||
113 | const u32 importance); | ||
112 | 114 | ||
113 | int tipc_reject_msg(struct sk_buff *buf, u32 err); | 115 | int tipc_reject_msg(struct sk_buff *buf, u32 err); |
114 | 116 | ||
@@ -126,9 +128,9 @@ int tipc_portunreturnable(u32 portref, unsigned int *isunreturnable); | |||
126 | int tipc_set_portunreturnable(u32 portref, unsigned int isunreturnable); | 128 | int tipc_set_portunreturnable(u32 portref, unsigned int isunreturnable); |
127 | 129 | ||
128 | int tipc_publish(u32 portref, unsigned int scope, | 130 | int tipc_publish(u32 portref, unsigned int scope, |
129 | struct tipc_name_seq const *name_seq); | 131 | struct tipc_name_seq const *name_seq); |
130 | int tipc_withdraw(u32 portref, unsigned int scope, | 132 | int tipc_withdraw(u32 portref, unsigned int scope, |
131 | struct tipc_name_seq const *name_seq); | 133 | struct tipc_name_seq const *name_seq); |
132 | 134 | ||
133 | int tipc_connect(u32 portref, struct tipc_portid const *port); | 135 | int tipc_connect(u32 portref, struct tipc_portid const *port); |
134 | 136 | ||
diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 14ed54e961b6..ce8249c76827 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c | |||
@@ -278,7 +278,7 @@ void tipc_sock_release_local(struct socket *sock) | |||
278 | */ | 278 | */ |
279 | 279 | ||
280 | int tipc_sock_accept_local(struct socket *sock, struct socket **newsock, | 280 | int tipc_sock_accept_local(struct socket *sock, struct socket **newsock, |
281 | int flags) | 281 | int flags) |
282 | { | 282 | { |
283 | struct sock *sk = sock->sk; | 283 | struct sock *sk = sock->sk; |
284 | int ret; | 284 | int ret; |
@@ -889,7 +889,7 @@ static void set_orig_addr(struct msghdr *m, struct tipc_msg *msg) | |||
889 | * Returns 0 if successful, otherwise errno | 889 | * Returns 0 if successful, otherwise errno |
890 | */ | 890 | */ |
891 | static int anc_data_recv(struct msghdr *m, struct tipc_msg *msg, | 891 | static int anc_data_recv(struct msghdr *m, struct tipc_msg *msg, |
892 | struct tipc_port *tport) | 892 | struct tipc_port *tport) |
893 | { | 893 | { |
894 | u32 anc_data[3]; | 894 | u32 anc_data[3]; |
895 | u32 err; | 895 | u32 err; |
@@ -1736,8 +1736,8 @@ restart: | |||
1736 | * | 1736 | * |
1737 | * Returns 0 on success, errno otherwise | 1737 | * Returns 0 on success, errno otherwise |
1738 | */ | 1738 | */ |
1739 | static int setsockopt(struct socket *sock, | 1739 | static int setsockopt(struct socket *sock, int lvl, int opt, char __user *ov, |
1740 | int lvl, int opt, char __user *ov, unsigned int ol) | 1740 | unsigned int ol) |
1741 | { | 1741 | { |
1742 | struct sock *sk = sock->sk; | 1742 | struct sock *sk = sock->sk; |
1743 | struct tipc_port *tport = tipc_sk_port(sk); | 1743 | struct tipc_port *tport = tipc_sk_port(sk); |
@@ -1795,8 +1795,8 @@ static int setsockopt(struct socket *sock, | |||
1795 | * | 1795 | * |
1796 | * Returns 0 on success, errno otherwise | 1796 | * Returns 0 on success, errno otherwise |
1797 | */ | 1797 | */ |
1798 | static int getsockopt(struct socket *sock, | 1798 | static int getsockopt(struct socket *sock, int lvl, int opt, char __user *ov, |
1799 | int lvl, int opt, char __user *ov, int __user *ol) | 1799 | int __user *ol) |
1800 | { | 1800 | { |
1801 | struct sock *sk = sock->sk; | 1801 | struct sock *sk = sock->sk; |
1802 | struct tipc_port *tport = tipc_sk_port(sk); | 1802 | struct tipc_port *tport = tipc_sk_port(sk); |
diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c index f6be92a6973a..d38bb45d82e9 100644 --- a/net/tipc/subscr.c +++ b/net/tipc/subscr.c | |||
@@ -117,10 +117,8 @@ static void subscr_send_event(struct tipc_subscription *sub, u32 found_lower, | |||
117 | * | 117 | * |
118 | * Returns 1 if there is overlap, otherwise 0. | 118 | * Returns 1 if there is overlap, otherwise 0. |
119 | */ | 119 | */ |
120 | int tipc_subscr_overlap(struct tipc_subscription *sub, | 120 | int tipc_subscr_overlap(struct tipc_subscription *sub, u32 found_lower, |
121 | u32 found_lower, | ||
122 | u32 found_upper) | 121 | u32 found_upper) |
123 | |||
124 | { | 122 | { |
125 | if (found_lower < sub->seq.lower) | 123 | if (found_lower < sub->seq.lower) |
126 | found_lower = sub->seq.lower; | 124 | found_lower = sub->seq.lower; |
@@ -136,13 +134,9 @@ int tipc_subscr_overlap(struct tipc_subscription *sub, | |||
136 | * | 134 | * |
137 | * Protected by nameseq.lock in name_table.c | 135 | * Protected by nameseq.lock in name_table.c |
138 | */ | 136 | */ |
139 | void tipc_subscr_report_overlap(struct tipc_subscription *sub, | 137 | void tipc_subscr_report_overlap(struct tipc_subscription *sub, u32 found_lower, |
140 | u32 found_lower, | 138 | u32 found_upper, u32 event, u32 port_ref, |
141 | u32 found_upper, | 139 | u32 node, int must) |
142 | u32 event, | ||
143 | u32 port_ref, | ||
144 | u32 node, | ||
145 | int must) | ||
146 | { | 140 | { |
147 | if (!tipc_subscr_overlap(sub, found_lower, found_upper)) | 141 | if (!tipc_subscr_overlap(sub, found_lower, found_upper)) |
148 | return; | 142 | return; |
diff --git a/net/tipc/subscr.h b/net/tipc/subscr.h index 43e6d6332a02..393e417bee3f 100644 --- a/net/tipc/subscr.h +++ b/net/tipc/subscr.h | |||
@@ -67,17 +67,12 @@ struct tipc_subscription { | |||
67 | struct tipc_event evt; | 67 | struct tipc_event evt; |
68 | }; | 68 | }; |
69 | 69 | ||
70 | int tipc_subscr_overlap(struct tipc_subscription *sub, | 70 | int tipc_subscr_overlap(struct tipc_subscription *sub, u32 found_lower, |
71 | u32 found_lower, | ||
72 | u32 found_upper); | 71 | u32 found_upper); |
73 | 72 | ||
74 | void tipc_subscr_report_overlap(struct tipc_subscription *sub, | 73 | void tipc_subscr_report_overlap(struct tipc_subscription *sub, u32 found_lower, |
75 | u32 found_lower, | 74 | u32 found_upper, u32 event, u32 port_ref, |
76 | u32 found_upper, | 75 | u32 node, int must); |
77 | u32 event, | ||
78 | u32 port_ref, | ||
79 | u32 node, | ||
80 | int must_report); | ||
81 | 76 | ||
82 | int tipc_subscr_start(void); | 77 | int tipc_subscr_start(void); |
83 | 78 | ||