diff options
author | Emmanuel Grumbach <emmanuel.grumbach@intel.com> | 2014-07-07 02:25:42 -0400 |
---|---|---|
committer | Emmanuel Grumbach <emmanuel.grumbach@intel.com> | 2014-07-21 03:20:55 -0400 |
commit | ae7486a2b734ee039bec94427c25317c589f1664 (patch) | |
tree | 88b710b0cc8818f0e01b74028a3054701b1e97e5 | |
parent | 745160ee10b76ed739f78f0116ab3d17b3f77309 (diff) |
iwlwifi: fix Kconfig issues
Randy fixes a few issues in iwlwifi's Kconfig. Because of
this, 'Debugging options' was not indented under iwlwifi
using menuconfig.
I added a few other fixes on the way, like the link to the
website and added 7265 in the supported NICs.
Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
[ Commit message + other fixes ]
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
-rw-r--r-- | drivers/net/wireless/iwlwifi/Kconfig | 25 |
1 files changed, 13 insertions, 12 deletions
diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig index 7fd50428b934..6451d2b6abcf 100644 --- a/drivers/net/wireless/iwlwifi/Kconfig +++ b/drivers/net/wireless/iwlwifi/Kconfig | |||
@@ -20,16 +20,17 @@ config IWLWIFI | |||
20 | Intel 2000 Series Wi-Fi Adapters | 20 | Intel 2000 Series Wi-Fi Adapters |
21 | Intel 7260 Wi-Fi Adapter | 21 | Intel 7260 Wi-Fi Adapter |
22 | Intel 3160 Wi-Fi Adapter | 22 | Intel 3160 Wi-Fi Adapter |
23 | Intel 7265 Wi-Fi Adapter | ||
23 | 24 | ||
24 | 25 | ||
25 | This driver uses the kernel's mac80211 subsystem. | 26 | This driver uses the kernel's mac80211 subsystem. |
26 | 27 | ||
27 | In order to use this driver, you will need a microcode (uCode) | 28 | In order to use this driver, you will need a firmware |
28 | image for it. You can obtain the microcode from: | 29 | image for it. You can obtain the microcode from: |
29 | 30 | ||
30 | <http://intellinuxwireless.org/>. | 31 | <http://wireless.kernel.org/en/users/Drivers/iwlwifi>. |
31 | 32 | ||
32 | The microcode is typically installed in /lib/firmware. You can | 33 | The firmware is typically installed in /lib/firmware. You can |
33 | look in the hotplug script /etc/hotplug/firmware.agent to | 34 | look in the hotplug script /etc/hotplug/firmware.agent to |
34 | determine which directory FIRMWARE_DIR is set to when the script | 35 | determine which directory FIRMWARE_DIR is set to when the script |
35 | runs. | 36 | runs. |
@@ -39,9 +40,10 @@ config IWLWIFI | |||
39 | say M here and read <file:Documentation/kbuild/modules.txt>. The | 40 | say M here and read <file:Documentation/kbuild/modules.txt>. The |
40 | module will be called iwlwifi. | 41 | module will be called iwlwifi. |
41 | 42 | ||
43 | if IWLWIFI | ||
44 | |||
42 | config IWLWIFI_LEDS | 45 | config IWLWIFI_LEDS |
43 | bool | 46 | bool |
44 | depends on IWLWIFI | ||
45 | depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI | 47 | depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI |
46 | select LEDS_TRIGGERS | 48 | select LEDS_TRIGGERS |
47 | select MAC80211_LEDS | 49 | select MAC80211_LEDS |
@@ -49,7 +51,7 @@ config IWLWIFI_LEDS | |||
49 | 51 | ||
50 | config IWLDVM | 52 | config IWLDVM |
51 | tristate "Intel Wireless WiFi DVM Firmware support" | 53 | tristate "Intel Wireless WiFi DVM Firmware support" |
52 | depends on IWLWIFI | 54 | depends on m |
53 | default IWLWIFI | 55 | default IWLWIFI |
54 | help | 56 | help |
55 | This is the driver that supports the DVM firmware which is | 57 | This is the driver that supports the DVM firmware which is |
@@ -58,7 +60,7 @@ config IWLDVM | |||
58 | 60 | ||
59 | config IWLMVM | 61 | config IWLMVM |
60 | tristate "Intel Wireless WiFi MVM Firmware support" | 62 | tristate "Intel Wireless WiFi MVM Firmware support" |
61 | depends on IWLWIFI | 63 | depends on m |
62 | help | 64 | help |
63 | This is the driver that supports the MVM firmware which is | 65 | This is the driver that supports the MVM firmware which is |
64 | currently only available for 7260 and 3160 devices. | 66 | currently only available for 7260 and 3160 devices. |
@@ -70,7 +72,7 @@ config IWLWIFI_OPMODE_MODULAR | |||
70 | default y if IWLMVM=m | 72 | default y if IWLMVM=m |
71 | 73 | ||
72 | comment "WARNING: iwlwifi is useless without IWLDVM or IWLMVM" | 74 | comment "WARNING: iwlwifi is useless without IWLDVM or IWLMVM" |
73 | depends on IWLWIFI && IWLDVM=n && IWLMVM=n | 75 | depends on IWLDVM=n && IWLMVM=n |
74 | 76 | ||
75 | config IWLWIFI_BCAST_FILTERING | 77 | config IWLWIFI_BCAST_FILTERING |
76 | bool "Enable broadcast filtering" | 78 | bool "Enable broadcast filtering" |
@@ -86,11 +88,9 @@ config IWLWIFI_BCAST_FILTERING | |||
86 | expect incoming broadcasts for their normal operations. | 88 | expect incoming broadcasts for their normal operations. |
87 | 89 | ||
88 | menu "Debugging Options" | 90 | menu "Debugging Options" |
89 | depends on IWLWIFI | ||
90 | 91 | ||
91 | config IWLWIFI_DEBUG | 92 | config IWLWIFI_DEBUG |
92 | bool "Enable full debugging output in the iwlwifi driver" | 93 | bool "Enable full debugging output in the iwlwifi driver" |
93 | depends on IWLWIFI | ||
94 | ---help--- | 94 | ---help--- |
95 | This option will enable debug tracing output for the iwlwifi drivers | 95 | This option will enable debug tracing output for the iwlwifi drivers |
96 | 96 | ||
@@ -115,7 +115,7 @@ config IWLWIFI_DEBUG | |||
115 | 115 | ||
116 | config IWLWIFI_DEBUGFS | 116 | config IWLWIFI_DEBUGFS |
117 | bool "iwlwifi debugfs support" | 117 | bool "iwlwifi debugfs support" |
118 | depends on IWLWIFI && MAC80211_DEBUGFS | 118 | depends on MAC80211_DEBUGFS |
119 | ---help--- | 119 | ---help--- |
120 | Enable creation of debugfs files for the iwlwifi drivers. This | 120 | Enable creation of debugfs files for the iwlwifi drivers. This |
121 | is a low-impact option that allows getting insight into the | 121 | is a low-impact option that allows getting insight into the |
@@ -123,13 +123,12 @@ config IWLWIFI_DEBUGFS | |||
123 | 123 | ||
124 | config IWLWIFI_DEBUG_EXPERIMENTAL_UCODE | 124 | config IWLWIFI_DEBUG_EXPERIMENTAL_UCODE |
125 | bool "Experimental uCode support" | 125 | bool "Experimental uCode support" |
126 | depends on IWLWIFI && IWLWIFI_DEBUG | 126 | depends on IWLWIFI_DEBUG |
127 | ---help--- | 127 | ---help--- |
128 | Enable use of experimental ucode for testing and debugging. | 128 | Enable use of experimental ucode for testing and debugging. |
129 | 129 | ||
130 | config IWLWIFI_DEVICE_TRACING | 130 | config IWLWIFI_DEVICE_TRACING |
131 | bool "iwlwifi device access tracing" | 131 | bool "iwlwifi device access tracing" |
132 | depends on IWLWIFI | ||
133 | depends on EVENT_TRACING | 132 | depends on EVENT_TRACING |
134 | help | 133 | help |
135 | Say Y here to trace all commands, including TX frames and IO | 134 | Say Y here to trace all commands, including TX frames and IO |
@@ -145,3 +144,5 @@ config IWLWIFI_DEVICE_TRACING | |||
145 | If unsure, say Y so we can help you better when problems | 144 | If unsure, say Y so we can help you better when problems |
146 | occur. | 145 | occur. |
147 | endmenu | 146 | endmenu |
147 | |||
148 | endif | ||