diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2013-10-30 20:40:30 -0400 |
---|---|---|
committer | Vinod Koul <vinod.koul@intel.com> | 2013-10-31 09:36:22 -0400 |
commit | ac806a1c880d07753e54fb80aa3a70365a58652d (patch) | |
tree | 8d8fbf7f90aeae7bf9a423b76a39088870305c92 | |
parent | 2abd5f1b97fce6e197be01d67a9567c7793c80d3 (diff) |
dmaengine: imx-dma: fix format warnings
drivers/dma/imx-dma.c:575:3: warning: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'dma_addr_t'
drivers/dma/imx-dma.c:575:3: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'dma_addr_t'
drivers/dma/imx-dma.c:589:4: warning: format '%x' expects argument of type 'unsigned int', but argument 9 has type 'dma_addr_t'
drivers/dma/imx-dma.c:599:4: warning: format '%x' expects argument of type 'unsigned int', but argument 9 has type 'dma_addr_t'
drivers/dma/imx-dma.c:929:2: warning: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'dma_addr_t'
drivers/dma/imx-dma.c:929:2: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'dma_addr_t'
drivers/dma/imx-dma.c:959:2: warning: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'dma_addr_t'
drivers/dma/imx-dma.c:959:2: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'dma_addr_t'
We can't use the %pa format for these because this relates to phys_addr_t,
and dma_addr_t can be a different size. So, fix these by converting them
to %llx and casting the dma_addr_t to always be unsigned long long.
While we're here, also use %zu for size_t.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
-rw-r--r-- | drivers/dma/imx-dma.c | 40 |
1 files changed, 23 insertions, 17 deletions
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c index 55852c026791..1c0d85d56562 100644 --- a/drivers/dma/imx-dma.c +++ b/drivers/dma/imx-dma.c | |||
@@ -572,9 +572,11 @@ static int imxdma_xfer_desc(struct imxdma_desc *d) | |||
572 | 572 | ||
573 | imx_dmav1_writel(imxdma, d->len, DMA_CNTR(imxdmac->channel)); | 573 | imx_dmav1_writel(imxdma, d->len, DMA_CNTR(imxdmac->channel)); |
574 | 574 | ||
575 | dev_dbg(imxdma->dev, "%s channel: %d dest=0x%08x src=0x%08x " | 575 | dev_dbg(imxdma->dev, |
576 | "dma_length=%d\n", __func__, imxdmac->channel, | 576 | "%s channel: %d dest=0x%08llx src=0x%08llx dma_length=%zu\n", |
577 | d->dest, d->src, d->len); | 577 | __func__, imxdmac->channel, |
578 | (unsigned long long)d->dest, | ||
579 | (unsigned long long)d->src, d->len); | ||
578 | 580 | ||
579 | break; | 581 | break; |
580 | /* Cyclic transfer is the same as slave_sg with special sg configuration. */ | 582 | /* Cyclic transfer is the same as slave_sg with special sg configuration. */ |
@@ -586,20 +588,22 @@ static int imxdma_xfer_desc(struct imxdma_desc *d) | |||
586 | imx_dmav1_writel(imxdma, imxdmac->ccr_from_device, | 588 | imx_dmav1_writel(imxdma, imxdmac->ccr_from_device, |
587 | DMA_CCR(imxdmac->channel)); | 589 | DMA_CCR(imxdmac->channel)); |
588 | 590 | ||
589 | dev_dbg(imxdma->dev, "%s channel: %d sg=%p sgcount=%d " | 591 | dev_dbg(imxdma->dev, |
590 | "total length=%d dev_addr=0x%08x (dev2mem)\n", | 592 | "%s channel: %d sg=%p sgcount=%d total length=%zu dev_addr=0x%08llx (dev2mem)\n", |
591 | __func__, imxdmac->channel, d->sg, d->sgcount, | 593 | __func__, imxdmac->channel, |
592 | d->len, imxdmac->per_address); | 594 | d->sg, d->sgcount, d->len, |
595 | (unsigned long long)imxdmac->per_address); | ||
593 | } else if (d->direction == DMA_MEM_TO_DEV) { | 596 | } else if (d->direction == DMA_MEM_TO_DEV) { |
594 | imx_dmav1_writel(imxdma, imxdmac->per_address, | 597 | imx_dmav1_writel(imxdma, imxdmac->per_address, |
595 | DMA_DAR(imxdmac->channel)); | 598 | DMA_DAR(imxdmac->channel)); |
596 | imx_dmav1_writel(imxdma, imxdmac->ccr_to_device, | 599 | imx_dmav1_writel(imxdma, imxdmac->ccr_to_device, |
597 | DMA_CCR(imxdmac->channel)); | 600 | DMA_CCR(imxdmac->channel)); |
598 | 601 | ||
599 | dev_dbg(imxdma->dev, "%s channel: %d sg=%p sgcount=%d " | 602 | dev_dbg(imxdma->dev, |
600 | "total length=%d dev_addr=0x%08x (mem2dev)\n", | 603 | "%s channel: %d sg=%p sgcount=%d total length=%zu dev_addr=0x%08llx (mem2dev)\n", |
601 | __func__, imxdmac->channel, d->sg, d->sgcount, | 604 | __func__, imxdmac->channel, |
602 | d->len, imxdmac->per_address); | 605 | d->sg, d->sgcount, d->len, |
606 | (unsigned long long)imxdmac->per_address); | ||
603 | } else { | 607 | } else { |
604 | dev_err(imxdma->dev, "%s channel: %d bad dma mode\n", | 608 | dev_err(imxdma->dev, "%s channel: %d bad dma mode\n", |
605 | __func__, imxdmac->channel); | 609 | __func__, imxdmac->channel); |
@@ -870,7 +874,7 @@ static struct dma_async_tx_descriptor *imxdma_prep_dma_cyclic( | |||
870 | int i; | 874 | int i; |
871 | unsigned int periods = buf_len / period_len; | 875 | unsigned int periods = buf_len / period_len; |
872 | 876 | ||
873 | dev_dbg(imxdma->dev, "%s channel: %d buf_len=%d period_len=%d\n", | 877 | dev_dbg(imxdma->dev, "%s channel: %d buf_len=%zu period_len=%zu\n", |
874 | __func__, imxdmac->channel, buf_len, period_len); | 878 | __func__, imxdmac->channel, buf_len, period_len); |
875 | 879 | ||
876 | if (list_empty(&imxdmac->ld_free) || | 880 | if (list_empty(&imxdmac->ld_free) || |
@@ -926,8 +930,9 @@ static struct dma_async_tx_descriptor *imxdma_prep_dma_memcpy( | |||
926 | struct imxdma_engine *imxdma = imxdmac->imxdma; | 930 | struct imxdma_engine *imxdma = imxdmac->imxdma; |
927 | struct imxdma_desc *desc; | 931 | struct imxdma_desc *desc; |
928 | 932 | ||
929 | dev_dbg(imxdma->dev, "%s channel: %d src=0x%x dst=0x%x len=%d\n", | 933 | dev_dbg(imxdma->dev, "%s channel: %d src=0x%llx dst=0x%llx len=%zu\n", |
930 | __func__, imxdmac->channel, src, dest, len); | 934 | __func__, imxdmac->channel, (unsigned long long)src, |
935 | (unsigned long long)dest, len); | ||
931 | 936 | ||
932 | if (list_empty(&imxdmac->ld_free) || | 937 | if (list_empty(&imxdmac->ld_free) || |
933 | imxdma_chan_is_doing_cyclic(imxdmac)) | 938 | imxdma_chan_is_doing_cyclic(imxdmac)) |
@@ -956,9 +961,10 @@ static struct dma_async_tx_descriptor *imxdma_prep_dma_interleaved( | |||
956 | struct imxdma_engine *imxdma = imxdmac->imxdma; | 961 | struct imxdma_engine *imxdma = imxdmac->imxdma; |
957 | struct imxdma_desc *desc; | 962 | struct imxdma_desc *desc; |
958 | 963 | ||
959 | dev_dbg(imxdma->dev, "%s channel: %d src_start=0x%x dst_start=0x%x\n" | 964 | dev_dbg(imxdma->dev, "%s channel: %d src_start=0x%llx dst_start=0x%llx\n" |
960 | " src_sgl=%s dst_sgl=%s numf=%d frame_size=%d\n", __func__, | 965 | " src_sgl=%s dst_sgl=%s numf=%zu frame_size=%zu\n", __func__, |
961 | imxdmac->channel, xt->src_start, xt->dst_start, | 966 | imxdmac->channel, (unsigned long long)xt->src_start, |
967 | (unsigned long long) xt->dst_start, | ||
962 | xt->src_sgl ? "true" : "false", xt->dst_sgl ? "true" : "false", | 968 | xt->src_sgl ? "true" : "false", xt->dst_sgl ? "true" : "false", |
963 | xt->numf, xt->frame_size); | 969 | xt->numf, xt->frame_size); |
964 | 970 | ||