aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2014-03-20 17:36:23 -0400
committerDavid S. Miller <davem@davemloft.net>2014-03-20 17:36:23 -0400
commita85ae0e97879f51bccd8511668b07d346d98b3eb (patch)
tree56c547038a9a6eaec0068e9e2798b07f56dc3603
parent3907c432cb7e1f1e9143e8ac97e4b9a4c3f153bc (diff)
parentb2cde2cc71f2382e4a4bfaaacd5263bd93f1e0d2 (diff)
Merge branch 'bcmgenet-next'
Florian Fainelli says: ==================== net: bcmgenet: misc fixes This patch series contains some misc. fixes for the bcmgenet driver. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/broadcom/genet/bcmgenet.c23
-rw-r--r--drivers/net/ethernet/broadcom/genet/bcmgenet.h1
2 files changed, 10 insertions, 14 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 72ce6e8115fa..8f87fe001541 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -868,10 +868,12 @@ static void __bcmgenet_tx_reclaim(struct net_device *dev,
868 struct bcmgenet_priv *priv = netdev_priv(dev); 868 struct bcmgenet_priv *priv = netdev_priv(dev);
869 int last_tx_cn, last_c_index, num_tx_bds; 869 int last_tx_cn, last_c_index, num_tx_bds;
870 struct enet_cb *tx_cb_ptr; 870 struct enet_cb *tx_cb_ptr;
871 struct netdev_queue *txq;
871 unsigned int c_index; 872 unsigned int c_index;
872 873
873 /* Compute how many buffers are transmited since last xmit call */ 874 /* Compute how many buffers are transmited since last xmit call */
874 c_index = bcmgenet_tdma_ring_readl(priv, ring->index, TDMA_CONS_INDEX); 875 c_index = bcmgenet_tdma_ring_readl(priv, ring->index, TDMA_CONS_INDEX);
876 txq = netdev_get_tx_queue(dev, ring->queue);
875 877
876 last_c_index = ring->c_index; 878 last_c_index = ring->c_index;
877 num_tx_bds = ring->size; 879 num_tx_bds = ring->size;
@@ -917,8 +919,8 @@ static void __bcmgenet_tx_reclaim(struct net_device *dev,
917 if (ring->free_bds > (MAX_SKB_FRAGS + 1)) 919 if (ring->free_bds > (MAX_SKB_FRAGS + 1))
918 ring->int_disable(priv, ring); 920 ring->int_disable(priv, ring);
919 921
920 if (__netif_subqueue_stopped(dev, ring->queue)) 922 if (netif_tx_queue_stopped(txq))
921 netif_wake_subqueue(dev, ring->queue); 923 netif_tx_wake_queue(txq);
922 924
923 ring->c_index = c_index; 925 ring->c_index = c_index;
924} 926}
@@ -1106,6 +1108,7 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev)
1106{ 1108{
1107 struct bcmgenet_priv *priv = netdev_priv(dev); 1109 struct bcmgenet_priv *priv = netdev_priv(dev);
1108 struct bcmgenet_tx_ring *ring = NULL; 1110 struct bcmgenet_tx_ring *ring = NULL;
1111 struct netdev_queue *txq;
1109 unsigned long flags = 0; 1112 unsigned long flags = 0;
1110 int nr_frags, index; 1113 int nr_frags, index;
1111 u16 dma_desc_flags; 1114 u16 dma_desc_flags;
@@ -1125,20 +1128,13 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev)
1125 else 1128 else
1126 index -= 1; 1129 index -= 1;
1127 1130
1128 if ((index != DESC_INDEX) && (index > priv->hw_params->tx_queues - 1)) {
1129 netdev_err(dev, "%s: queue_mapping %d is invalid\n",
1130 __func__, skb_get_queue_mapping(skb));
1131 dev->stats.tx_errors++;
1132 dev->stats.tx_dropped++;
1133 ret = NETDEV_TX_OK;
1134 goto out;
1135 }
1136 nr_frags = skb_shinfo(skb)->nr_frags; 1131 nr_frags = skb_shinfo(skb)->nr_frags;
1137 ring = &priv->tx_rings[index]; 1132 ring = &priv->tx_rings[index];
1133 txq = netdev_get_tx_queue(dev, ring->queue);
1138 1134
1139 spin_lock_irqsave(&ring->lock, flags); 1135 spin_lock_irqsave(&ring->lock, flags);
1140 if (ring->free_bds <= nr_frags + 1) { 1136 if (ring->free_bds <= nr_frags + 1) {
1141 netif_stop_subqueue(dev, ring->queue); 1137 netif_tx_stop_queue(txq);
1142 netdev_err(dev, "%s: tx ring %d full when queue %d awake\n", 1138 netdev_err(dev, "%s: tx ring %d full when queue %d awake\n",
1143 __func__, index, ring->queue); 1139 __func__, index, ring->queue);
1144 ret = NETDEV_TX_BUSY; 1140 ret = NETDEV_TX_BUSY;
@@ -1176,6 +1172,8 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev)
1176 } 1172 }
1177 } 1173 }
1178 1174
1175 skb_tx_timestamp(skb);
1176
1179 /* we kept a software copy of how much we should advance the TDMA 1177 /* we kept a software copy of how much we should advance the TDMA
1180 * producer index, now write it down to the hardware 1178 * producer index, now write it down to the hardware
1181 */ 1179 */
@@ -1183,7 +1181,7 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev)
1183 ring->prod_index, TDMA_PROD_INDEX); 1181 ring->prod_index, TDMA_PROD_INDEX);
1184 1182
1185 if (ring->free_bds <= (MAX_SKB_FRAGS + 1)) { 1183 if (ring->free_bds <= (MAX_SKB_FRAGS + 1)) {
1186 netif_stop_subqueue(dev, ring->queue); 1184 netif_tx_stop_queue(txq);
1187 ring->int_enable(priv, ring); 1185 ring->int_enable(priv, ring);
1188 } 1186 }
1189 1187
@@ -2498,7 +2496,6 @@ static int bcmgenet_probe(struct platform_device *pdev)
2498 2496
2499 bcmgenet_set_hw_params(priv); 2497 bcmgenet_set_hw_params(priv);
2500 2498
2501 spin_lock_init(&priv->lock);
2502 /* Mii wait queue */ 2499 /* Mii wait queue */
2503 init_waitqueue_head(&priv->wq); 2500 init_waitqueue_head(&priv->wq);
2504 /* Always use RX_BUF_LENGTH (2KB) buffer for all chips */ 2501 /* Always use RX_BUF_LENGTH (2KB) buffer for all chips */
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
index a6758adefaab..0f117105fed1 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.h
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
@@ -523,7 +523,6 @@ struct bcmgenet_priv {
523 void __iomem *base; 523 void __iomem *base;
524 enum bcmgenet_version version; 524 enum bcmgenet_version version;
525 struct net_device *dev; 525 struct net_device *dev;
526 spinlock_t lock;
527 u32 int0_mask; 526 u32 int0_mask;
528 u32 int1_mask; 527 u32 int1_mask;
529 528