aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Gortmaker <paul.gortmaker@windriver.com>2013-01-30 21:49:29 -0500
committerPaul Gortmaker <paul.gortmaker@windriver.com>2013-01-31 19:20:33 -0500
commita786a7c0ad44985548118fd2370c792c0da36891 (patch)
tree506d699d86f31aafe7c55a198458011983cf5ae6
parent1b13c97fae9c61dc20db8e0d0a72a29df29ac377 (diff)
wanrouter: completely decouple obsolete code from kernel.
The original suggestion to delete wanrouter started earlier with the mainline commit f0d1b3c2bcc5de8a17af5f2274f7fcde8292b5fc ("net/wanrouter: Deprecate and schedule for removal") in May 2012. More importantly, Dan Carpenter found[1] that the driver had a fundamental breakage introduced back in 2008, with commit 7be6065b39c3 ("netdevice wanrouter: Convert directly reference of netdev->priv"). So we know with certainty that the code hasn't been used by anyone willing to at least take the effort to send an e-mail report of breakage for at least 4 years. This commit does a decouple of the wanrouter subsystem, by going after the Makefile/Kconfig and similar files, so that these mainline files that we are keeping do not have the big wanrouter file/driver deletion commit tied into their history. Once this commit is in place, we then can remove the obsolete cyclomx drivers and similar that have a dependency on CONFIG_WAN_ROUTER_DRIVERS. [1] http://www.spinics.net/lists/netdev/msg218670.html Originally-by: Joe Perches <joe@perches.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
-rw-r--r--Documentation/ioctl/ioctl-number.txt2
-rw-r--r--Documentation/magic-number.txt2
-rw-r--r--Documentation/zh_CN/magic-number.txt2
-rw-r--r--drivers/isdn/i4l/isdn_x25iface.h1
-rw-r--r--drivers/net/wan/Kconfig54
-rw-r--r--drivers/net/wan/Makefile5
-rw-r--r--net/Kconfig1
-rw-r--r--net/Makefile1
-rw-r--r--net/socket.c1
9 files changed, 3 insertions, 66 deletions
diff --git a/Documentation/ioctl/ioctl-number.txt b/Documentation/ioctl/ioctl-number.txt
index 2152b0e7237d..3210540f8bd3 100644
--- a/Documentation/ioctl/ioctl-number.txt
+++ b/Documentation/ioctl/ioctl-number.txt
@@ -179,7 +179,7 @@ Code Seq#(hex) Include File Comments
179'V' C0 media/davinci/vpfe_capture.h conflict! 179'V' C0 media/davinci/vpfe_capture.h conflict!
180'V' C0 media/si4713.h conflict! 180'V' C0 media/si4713.h conflict!
181'W' 00-1F linux/watchdog.h conflict! 181'W' 00-1F linux/watchdog.h conflict!
182'W' 00-1F linux/wanrouter.h conflict! 182'W' 00-1F linux/wanrouter.h conflict! (pre 3.9)
183'W' 00-3F sound/asound.h conflict! 183'W' 00-3F sound/asound.h conflict!
184'X' all fs/xfs/xfs_fs.h conflict! 184'X' all fs/xfs/xfs_fs.h conflict!
185 and fs/xfs/linux-2.6/xfs_ioctl32.h 185 and fs/xfs/linux-2.6/xfs_ioctl32.h
diff --git a/Documentation/magic-number.txt b/Documentation/magic-number.txt
index 82761a31d64d..76d80a64bbe1 100644
--- a/Documentation/magic-number.txt
+++ b/Documentation/magic-number.txt
@@ -122,7 +122,7 @@ SLAB_C_MAGIC 0x4f17a36d kmem_cache mm/slab.c
122COW_MAGIC 0x4f4f4f4d cow_header_v1 arch/um/drivers/ubd_user.c 122COW_MAGIC 0x4f4f4f4d cow_header_v1 arch/um/drivers/ubd_user.c
123I810_CARD_MAGIC 0x5072696E i810_card sound/oss/i810_audio.c 123I810_CARD_MAGIC 0x5072696E i810_card sound/oss/i810_audio.c
124TRIDENT_CARD_MAGIC 0x5072696E trident_card sound/oss/trident.c 124TRIDENT_CARD_MAGIC 0x5072696E trident_card sound/oss/trident.c
125ROUTER_MAGIC 0x524d4157 wan_device include/linux/wanrouter.h 125ROUTER_MAGIC 0x524d4157 wan_device [in wanrouter.h pre 3.9]
126SCC_MAGIC 0x52696368 gs_port drivers/char/scc.h 126SCC_MAGIC 0x52696368 gs_port drivers/char/scc.h
127SAVEKMSG_MAGIC1 0x53415645 savekmsg arch/*/amiga/config.c 127SAVEKMSG_MAGIC1 0x53415645 savekmsg arch/*/amiga/config.c
128GDA_MAGIC 0x58464552 gda arch/mips/include/asm/sn/gda.h 128GDA_MAGIC 0x58464552 gda arch/mips/include/asm/sn/gda.h
diff --git a/Documentation/zh_CN/magic-number.txt b/Documentation/zh_CN/magic-number.txt
index 4263022f5002..2ebe539f5450 100644
--- a/Documentation/zh_CN/magic-number.txt
+++ b/Documentation/zh_CN/magic-number.txt
@@ -122,7 +122,7 @@ SLAB_C_MAGIC 0x4f17a36d kmem_cache mm/slab.c
122COW_MAGIC 0x4f4f4f4d cow_header_v1 arch/um/drivers/ubd_user.c 122COW_MAGIC 0x4f4f4f4d cow_header_v1 arch/um/drivers/ubd_user.c
123I810_CARD_MAGIC 0x5072696E i810_card sound/oss/i810_audio.c 123I810_CARD_MAGIC 0x5072696E i810_card sound/oss/i810_audio.c
124TRIDENT_CARD_MAGIC 0x5072696E trident_card sound/oss/trident.c 124TRIDENT_CARD_MAGIC 0x5072696E trident_card sound/oss/trident.c
125ROUTER_MAGIC 0x524d4157 wan_device include/linux/wanrouter.h 125ROUTER_MAGIC 0x524d4157 wan_device [in wanrouter.h pre 3.9]
126SCC_MAGIC 0x52696368 gs_port drivers/char/scc.h 126SCC_MAGIC 0x52696368 gs_port drivers/char/scc.h
127SAVEKMSG_MAGIC1 0x53415645 savekmsg arch/*/amiga/config.c 127SAVEKMSG_MAGIC1 0x53415645 savekmsg arch/*/amiga/config.c
128GDA_MAGIC 0x58464552 gda arch/mips/include/asm/sn/gda.h 128GDA_MAGIC 0x58464552 gda arch/mips/include/asm/sn/gda.h
diff --git a/drivers/isdn/i4l/isdn_x25iface.h b/drivers/isdn/i4l/isdn_x25iface.h
index 0b26e3b336e7..ca08e082cf7c 100644
--- a/drivers/isdn/i4l/isdn_x25iface.h
+++ b/drivers/isdn/i4l/isdn_x25iface.h
@@ -19,7 +19,6 @@
19#endif 19#endif
20 20
21#include <linux/skbuff.h> 21#include <linux/skbuff.h>
22#include <linux/wanrouter.h>
23#include <linux/isdn.h> 22#include <linux/isdn.h>
24#include <linux/concap.h> 23#include <linux/concap.h>
25 24
diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
index d58431e99f73..0c077b0f7a2b 100644
--- a/drivers/net/wan/Kconfig
+++ b/drivers/net/wan/Kconfig
@@ -356,60 +356,6 @@ config SDLA
356 To compile this driver as a module, choose M here: the 356 To compile this driver as a module, choose M here: the
357 module will be called sdla. 357 module will be called sdla.
358 358
359# Wan router core.
360config WAN_ROUTER_DRIVERS
361 tristate "WAN router drivers"
362 depends on WAN_ROUTER
363 ---help---
364 Connect LAN to WAN via Linux box.
365
366 Select driver your card and remember to say Y to "Wan Router."
367 You will need the wan-tools package which is available from
368 <ftp://ftp.sangoma.com/>.
369
370 Note that the answer to this question won't directly affect the
371 kernel except for how subordinate drivers may be built:
372 saying N will just cause the configurator to skip all
373 the questions about WAN router drivers.
374
375 If unsure, say N.
376
377config CYCLADES_SYNC
378 tristate "Cyclom 2X(tm) cards (EXPERIMENTAL)"
379 depends on WAN_ROUTER_DRIVERS && (PCI || ISA)
380 ---help---
381 Cyclom 2X from Cyclades Corporation <http://www.avocent.com/> is an
382 intelligent multiprotocol WAN adapter with data transfer rates up to
383 512 Kbps. These cards support the X.25 and SNA related protocols.
384
385 While no documentation is available at this time please grab the
386 wanconfig tarball in
387 <http://www.conectiva.com.br/~acme/cycsyn-devel/> (with minor changes
388 to make it compile with the current wanrouter include files; efforts
389 are being made to use the original package available at
390 <ftp://ftp.sangoma.com/>).
391
392 Feel free to contact me or the cycsyn-devel mailing list at
393 <acme@conectiva.com.br> and <cycsyn-devel@bazar.conectiva.com.br> for
394 additional details, I hope to have documentation available as soon as
395 possible. (Cyclades Brazil is writing the Documentation).
396
397 The next questions will ask you about the protocols you want the
398 driver to support (for now only X.25 is supported).
399
400 If you have one or more of these cards, say Y to this option.
401
402 To compile this driver as a module, choose M here: the
403 module will be called cyclomx.
404
405config CYCLOMX_X25
406 bool "Cyclom 2X X.25 support (EXPERIMENTAL)"
407 depends on CYCLADES_SYNC
408 help
409 Connect a Cyclom 2X card to an X.25 network.
410
411 Enabling X.25 support will enlarge your kernel by about 11 kB.
412
413# X.25 network drivers 359# X.25 network drivers
414config LAPBETHER 360config LAPBETHER
415 tristate "LAPB over Ethernet driver (EXPERIMENTAL)" 361 tristate "LAPB over Ethernet driver (EXPERIMENTAL)"
diff --git a/drivers/net/wan/Makefile b/drivers/net/wan/Makefile
index df70248e2fda..c135ef47cbca 100644
--- a/drivers/net/wan/Makefile
+++ b/drivers/net/wan/Makefile
@@ -5,10 +5,6 @@
5# Rewritten to use lists instead of if-statements. 5# Rewritten to use lists instead of if-statements.
6# 6#
7 7
8cyclomx-y := cycx_main.o
9cyclomx-$(CONFIG_CYCLOMX_X25) += cycx_x25.o
10cyclomx-objs := $(cyclomx-y)
11
12obj-$(CONFIG_HDLC) += hdlc.o 8obj-$(CONFIG_HDLC) += hdlc.o
13obj-$(CONFIG_HDLC_RAW) += hdlc_raw.o 9obj-$(CONFIG_HDLC_RAW) += hdlc_raw.o
14obj-$(CONFIG_HDLC_RAW_ETH) += hdlc_raw_eth.o 10obj-$(CONFIG_HDLC_RAW_ETH) += hdlc_raw_eth.o
@@ -28,7 +24,6 @@ obj-$(CONFIG_LANMEDIA) += lmc/
28 24
29obj-$(CONFIG_DLCI) += dlci.o 25obj-$(CONFIG_DLCI) += dlci.o
30obj-$(CONFIG_SDLA) += sdla.o 26obj-$(CONFIG_SDLA) += sdla.o
31obj-$(CONFIG_CYCLADES_SYNC) += cycx_drv.o cyclomx.o
32obj-$(CONFIG_LAPBETHER) += lapbether.o 27obj-$(CONFIG_LAPBETHER) += lapbether.o
33obj-$(CONFIG_SBNI) += sbni.o 28obj-$(CONFIG_SBNI) += sbni.o
34obj-$(CONFIG_N2) += n2.o 29obj-$(CONFIG_N2) += n2.o
diff --git a/net/Kconfig b/net/Kconfig
index 3cc5be0fe420..c31348e70aad 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -209,7 +209,6 @@ source "net/ipx/Kconfig"
209source "drivers/net/appletalk/Kconfig" 209source "drivers/net/appletalk/Kconfig"
210source "net/x25/Kconfig" 210source "net/x25/Kconfig"
211source "net/lapb/Kconfig" 211source "net/lapb/Kconfig"
212source "net/wanrouter/Kconfig"
213source "net/phonet/Kconfig" 212source "net/phonet/Kconfig"
214source "net/ieee802154/Kconfig" 213source "net/ieee802154/Kconfig"
215source "net/mac802154/Kconfig" 214source "net/mac802154/Kconfig"
diff --git a/net/Makefile b/net/Makefile
index 4f4ee083064c..c5aa8b3b49dc 100644
--- a/net/Makefile
+++ b/net/Makefile
@@ -26,7 +26,6 @@ obj-$(CONFIG_BRIDGE) += bridge/
26obj-$(CONFIG_NET_DSA) += dsa/ 26obj-$(CONFIG_NET_DSA) += dsa/
27obj-$(CONFIG_IPX) += ipx/ 27obj-$(CONFIG_IPX) += ipx/
28obj-$(CONFIG_ATALK) += appletalk/ 28obj-$(CONFIG_ATALK) += appletalk/
29obj-$(CONFIG_WAN_ROUTER) += wanrouter/
30obj-$(CONFIG_X25) += x25/ 29obj-$(CONFIG_X25) += x25/
31obj-$(CONFIG_LAPB) += lapb/ 30obj-$(CONFIG_LAPB) += lapb/
32obj-$(CONFIG_NETROM) += netrom/ 31obj-$(CONFIG_NETROM) += netrom/
diff --git a/net/socket.c b/net/socket.c
index 2ca51c719ef9..5c4d82c05293 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -69,7 +69,6 @@
69#include <linux/proc_fs.h> 69#include <linux/proc_fs.h>
70#include <linux/seq_file.h> 70#include <linux/seq_file.h>
71#include <linux/mutex.h> 71#include <linux/mutex.h>
72#include <linux/wanrouter.h>
73#include <linux/if_bridge.h> 72#include <linux/if_bridge.h>
74#include <linux/if_frad.h> 73#include <linux/if_frad.h>
75#include <linux/if_vlan.h> 74#include <linux/if_vlan.h>