aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Jackson <Andrew.Jackson@arm.com>2014-12-30 05:55:43 -0500
committerMark Brown <broonie@kernel.org>2014-12-30 11:46:14 -0500
commita56257c657eab392d579e6be70e2f8430eef1aa3 (patch)
tree06db4dee5e85a633d41328e43612feef67306580
parentafa8603c6253204bf96c88739f711e89c2b00cd5 (diff)
ASoC: dwc: Switch to managed clock resource
Simplify error handling during probe by using managed clock resources. Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/dwc/designware_i2s.c10
1 files changed, 2 insertions, 8 deletions
diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
index 23a7c13b914f..10219b5be436 100644
--- a/sound/soc/dwc/designware_i2s.c
+++ b/sound/soc/dwc/designware_i2s.c
@@ -396,13 +396,13 @@ static int dw_i2s_probe(struct platform_device *pdev)
396 396
397 dev->capability = pdata->cap; 397 dev->capability = pdata->cap;
398 dev->i2s_clk_cfg = pdata->i2s_clk_cfg; 398 dev->i2s_clk_cfg = pdata->i2s_clk_cfg;
399 dev->clk = clk_get(&pdev->dev, NULL); 399 dev->clk = devm_clk_get(&pdev->dev, NULL);
400 if (IS_ERR(dev->clk)) 400 if (IS_ERR(dev->clk))
401 return PTR_ERR(dev->clk); 401 return PTR_ERR(dev->clk);
402 402
403 ret = clk_enable(dev->clk); 403 ret = clk_enable(dev->clk);
404 if (ret < 0) 404 if (ret < 0)
405 goto err_clk_put; 405 return ret;
406 406
407 dev_set_drvdata(&pdev->dev, dev); 407 dev_set_drvdata(&pdev->dev, dev);
408 ret = snd_soc_register_component(&pdev->dev, &dw_i2s_component, 408 ret = snd_soc_register_component(&pdev->dev, &dw_i2s_component,
@@ -416,19 +416,13 @@ static int dw_i2s_probe(struct platform_device *pdev)
416 416
417err_clk_disable: 417err_clk_disable:
418 clk_disable(dev->clk); 418 clk_disable(dev->clk);
419err_clk_put:
420 clk_put(dev->clk);
421 return ret; 419 return ret;
422} 420}
423 421
424static int dw_i2s_remove(struct platform_device *pdev) 422static int dw_i2s_remove(struct platform_device *pdev)
425{ 423{
426 struct dw_i2s_dev *dev = dev_get_drvdata(&pdev->dev);
427
428 snd_soc_unregister_component(&pdev->dev); 424 snd_soc_unregister_component(&pdev->dev);
429 425
430 clk_put(dev->clk);
431
432 return 0; 426 return 0;
433} 427}
434 428