aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFelipe Balbi <balbi@ti.com>2014-11-20 11:12:32 -0500
committerFelipe Balbi <balbi@ti.com>2014-11-20 11:12:32 -0500
commita4722fd3f2d3590af5200890b61dbbdf87480abb (patch)
tree6f24ac4b74a5816608ac69e748f51d6fa831de9a
parentf905bc68833b37b2274dc269fd35edb19e67aed7 (diff)
usb: dwc3: trace: don't save pointers
There was another instance where we were holding pointers which could be long gone. Fix that by caching only values pointed to by such pointer. Because no crash has been observed, this patch will be sent on v3.19 merge window, instead of -rc. Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r--drivers/usb/dwc3/trace.h12
1 files changed, 8 insertions, 4 deletions
diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h
index 7a9d7804193c..9fc20b33dd8e 100644
--- a/drivers/usb/dwc3/trace.h
+++ b/drivers/usb/dwc3/trace.h
@@ -175,17 +175,21 @@ DECLARE_EVENT_CLASS(dwc3_log_gadget_ep_cmd,
175 TP_STRUCT__entry( 175 TP_STRUCT__entry(
176 __dynamic_array(char, name, DWC3_MSG_MAX) 176 __dynamic_array(char, name, DWC3_MSG_MAX)
177 __field(unsigned int, cmd) 177 __field(unsigned int, cmd)
178 __field(struct dwc3_gadget_ep_cmd_params *, params) 178 __field(u32, param0)
179 __field(u32, param1)
180 __field(u32, param2)
179 ), 181 ),
180 TP_fast_assign( 182 TP_fast_assign(
181 snprintf(__get_str(name), DWC3_MSG_MAX, "%s", dep->name); 183 snprintf(__get_str(name), DWC3_MSG_MAX, "%s", dep->name);
182 __entry->cmd = cmd; 184 __entry->cmd = cmd;
183 __entry->params = params; 185 __entry->param0 = params->param0;
186 __entry->param1 = params->param1;
187 __entry->param2 = params->param2;
184 ), 188 ),
185 TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x", 189 TP_printk("%s: cmd '%s' [%d] params %08x %08x %08x",
186 __get_str(name), dwc3_gadget_ep_cmd_string(__entry->cmd), 190 __get_str(name), dwc3_gadget_ep_cmd_string(__entry->cmd),
187 __entry->cmd, __entry->params->param0, 191 __entry->cmd, __entry->param0,
188 __entry->params->param1, __entry->params->param2 192 __entry->param1, __entry->param2
189 ) 193 )
190); 194);
191 195