diff options
author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-02-26 12:36:38 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-03-04 17:47:05 -0500 |
commit | a4573c488dd531c6e2d308ce8a7413c4a2646207 (patch) | |
tree | 2af19d9bb4472d77d057f2c5170f275cf5757765 | |
parent | d47846c5866b7d98a1173c86a39d810a06647329 (diff) |
kobject: properly initialize ksets
kset_initialize was calling kobject_init_internal() which didn't
initialize the kobject as well as kobject_init() was. So have
kobject_init() call kobject_init_internal() and move the logic to
initalize the kobject there.
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | lib/kobject.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/lib/kobject.c b/lib/kobject.c index d784daeb8571..0d03252f87a8 100644 --- a/lib/kobject.c +++ b/lib/kobject.c | |||
@@ -153,6 +153,10 @@ static void kobject_init_internal(struct kobject *kobj) | |||
153 | return; | 153 | return; |
154 | kref_init(&kobj->kref); | 154 | kref_init(&kobj->kref); |
155 | INIT_LIST_HEAD(&kobj->entry); | 155 | INIT_LIST_HEAD(&kobj->entry); |
156 | kobj->state_in_sysfs = 0; | ||
157 | kobj->state_add_uevent_sent = 0; | ||
158 | kobj->state_remove_uevent_sent = 0; | ||
159 | kobj->state_initialized = 1; | ||
156 | } | 160 | } |
157 | 161 | ||
158 | 162 | ||
@@ -289,13 +293,8 @@ void kobject_init(struct kobject *kobj, struct kobj_type *ktype) | |||
289 | dump_stack(); | 293 | dump_stack(); |
290 | } | 294 | } |
291 | 295 | ||
292 | kref_init(&kobj->kref); | 296 | kobject_init_internal(kobj); |
293 | INIT_LIST_HEAD(&kobj->entry); | ||
294 | kobj->ktype = ktype; | 297 | kobj->ktype = ktype; |
295 | kobj->state_in_sysfs = 0; | ||
296 | kobj->state_add_uevent_sent = 0; | ||
297 | kobj->state_remove_uevent_sent = 0; | ||
298 | kobj->state_initialized = 1; | ||
299 | return; | 298 | return; |
300 | 299 | ||
301 | error: | 300 | error: |