aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorcpw@sgi.com <cpw@sgi.com>2011-06-21 08:21:30 -0400
committerIngo Molnar <mingo@elte.hu>2011-06-21 08:50:32 -0400
commita456eaab87461e33d94e748565eabd474283a475 (patch)
tree69d36690b59ccdd2c15c16326f8b6a6738910594
parent485f07d349a3e5059413b886a3bc1996c4b3d14d (diff)
x86, UV: Rename hubmask to pnmask
Rename 'bau_targ_hubmask' to 'pnmask' for clarity. The BAU distribution bit mask is indexed by pnode number, not hub or blade number. This important fact is not clear while the mask is called a 'hubmask'. Signed-off-by: Cliff Wickman <cpw@sgi.com> Link: http://lkml.kernel.org/r/20110621122242.630995969@sgi.com Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r--arch/x86/include/asm/uv/uv_bau.h12
-rw-r--r--arch/x86/platform/uv/tlb_uv.c5
2 files changed, 8 insertions, 9 deletions
diff --git a/arch/x86/include/asm/uv/uv_bau.h b/arch/x86/include/asm/uv/uv_bau.h
index 605e613b510c..fa6a48e264b3 100644
--- a/arch/x86/include/asm/uv/uv_bau.h
+++ b/arch/x86/include/asm/uv/uv_bau.h
@@ -183,7 +183,7 @@
183 * 'base_dest_nasid' field of the header corresponds to the 183 * 'base_dest_nasid' field of the header corresponds to the
184 * destination nodeID associated with that specified bit. 184 * destination nodeID associated with that specified bit.
185 */ 185 */
186struct bau_targ_hubmask { 186struct pnmask {
187 unsigned long bits[BITS_TO_LONGS(UV_DISTRIBUTION_SIZE)]; 187 unsigned long bits[BITS_TO_LONGS(UV_DISTRIBUTION_SIZE)];
188}; 188};
189 189
@@ -314,7 +314,7 @@ struct bau_msg_header {
314 * Should be 64 bytes 314 * Should be 64 bytes
315 */ 315 */
316struct bau_desc { 316struct bau_desc {
317 struct bau_targ_hubmask distribution; 317 struct pnmask distribution;
318 /* 318 /*
319 * message template, consisting of header and payload: 319 * message template, consisting of header and payload:
320 */ 320 */
@@ -596,20 +596,20 @@ static inline void write_mmr_data_config(int pnode, unsigned long mr)
596 uv_write_global_mmr64(pnode, UVH_BAU_DATA_CONFIG, mr); 596 uv_write_global_mmr64(pnode, UVH_BAU_DATA_CONFIG, mr);
597} 597}
598 598
599static inline int bau_uvhub_isset(int uvhub, struct bau_targ_hubmask *dstp) 599static inline int bau_uvhub_isset(int uvhub, struct pnmask *dstp)
600{ 600{
601 return constant_test_bit(uvhub, &dstp->bits[0]); 601 return constant_test_bit(uvhub, &dstp->bits[0]);
602} 602}
603static inline void bau_uvhub_set(int pnode, struct bau_targ_hubmask *dstp) 603static inline void bau_uvhub_set(int pnode, struct pnmask *dstp)
604{ 604{
605 __set_bit(pnode, &dstp->bits[0]); 605 __set_bit(pnode, &dstp->bits[0]);
606} 606}
607static inline void bau_uvhubs_clear(struct bau_targ_hubmask *dstp, 607static inline void bau_uvhubs_clear(struct pnmask *dstp,
608 int nbits) 608 int nbits)
609{ 609{
610 bitmap_zero(&dstp->bits[0], nbits); 610 bitmap_zero(&dstp->bits[0], nbits);
611} 611}
612static inline int bau_uvhub_weight(struct bau_targ_hubmask *dstp) 612static inline int bau_uvhub_weight(struct pnmask *dstp)
613{ 613{
614 return bitmap_weight((unsigned long *)&dstp->bits[0], 614 return bitmap_weight((unsigned long *)&dstp->bits[0],
615 UV_DISTRIBUTION_SIZE); 615 UV_DISTRIBUTION_SIZE);
diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index 4b28e09e265e..191ef28ea173 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -370,8 +370,7 @@ static void do_reset(void *ptr)
370 * Use IPI to get all target uvhubs to release resources held by 370 * Use IPI to get all target uvhubs to release resources held by
371 * a given sending cpu number. 371 * a given sending cpu number.
372 */ 372 */
373static void reset_with_ipi(struct bau_targ_hubmask *distribution, 373static void reset_with_ipi(struct pnmask *distribution, struct bau_control *bcp)
374 struct bau_control *bcp)
375{ 374{
376 int pnode; 375 int pnode;
377 int apnode; 376 int apnode;
@@ -384,7 +383,7 @@ static void reset_with_ipi(struct bau_targ_hubmask *distribution,
384 reset_args.sender = sender; 383 reset_args.sender = sender;
385 cpus_clear(mask); 384 cpus_clear(mask);
386 /* find a single cpu for each uvhub in this distribution mask */ 385 /* find a single cpu for each uvhub in this distribution mask */
387 maskbits = sizeof(struct bau_targ_hubmask) * BITSPERBYTE; 386 maskbits = sizeof(struct pnmask) * BITSPERBYTE;
388 /* each bit is a pnode relative to the partition base pnode */ 387 /* each bit is a pnode relative to the partition base pnode */
389 for (pnode = 0; pnode < maskbits; pnode++) { 388 for (pnode = 0; pnode < maskbits; pnode++) {
390 int cpu; 389 int cpu;