diff options
author | Dave Chinner <david@fromorbit.com> | 2013-09-02 06:49:36 -0400 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-09-09 18:43:05 -0400 |
commit | a30b0367978f75a2659c71b33739e5e445a363c8 (patch) | |
tree | f5d50ce20e9d81095a701d53712b892c6883eb58 | |
parent | e9fbbad8d8b2cbd6df7f237e0b4de02d63837ce1 (diff) |
xfs: fix some minor sparse warnings
A couple of simple locking annotations and 0 vs NULL warnings.
Nothing that changes any code behaviour, just removes build noise.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>
-rw-r--r-- | fs/xfs/xfs_bmap.c | 2 | ||||
-rw-r--r-- | fs/xfs/xfs_dquot_item.c | 3 | ||||
-rw-r--r-- | fs/xfs/xfs_extent_busy.c | 3 | ||||
-rw-r--r-- | fs/xfs/xfs_ioctl.c | 2 | ||||
-rw-r--r-- | fs/xfs/xfs_itable.c | 5 | ||||
-rw-r--r-- | fs/xfs/xfs_log.c | 3 |
6 files changed, 11 insertions, 7 deletions
diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c index 92b830901d60..f47e65c30be6 100644 --- a/fs/xfs/xfs_bmap.c +++ b/fs/xfs/xfs_bmap.c | |||
@@ -4450,7 +4450,7 @@ xfs_bmapi_write( | |||
4450 | { | 4450 | { |
4451 | struct xfs_mount *mp = ip->i_mount; | 4451 | struct xfs_mount *mp = ip->i_mount; |
4452 | struct xfs_ifork *ifp; | 4452 | struct xfs_ifork *ifp; |
4453 | struct xfs_bmalloca bma = { 0 }; /* args for xfs_bmap_alloc */ | 4453 | struct xfs_bmalloca bma = { NULL }; /* args for xfs_bmap_alloc */ |
4454 | xfs_fileoff_t end; /* end of mapped file region */ | 4454 | xfs_fileoff_t end; /* end of mapped file region */ |
4455 | int eof; /* after the end of extents */ | 4455 | int eof; /* after the end of extents */ |
4456 | int error; /* error return */ | 4456 | int error; /* error return */ |
diff --git a/fs/xfs/xfs_dquot_item.c b/fs/xfs/xfs_dquot_item.c index 60c6e1f12695..e838d84b4e85 100644 --- a/fs/xfs/xfs_dquot_item.c +++ b/fs/xfs/xfs_dquot_item.c | |||
@@ -142,7 +142,8 @@ xfs_qm_dqunpin_wait( | |||
142 | STATIC uint | 142 | STATIC uint |
143 | xfs_qm_dquot_logitem_push( | 143 | xfs_qm_dquot_logitem_push( |
144 | struct xfs_log_item *lip, | 144 | struct xfs_log_item *lip, |
145 | struct list_head *buffer_list) | 145 | struct list_head *buffer_list) __releases(&lip->li_ailp->xa_lock) |
146 | __acquires(&lip->li_ailp->xa_lock) | ||
146 | { | 147 | { |
147 | struct xfs_dquot *dqp = DQUOT_ITEM(lip)->qli_dquot; | 148 | struct xfs_dquot *dqp = DQUOT_ITEM(lip)->qli_dquot; |
148 | struct xfs_buf *bp = NULL; | 149 | struct xfs_buf *bp = NULL; |
diff --git a/fs/xfs/xfs_extent_busy.c b/fs/xfs/xfs_extent_busy.c index 86f559f6e5d3..e43708e2f080 100644 --- a/fs/xfs/xfs_extent_busy.c +++ b/fs/xfs/xfs_extent_busy.c | |||
@@ -160,7 +160,8 @@ xfs_extent_busy_update_extent( | |||
160 | struct xfs_extent_busy *busyp, | 160 | struct xfs_extent_busy *busyp, |
161 | xfs_agblock_t fbno, | 161 | xfs_agblock_t fbno, |
162 | xfs_extlen_t flen, | 162 | xfs_extlen_t flen, |
163 | bool userdata) | 163 | bool userdata) __releases(&pag->pagb_lock) |
164 | __acquires(&pag->pagb_lock) | ||
164 | { | 165 | { |
165 | xfs_agblock_t fend = fbno + flen; | 166 | xfs_agblock_t fend = fbno + flen; |
166 | xfs_agblock_t bbno = busyp->bno; | 167 | xfs_agblock_t bbno = busyp->bno; |
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index bdebc21078d7..21d9c9df9fb7 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c | |||
@@ -71,7 +71,7 @@ xfs_find_handle( | |||
71 | int hsize; | 71 | int hsize; |
72 | xfs_handle_t handle; | 72 | xfs_handle_t handle; |
73 | struct inode *inode; | 73 | struct inode *inode; |
74 | struct fd f = {0}; | 74 | struct fd f = {NULL}; |
75 | struct path path; | 75 | struct path path; |
76 | int error; | 76 | int error; |
77 | struct xfs_inode *ip; | 77 | struct xfs_inode *ip; |
diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c index b93e14b86754..8a67d53b9b7a 100644 --- a/fs/xfs/xfs_itable.c +++ b/fs/xfs/xfs_itable.c | |||
@@ -541,8 +541,9 @@ xfs_bulkstat_single( | |||
541 | * at the expense of the error case. | 541 | * at the expense of the error case. |
542 | */ | 542 | */ |
543 | 543 | ||
544 | ino = (xfs_ino_t)*lastinop; | 544 | ino = *lastinop; |
545 | error = xfs_bulkstat_one(mp, ino, buffer, sizeof(xfs_bstat_t), 0, &res); | 545 | error = xfs_bulkstat_one(mp, ino, buffer, sizeof(xfs_bstat_t), |
546 | NULL, &res); | ||
546 | if (error) { | 547 | if (error) { |
547 | /* | 548 | /* |
548 | * Special case way failed, do it the "long" way | 549 | * Special case way failed, do it the "long" way |
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index 5372d58ef93a..a2dea108071a 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c | |||
@@ -257,7 +257,8 @@ xlog_grant_head_wait( | |||
257 | struct xlog *log, | 257 | struct xlog *log, |
258 | struct xlog_grant_head *head, | 258 | struct xlog_grant_head *head, |
259 | struct xlog_ticket *tic, | 259 | struct xlog_ticket *tic, |
260 | int need_bytes) | 260 | int need_bytes) __releases(&head->lock) |
261 | __acquires(&head->lock) | ||
261 | { | 262 | { |
262 | list_add_tail(&tic->t_queue, &head->waiters); | 263 | list_add_tail(&tic->t_queue, &head->waiters); |
263 | 264 | ||