staging: comedi: rtd520: ioremap'ed addresses are resource_size_t

As mentioned by Ian Abbott, the pci address passed to ioremap
should be a resource_size_t not an unsigned long. Use a local
variable of that type to hold the pci_resource_start() that is
passed to ioremp().

Set the dev->iobase to a dummy non-zero value so that the "detach"
can use it as a flag to know that comedi_pci_disable() needs to
be called.

Reported-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 10 insertions, 16 deletions

diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
index 112fdc3e9c69..5aa8be1e7b92 100644
--- a/drivers/staging/comedi/drivers/rtd520.c
+++ b/drivers/staging/comedi/drivers/rtd520.c
@@ -1619,9 +1619,8 @@ static int rtd_attach(struct comedi_device *dev, struct comedi_devconfig *it)
         struct rtdPrivate *devpriv;
         struct pci_dev *pcidev;
         struct comedi_subdevice *s;
+        resource_size_t pci_base;
         int ret;
-        resource_size_t physLas1;       /* data area */
-        resource_size_t physLcfg;       /* PLX9080 */
 #ifdef USE_DMA
         int index;
 #endif
@@ -1655,20 +1654,15 @@ static int rtd_attach(struct comedi_device *dev, struct comedi_devconfig *it)
                 printk(KERN_INFO "Failed to enable PCI device and request regions.\n");
                 return ret;
         }
-
-        /*
-         * Initialize base addresses
-         */
-        /* Get the physical address from PCI config */
-        dev->iobase = pci_resource_start(pcidev, LAS0_PCIINDEX);
-        physLas1 = pci_resource_start(pcidev, LAS1_PCIINDEX);
-        physLcfg = pci_resource_start(pcidev, LCFG_PCIINDEX);
-        /* Now have the kernel map this into memory */
-        /* ASSUME page aligned */
-        devpriv->las0 = ioremap_nocache(dev->iobase, LAS0_PCISIZE);
-        devpriv->las1 = ioremap_nocache(physLas1, LAS1_PCISIZE);
-        devpriv->lcfg = ioremap_nocache(physLcfg, LCFG_PCISIZE);
-
+        dev->iobase = 1;        /* the "detach" needs this */
+
+        /* Initialize the base addresses */
+        pci_base = pci_resource_start(pcidev, LAS0_PCIINDEX);
+        devpriv->las0 = ioremap_nocache(pci_base, LAS0_PCISIZE);
+        pci_base = pci_resource_start(pcidev, LAS1_PCIINDEX);
+        devpriv->las1 = ioremap_nocache(pci_base, LAS1_PCISIZE);
+        pci_base = pci_resource_start(pcidev, LCFG_PCIINDEX);
+        devpriv->lcfg = ioremap_nocache(pci_base, LCFG_PCISIZE);
         if (!devpriv->las0 || !devpriv->las1 || !devpriv->lcfg)
                 return -ENOMEM;