diff options
author | Vivek Goyal <vgoyal@redhat.com> | 2011-05-19 15:38:20 -0400 |
---|---|---|
committer | Jens Axboe <jaxboe@fusionio.com> | 2011-05-20 14:34:52 -0400 |
commit | a23e68695593d00b35a6cddf8e9c9ec03505ecb9 (patch) | |
tree | 954a92fb07408e4b7483881f09d2afc91002bc00 | |
parent | a29a171e7c46c60842b85729280e2f5690372683 (diff) |
blk-cgroup: move some fields of unaccounted_time file under right config option
cgroup unaccounted_time file is created only if CONFIG_DEBUG_BLK_CGROUP=y.
there are some fields which are out side this config option. Fix that.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
-rw-r--r-- | block/blk-cgroup.c | 2 | ||||
-rw-r--r-- | block/blk-cgroup.h | 7 |
2 files changed, 6 insertions, 3 deletions
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 471fdcc5df85..b0592bca6970 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c | |||
@@ -385,7 +385,9 @@ void blkiocg_update_timeslice_used(struct blkio_group *blkg, unsigned long time, | |||
385 | 385 | ||
386 | spin_lock_irqsave(&blkg->stats_lock, flags); | 386 | spin_lock_irqsave(&blkg->stats_lock, flags); |
387 | blkg->stats.time += time; | 387 | blkg->stats.time += time; |
388 | #ifdef CONFIG_DEBUG_BLK_CGROUP | ||
388 | blkg->stats.unaccounted_time += unaccounted_time; | 389 | blkg->stats.unaccounted_time += unaccounted_time; |
390 | #endif | ||
389 | spin_unlock_irqrestore(&blkg->stats_lock, flags); | 391 | spin_unlock_irqrestore(&blkg->stats_lock, flags); |
390 | } | 392 | } |
391 | EXPORT_SYMBOL_GPL(blkiocg_update_timeslice_used); | 393 | EXPORT_SYMBOL_GPL(blkiocg_update_timeslice_used); |
diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h index c774930cc206..63f1ef4450d7 100644 --- a/block/blk-cgroup.h +++ b/block/blk-cgroup.h | |||
@@ -49,9 +49,9 @@ enum stat_type { | |||
49 | /* All the single valued stats go below this */ | 49 | /* All the single valued stats go below this */ |
50 | BLKIO_STAT_TIME, | 50 | BLKIO_STAT_TIME, |
51 | BLKIO_STAT_SECTORS, | 51 | BLKIO_STAT_SECTORS, |
52 | #ifdef CONFIG_DEBUG_BLK_CGROUP | ||
52 | /* Time not charged to this cgroup */ | 53 | /* Time not charged to this cgroup */ |
53 | BLKIO_STAT_UNACCOUNTED_TIME, | 54 | BLKIO_STAT_UNACCOUNTED_TIME, |
54 | #ifdef CONFIG_DEBUG_BLK_CGROUP | ||
55 | BLKIO_STAT_AVG_QUEUE_SIZE, | 55 | BLKIO_STAT_AVG_QUEUE_SIZE, |
56 | BLKIO_STAT_IDLE_TIME, | 56 | BLKIO_STAT_IDLE_TIME, |
57 | BLKIO_STAT_EMPTY_TIME, | 57 | BLKIO_STAT_EMPTY_TIME, |
@@ -117,10 +117,11 @@ struct blkio_group_stats { | |||
117 | /* total disk time and nr sectors dispatched by this group */ | 117 | /* total disk time and nr sectors dispatched by this group */ |
118 | uint64_t time; | 118 | uint64_t time; |
119 | uint64_t sectors; | 119 | uint64_t sectors; |
120 | /* Time not charged to this cgroup */ | ||
121 | uint64_t unaccounted_time; | ||
122 | uint64_t stat_arr[BLKIO_STAT_QUEUED + 1][BLKIO_STAT_TOTAL]; | 120 | uint64_t stat_arr[BLKIO_STAT_QUEUED + 1][BLKIO_STAT_TOTAL]; |
123 | #ifdef CONFIG_DEBUG_BLK_CGROUP | 121 | #ifdef CONFIG_DEBUG_BLK_CGROUP |
122 | /* Time not charged to this cgroup */ | ||
123 | uint64_t unaccounted_time; | ||
124 | |||
124 | /* Sum of number of IOs queued across all samples */ | 125 | /* Sum of number of IOs queued across all samples */ |
125 | uint64_t avg_queue_size_sum; | 126 | uint64_t avg_queue_size_sum; |
126 | /* Count of samples taken for average */ | 127 | /* Count of samples taken for average */ |