diff options
author | Juuso Oikarinen <juuso.oikarinen@nokia.com> | 2009-10-13 05:47:56 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2009-10-27 16:48:15 -0400 |
commit | a163acce485a9629418659ff74737b89ba2c1751 (patch) | |
tree | 6882c6e5a6f0e402b82b98d05704566ece82f556 | |
parent | 01c09162cd6170f3671825d6d5f2c1ae7b27cbf3 (diff) |
wl1271: Remove unnecessary rx_descriptor memory allocation
Remove unnecessary RX descriptor memory allocation from the driver. The
allocation was a remnant of the wl1251 driver.
Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/wl12xx/wl1271.h | 1 | ||||
-rw-r--r-- | drivers/net/wireless/wl12xx/wl1271_main.c | 13 |
2 files changed, 0 insertions, 14 deletions
diff --git a/drivers/net/wireless/wl12xx/wl1271.h b/drivers/net/wireless/wl12xx/wl1271.h index 1e399a2a7f6b..fca59687041e 100644 --- a/drivers/net/wireless/wl12xx/wl1271.h +++ b/drivers/net/wireless/wl12xx/wl1271.h | |||
@@ -429,7 +429,6 @@ struct wl1271 { | |||
429 | u32 buffer_32; | 429 | u32 buffer_32; |
430 | u32 buffer_cmd; | 430 | u32 buffer_cmd; |
431 | u32 buffer_busyword[WL1271_BUSY_WORD_CNT]; | 431 | u32 buffer_busyword[WL1271_BUSY_WORD_CNT]; |
432 | struct wl1271_rx_descriptor *rx_descriptor; | ||
433 | 432 | ||
434 | struct wl1271_fw_status *fw_status; | 433 | struct wl1271_fw_status *fw_status; |
435 | struct wl1271_tx_hw_res_if *tx_res_if; | 434 | struct wl1271_tx_hw_res_if *tx_res_if; |
diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c index 7d70f4168b2f..dfa08a188632 100644 --- a/drivers/net/wireless/wl12xx/wl1271_main.c +++ b/drivers/net/wireless/wl12xx/wl1271_main.c | |||
@@ -1893,13 +1893,6 @@ static int __devinit wl1271_probe(struct spi_device *spi) | |||
1893 | wl->state = WL1271_STATE_OFF; | 1893 | wl->state = WL1271_STATE_OFF; |
1894 | mutex_init(&wl->mutex); | 1894 | mutex_init(&wl->mutex); |
1895 | 1895 | ||
1896 | wl->rx_descriptor = kmalloc(sizeof(*wl->rx_descriptor), GFP_KERNEL); | ||
1897 | if (!wl->rx_descriptor) { | ||
1898 | wl1271_error("could not allocate memory for rx descriptor"); | ||
1899 | ret = -ENOMEM; | ||
1900 | goto out_free; | ||
1901 | } | ||
1902 | |||
1903 | /* This is the only SPI value that we need to set here, the rest | 1896 | /* This is the only SPI value that we need to set here, the rest |
1904 | * comes from the board-peripherals file */ | 1897 | * comes from the board-peripherals file */ |
1905 | spi->bits_per_word = 32; | 1898 | spi->bits_per_word = 32; |
@@ -1965,9 +1958,6 @@ static int __devinit wl1271_probe(struct spi_device *spi) | |||
1965 | free_irq(wl->irq, wl); | 1958 | free_irq(wl->irq, wl); |
1966 | 1959 | ||
1967 | out_free: | 1960 | out_free: |
1968 | kfree(wl->rx_descriptor); | ||
1969 | wl->rx_descriptor = NULL; | ||
1970 | |||
1971 | ieee80211_free_hw(hw); | 1961 | ieee80211_free_hw(hw); |
1972 | 1962 | ||
1973 | return ret; | 1963 | return ret; |
@@ -1988,9 +1978,6 @@ static int __devexit wl1271_remove(struct spi_device *spi) | |||
1988 | kfree(wl->nvs); | 1978 | kfree(wl->nvs); |
1989 | wl->nvs = NULL; | 1979 | wl->nvs = NULL; |
1990 | 1980 | ||
1991 | kfree(wl->rx_descriptor); | ||
1992 | wl->rx_descriptor = NULL; | ||
1993 | |||
1994 | kfree(wl->fw_status); | 1981 | kfree(wl->fw_status); |
1995 | kfree(wl->tx_res_if); | 1982 | kfree(wl->tx_res_if); |
1996 | 1983 | ||