aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2011-03-03 14:43:03 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2011-03-05 20:31:04 -0500
commita03f35ceeb3d279da35c5a914ac01a4b1effb0a1 (patch)
tree547fc42fbbcd2fa6c2c32e0081c2ed57c3678a78
parent6909262429b70a162e9e7053672cfd8024c9275d (diff)
perf report tui: Fix multi event switching
TAB/UNTAB were not hotkeys, so didn't exit hists__browse back to hists__tui_browse_tree, allowing just the first event to be browsed. Reported-by: William Cohen <wcohen@redhat.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: Tom Zanussi <tzanussi@gmail.com> Cc: William Cohen <wcohen@redhat.com> LKML-Reference: <new-submission> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/util/ui/browsers/hists.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/perf/util/ui/browsers/hists.c b/tools/perf/util/ui/browsers/hists.c
index 497b3c4076a3..c27ab35042f1 100644
--- a/tools/perf/util/ui/browsers/hists.c
+++ b/tools/perf/util/ui/browsers/hists.c
@@ -292,7 +292,8 @@ static int hist_browser__run(struct hist_browser *self, const char *title)
292{ 292{
293 int key; 293 int key;
294 int exit_keys[] = { 'a', '?', 'h', 'C', 'd', 'D', 'E', 't', 294 int exit_keys[] = { 'a', '?', 'h', 'C', 'd', 'D', 'E', 't',
295 NEWT_KEY_ENTER, NEWT_KEY_RIGHT, NEWT_KEY_LEFT, 0, }; 295 NEWT_KEY_ENTER, NEWT_KEY_RIGHT, NEWT_KEY_LEFT,
296 NEWT_KEY_TAB, NEWT_KEY_UNTAB, 0, };
296 297
297 self->b.entries = &self->hists->entries; 298 self->b.entries = &self->hists->entries;
298 self->b.nr_entries = self->hists->nr_entries; 299 self->b.nr_entries = self->hists->nr_entries;
@@ -859,6 +860,7 @@ int hists__browse(struct hists *self, const char *helpline,
859 "E Expand all callchains\n" 860 "E Expand all callchains\n"
860 "d Zoom into current DSO\n" 861 "d Zoom into current DSO\n"
861 "t Zoom into current Thread\n" 862 "t Zoom into current Thread\n"
863 "TAB/UNTAB Switch events\n"
862 "q/CTRL+C Exit browser"); 864 "q/CTRL+C Exit browser");
863 continue; 865 continue;
864 case NEWT_KEY_ENTER: 866 case NEWT_KEY_ENTER:
@@ -997,6 +999,7 @@ int hists__tui_browse_tree(struct rb_root *self, const char *help, int evidx)
997 if (nd == first) 999 if (nd == first)
998 continue; 1000 continue;
999 nd = rb_prev(nd); 1001 nd = rb_prev(nd);
1002 break;
1000 default: 1003 default:
1001 return key; 1004 return key;
1002 } 1005 }