diff options
author | Hante Meuleman <meuleman@broadcom.com> | 2013-12-12 05:59:01 -0500 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2013-12-18 15:22:51 -0500 |
commit | 9ecf51c5831b86b367588f2aa50c0b156738b9c6 (patch) | |
tree | 7d6959431affabe668ad14ef968b37cccc5d8ae4 | |
parent | 8141083c48192b63a39b77adffd9a8e0dcfab034 (diff) |
brcmfmac: Fix hex dump for FWIL.
The debug function brcmf_dbg_hex_dump API got changed and the
information string should preferably contain a \n at the end
of the string. Update the FWIL so debug output looks better.
Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
-rw-r--r-- | drivers/net/wireless/brcm80211/brcmfmac/fwil.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c index b72d3395499a..22adbe311d20 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/fwil.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwil.c | |||
@@ -68,7 +68,7 @@ brcmf_fil_cmd_data_set(struct brcmf_if *ifp, u32 cmd, void *data, u32 len) | |||
68 | 68 | ||
69 | brcmf_dbg(FIL, "cmd=%d, len=%d\n", cmd, len); | 69 | brcmf_dbg(FIL, "cmd=%d, len=%d\n", cmd, len); |
70 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, | 70 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, |
71 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data"); | 71 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n"); |
72 | 72 | ||
73 | err = brcmf_fil_cmd_data(ifp, cmd, data, len, true); | 73 | err = brcmf_fil_cmd_data(ifp, cmd, data, len, true); |
74 | mutex_unlock(&ifp->drvr->proto_block); | 74 | mutex_unlock(&ifp->drvr->proto_block); |
@@ -86,7 +86,7 @@ brcmf_fil_cmd_data_get(struct brcmf_if *ifp, u32 cmd, void *data, u32 len) | |||
86 | 86 | ||
87 | brcmf_dbg(FIL, "cmd=%d, len=%d\n", cmd, len); | 87 | brcmf_dbg(FIL, "cmd=%d, len=%d\n", cmd, len); |
88 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, | 88 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, |
89 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data"); | 89 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n"); |
90 | 90 | ||
91 | mutex_unlock(&ifp->drvr->proto_block); | 91 | mutex_unlock(&ifp->drvr->proto_block); |
92 | 92 | ||
@@ -155,7 +155,7 @@ brcmf_fil_iovar_data_set(struct brcmf_if *ifp, char *name, void *data, | |||
155 | 155 | ||
156 | brcmf_dbg(FIL, "name=%s, len=%d\n", name, len); | 156 | brcmf_dbg(FIL, "name=%s, len=%d\n", name, len); |
157 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, | 157 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, |
158 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data"); | 158 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n"); |
159 | 159 | ||
160 | buflen = brcmf_create_iovar(name, data, len, drvr->proto_buf, | 160 | buflen = brcmf_create_iovar(name, data, len, drvr->proto_buf, |
161 | sizeof(drvr->proto_buf)); | 161 | sizeof(drvr->proto_buf)); |
@@ -195,7 +195,7 @@ brcmf_fil_iovar_data_get(struct brcmf_if *ifp, char *name, void *data, | |||
195 | 195 | ||
196 | brcmf_dbg(FIL, "name=%s, len=%d\n", name, len); | 196 | brcmf_dbg(FIL, "name=%s, len=%d\n", name, len); |
197 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, | 197 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, |
198 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data"); | 198 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n"); |
199 | 199 | ||
200 | mutex_unlock(&drvr->proto_block); | 200 | mutex_unlock(&drvr->proto_block); |
201 | return err; | 201 | return err; |
@@ -278,7 +278,7 @@ brcmf_fil_bsscfg_data_set(struct brcmf_if *ifp, char *name, | |||
278 | 278 | ||
279 | brcmf_dbg(FIL, "bssidx=%d, name=%s, len=%d\n", ifp->bssidx, name, len); | 279 | brcmf_dbg(FIL, "bssidx=%d, name=%s, len=%d\n", ifp->bssidx, name, len); |
280 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, | 280 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, |
281 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data"); | 281 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n"); |
282 | 282 | ||
283 | buflen = brcmf_create_bsscfg(ifp->bssidx, name, data, len, | 283 | buflen = brcmf_create_bsscfg(ifp->bssidx, name, data, len, |
284 | drvr->proto_buf, sizeof(drvr->proto_buf)); | 284 | drvr->proto_buf, sizeof(drvr->proto_buf)); |
@@ -317,7 +317,7 @@ brcmf_fil_bsscfg_data_get(struct brcmf_if *ifp, char *name, | |||
317 | } | 317 | } |
318 | brcmf_dbg(FIL, "bssidx=%d, name=%s, len=%d\n", ifp->bssidx, name, len); | 318 | brcmf_dbg(FIL, "bssidx=%d, name=%s, len=%d\n", ifp->bssidx, name, len); |
319 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, | 319 | brcmf_dbg_hex_dump(BRCMF_FIL_ON(), data, |
320 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data"); | 320 | min_t(uint, len, MAX_HEX_DUMP_LEN), "data\n"); |
321 | 321 | ||
322 | mutex_unlock(&drvr->proto_block); | 322 | mutex_unlock(&drvr->proto_block); |
323 | return err; | 323 | return err; |