diff options
author | Petri Gynther <pgynther@google.com> | 2015-03-25 15:35:10 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-03-27 17:26:13 -0400 |
commit | 9dbac28fc193e3972f566f120dce67d69a1df634 (patch) | |
tree | 8c1f0246de075f527182ce0c6bbc52a2206cd6f5 | |
parent | e412b1045c3bddd31e16f9e93d6843de2482be0c (diff) |
net: bcmgenet: modify Tx ring int_enable and int_disable vectors
Remove unnecessary function parameter priv. Use ring->priv instead.
Signed-off-by: Petri Gynther <pgynther@google.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmgenet.c | 26 | ||||
-rw-r--r-- | drivers/net/ethernet/broadcom/genet/bcmgenet.h | 6 |
2 files changed, 13 insertions, 19 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 030249dd09f0..550bf98d0730 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c | |||
@@ -964,33 +964,29 @@ static void bcmgenet_free_cb(struct enet_cb *cb) | |||
964 | dma_unmap_addr_set(cb, dma_addr, 0); | 964 | dma_unmap_addr_set(cb, dma_addr, 0); |
965 | } | 965 | } |
966 | 966 | ||
967 | static inline void bcmgenet_tx_ring16_int_disable(struct bcmgenet_priv *priv, | 967 | static inline void bcmgenet_tx_ring16_int_disable(struct bcmgenet_tx_ring *ring) |
968 | struct bcmgenet_tx_ring *ring) | ||
969 | { | 968 | { |
970 | bcmgenet_intrl2_0_writel(priv, | 969 | bcmgenet_intrl2_0_writel(ring->priv, |
971 | UMAC_IRQ_TXDMA_BDONE | UMAC_IRQ_TXDMA_PDONE, | 970 | UMAC_IRQ_TXDMA_BDONE | UMAC_IRQ_TXDMA_PDONE, |
972 | INTRL2_CPU_MASK_SET); | 971 | INTRL2_CPU_MASK_SET); |
973 | } | 972 | } |
974 | 973 | ||
975 | static inline void bcmgenet_tx_ring16_int_enable(struct bcmgenet_priv *priv, | 974 | static inline void bcmgenet_tx_ring16_int_enable(struct bcmgenet_tx_ring *ring) |
976 | struct bcmgenet_tx_ring *ring) | ||
977 | { | 975 | { |
978 | bcmgenet_intrl2_0_writel(priv, | 976 | bcmgenet_intrl2_0_writel(ring->priv, |
979 | UMAC_IRQ_TXDMA_BDONE | UMAC_IRQ_TXDMA_PDONE, | 977 | UMAC_IRQ_TXDMA_BDONE | UMAC_IRQ_TXDMA_PDONE, |
980 | INTRL2_CPU_MASK_CLEAR); | 978 | INTRL2_CPU_MASK_CLEAR); |
981 | } | 979 | } |
982 | 980 | ||
983 | static inline void bcmgenet_tx_ring_int_enable(struct bcmgenet_priv *priv, | 981 | static inline void bcmgenet_tx_ring_int_enable(struct bcmgenet_tx_ring *ring) |
984 | struct bcmgenet_tx_ring *ring) | ||
985 | { | 982 | { |
986 | bcmgenet_intrl2_1_writel(priv, (1 << ring->index), | 983 | bcmgenet_intrl2_1_writel(ring->priv, 1 << ring->index, |
987 | INTRL2_CPU_MASK_CLEAR); | 984 | INTRL2_CPU_MASK_CLEAR); |
988 | } | 985 | } |
989 | 986 | ||
990 | static inline void bcmgenet_tx_ring_int_disable(struct bcmgenet_priv *priv, | 987 | static inline void bcmgenet_tx_ring_int_disable(struct bcmgenet_tx_ring *ring) |
991 | struct bcmgenet_tx_ring *ring) | ||
992 | { | 988 | { |
993 | bcmgenet_intrl2_1_writel(priv, (1 << ring->index), | 989 | bcmgenet_intrl2_1_writel(ring->priv, 1 << ring->index, |
994 | INTRL2_CPU_MASK_SET); | 990 | INTRL2_CPU_MASK_SET); |
995 | } | 991 | } |
996 | 992 | ||
@@ -1083,7 +1079,7 @@ static int bcmgenet_tx_poll(struct napi_struct *napi, int budget) | |||
1083 | 1079 | ||
1084 | if (work_done == 0) { | 1080 | if (work_done == 0) { |
1085 | napi_complete(napi); | 1081 | napi_complete(napi); |
1086 | ring->int_enable(ring->priv, ring); | 1082 | ring->int_enable(ring); |
1087 | 1083 | ||
1088 | return 0; | 1084 | return 0; |
1089 | } | 1085 | } |
@@ -2172,7 +2168,7 @@ static irqreturn_t bcmgenet_isr1(int irq, void *dev_id) | |||
2172 | ring = &priv->tx_rings[index]; | 2168 | ring = &priv->tx_rings[index]; |
2173 | 2169 | ||
2174 | if (likely(napi_schedule_prep(&ring->napi))) { | 2170 | if (likely(napi_schedule_prep(&ring->napi))) { |
2175 | ring->int_disable(priv, ring); | 2171 | ring->int_disable(ring); |
2176 | __napi_schedule(&ring->napi); | 2172 | __napi_schedule(&ring->napi); |
2177 | } | 2173 | } |
2178 | } | 2174 | } |
@@ -2211,7 +2207,7 @@ static irqreturn_t bcmgenet_isr0(int irq, void *dev_id) | |||
2211 | struct bcmgenet_tx_ring *ring = &priv->tx_rings[DESC_INDEX]; | 2207 | struct bcmgenet_tx_ring *ring = &priv->tx_rings[DESC_INDEX]; |
2212 | 2208 | ||
2213 | if (likely(napi_schedule_prep(&ring->napi))) { | 2209 | if (likely(napi_schedule_prep(&ring->napi))) { |
2214 | ring->int_disable(priv, ring); | 2210 | ring->int_disable(ring); |
2215 | __napi_schedule(&ring->napi); | 2211 | __napi_schedule(&ring->napi); |
2216 | } | 2212 | } |
2217 | } | 2213 | } |
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h b/drivers/net/ethernet/broadcom/genet/bcmgenet.h index a9e16122f231..7b11e7a7e153 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.h +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.h | |||
@@ -535,10 +535,8 @@ struct bcmgenet_tx_ring { | |||
535 | unsigned int prod_index; /* Tx ring producer index SW copy */ | 535 | unsigned int prod_index; /* Tx ring producer index SW copy */ |
536 | unsigned int cb_ptr; /* Tx ring initial CB ptr */ | 536 | unsigned int cb_ptr; /* Tx ring initial CB ptr */ |
537 | unsigned int end_ptr; /* Tx ring end CB ptr */ | 537 | unsigned int end_ptr; /* Tx ring end CB ptr */ |
538 | void (*int_enable)(struct bcmgenet_priv *priv, | 538 | void (*int_enable)(struct bcmgenet_tx_ring *); |
539 | struct bcmgenet_tx_ring *); | 539 | void (*int_disable)(struct bcmgenet_tx_ring *); |
540 | void (*int_disable)(struct bcmgenet_priv *priv, | ||
541 | struct bcmgenet_tx_ring *); | ||
542 | struct bcmgenet_priv *priv; | 540 | struct bcmgenet_priv *priv; |
543 | }; | 541 | }; |
544 | 542 | ||