aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-06-27 05:08:25 -0400
committerJames Bottomley <JBottomley@Parallels.com>2012-07-20 03:58:38 -0400
commit9d5d93e32a365f962fb26ebd19c0b4a392f38e64 (patch)
tree80a96c1eb47ef1df23c6040a38fb39bc8716dfdb
parenta5254dbb17dd22999f808e646780c32858a3eafa (diff)
[SCSI] megaraid: cleanup type issue in mega_build_cmd()
On 64 bit systems the current code sets 32 bits of "seg" and leaves the other 32 uninitialized. It doesn't matter since the variable is never used. But it's still messy and we should fix it. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Adam Radford <aradford@gmail.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
-rw-r--r--drivers/scsi/megaraid.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 4d39a9ffc081..97825f116954 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -524,7 +524,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy)
524 mega_passthru *pthru; 524 mega_passthru *pthru;
525 scb_t *scb; 525 scb_t *scb;
526 mbox_t *mbox; 526 mbox_t *mbox;
527 long seg; 527 u32 seg;
528 char islogical; 528 char islogical;
529 int max_ldrv_num; 529 int max_ldrv_num;
530 int channel = 0; 530 int channel = 0;
@@ -858,7 +858,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy)
858 858
859 /* Calculate Scatter-Gather info */ 859 /* Calculate Scatter-Gather info */
860 mbox->m_out.numsgelements = mega_build_sglist(adapter, scb, 860 mbox->m_out.numsgelements = mega_build_sglist(adapter, scb,
861 (u32 *)&mbox->m_out.xferaddr, (u32 *)&seg); 861 (u32 *)&mbox->m_out.xferaddr, &seg);
862 862
863 return scb; 863 return scb;
864 864